Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Exercise guest SMART retained-error opt-in and organisation isolation

pulse-triage[bot]9a0ed18d7eaa
diff --git a/frontend-modern/src/components/Workloads/__tests__/GuestPhysicalDisks.test.tsx b/frontend-modern/src/components/Workloads/__tests__/GuestPhysicalDisks.test.tsx
index d99afba6c1..8131e5c45d 100644
--- a/frontend-modern/src/components/Workloads/__tests__/GuestPhysicalDisks.test.tsx
+++ b/frontend-modern/src/components/Workloads/__tests__/GuestPhysicalDisks.test.tsx
@@ -18,6 +18,7 @@ const queryState = vi.hoisted(() => ({
refetch: vi.fn<() => Promise<Resource[]>>(),
query: '',
enabled: false,
+ retainReadError: false,
realtimeEnabled: undefined as (() => boolean) | undefined,
}));
@@ -53,9 +54,11 @@ vi.mock('@/hooks/useUnifiedResources', () => ({
query: string;
enabled: () => boolean;
realtimeEnabled?: () => boolean;
+ retainReadError?: boolean;
}) => {
queryState.query = options.query;
queryState.enabled = options.enabled();
+ queryState.retainReadError = options.retainReadError === true;
queryState.realtimeEnabled = options.realtimeEnabled;
return {
resources: () => (queryState.accessor ? queryState.accessor() : queryState.resources),
@@ -104,6 +107,7 @@ describe('GuestPhysicalDisks', () => {
queryState.refetch.mockReset().mockResolvedValue([]);
queryState.query = '';
queryState.enabled = false;
+ queryState.retainReadError = false;
queryState.realtimeEnabled = undefined;
});
afterEach(() => {
@@ -116,6 +120,7 @@ describe('GuestPhysicalDisks', () => {
render(() => <GuestPhysicalDisks parentId="vm-resource-101" />);
expect(queryState.query).toBe('type=physical_disk&parent=vm-resource-101');
expect(queryState.enabled).toBe(true);
+ expect(queryState.retainReadError).toBe(true);
const card = screen.getByTestId('guest-physical-disks');
expect(within(card).getByText('Physical Disks & SMART (1)')).toBeInTheDocument();
expect(within(card).getByText('Guest SATA')).toBeInTheDocument();
@@ -370,7 +375,7 @@ describe('GuestPhysicalDisks', () => {
let settle!: () => void;
queryState.refetch.mockImplementation(() => {
setLoading(true);
- return new Promise<Resource[]>((resolve, reject) => {
+ return new Promise<Resource[]>((_resolve, reject) => {
settle = () => {
setLoading(false);
reject(new Error('unavailable'));
diff --git a/frontend-modern/src/hooks/__tests__/useUnifiedResources.test.ts b/frontend-modern/src/hooks/__tests__/useUnifiedResources.test.ts
index 3690c9eadc..9da242c62e 100644
--- a/frontend-modern/src/hooks/__tests__/useUnifiedResources.test.ts
+++ b/frontend-modern/src/hooks/__tests__/useUnifiedResources.test.ts
@@ -3501,6 +3501,7 @@ describe('useUnifiedResources', () => {
const disposals: (() => void)[] = [];
let peer!: ReturnType<typeof useUnifiedResources>;
let defaultConsumer!: ReturnType<typeof useUnifiedResources>;
+ let retainedConsumer!: ReturnType<typeof useUnifiedResources>;
createRoot((d) => {
disposals.push(d);
peer = useUnifiedResources({
@@ -3509,15 +3510,18 @@ describe('useUnifiedResources', () => {
cacheKey: 'guest-physical-disks:vm-beta',
});
defaultConsumer = useUnifiedResources({ ...options, retainReadError: false });
+ retainedConsumer = useUnifiedResources(options);
});
await flushAsync();
expect(peer.error()).toBeUndefined();
expect(defaultConsumer.error()).toBeUndefined();
+ expect(retainedConsumer.error()).toBe(failure);
// No organisation may inherit the other organisation's unavailable read.
eventBus.emit('org_switched', 'other-org');
await flushAsync();
expect(peer.error()).toBeUndefined();
expect(defaultConsumer.error()).toBeUndefined();
+ expect(retainedConsumer.error()).toBeUndefined();
for (const cleanup of disposals) cleanup();
});