Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Register PBS owner proofs beside their discovery and read owners

pulse-triage[bot]9cbe12abfefe
diff --git a/internal/monitoring/monitor_pbs_coverage_test.go b/internal/monitoring/monitor_pbs_coverage_test.go
index 140dabdf89..1511d0c23b 100644
--- a/internal/monitoring/monitor_pbs_coverage_test.go
+++ b/internal/monitoring/monitor_pbs_coverage_test.go
@@ -846,3 +846,9 @@ func TestPBSNamespaceDiscoveryLegacyRootOnlyRemainsComplete(t *testing.T) {
}
}
}
+
+// Exercise the real detached-discovery admission and its current binding,
+// rather than inferring lifecycle safety from a component observation.
+func TestPBSBudgetOwnerWithdrawsLatePublication(t *testing.T) {
+ exercisePBSBudgetOwnerWithdrawal(t)
+}
diff --git a/internal/monitoring/pbs_backup_lifecycle_test.go b/internal/monitoring/pbs_backup_lifecycle_test.go
index 66498873c0..eabeee4e88 100644
--- a/internal/monitoring/pbs_backup_lifecycle_test.go
+++ b/internal/monitoring/pbs_backup_lifecycle_test.go
@@ -19,7 +19,7 @@ func waitPBSBudget(t *testing.T, ch <-chan struct{}, phase string) {
}
}
-func TestPBSBudgetOwnerWithdrawsLatePublication(t *testing.T) {
+func exercisePBSBudgetOwnerWithdrawal(t *testing.T) {
for _, transition := range []string{"runtime cancellation", "runtime replacement", "client replacement", "client retirement"} {
t.Run(transition, func(t *testing.T) {
f := newPBSBudgetFixture(t, "vm", "datastore")
@@ -104,7 +104,7 @@ func TestPBSBudgetOwnerWithdrawsLatePublication(t *testing.T) {
}
}
-func TestPBSBudgetOldCompletionCannotReleaseNewClaim(t *testing.T) {
+func exercisePBSBudgetOldCompletion(t *testing.T) {
m := &Monitor{}
first, second := &pbs.Client{}, &pbs.Client{}
m.replacePBSClient("reader", first)
diff --git a/internal/monitoring/pbs_retryable_read_test.go b/internal/monitoring/pbs_retryable_read_test.go
index abb1ffe4f3..3807a1f2e1 100644
--- a/internal/monitoring/pbs_retryable_read_test.go
+++ b/internal/monitoring/pbs_retryable_read_test.go
@@ -124,3 +124,9 @@ func TestPBSRetryableReadWithoutCacheDoesNotInventFiles(t *testing.T) {
}
}
}
+
+// A canceled prior read cannot release a replacement's current claim or
+// erase the binding which survives an exhausted child collection budget.
+func TestPBSBudgetOldCompletionCannotReleaseNewClaim(t *testing.T) {
+ exercisePBSBudgetOldCompletion(t)
+}