Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Keep the observer choices readable without table scrolling

pulse-triage[bot]9fae0354d8a3
diff --git a/docs/UNIFIED_AGENT.md b/docs/UNIFIED_AGENT.md
index e6a9f9deb9..ea750a7344 100644
--- a/docs/UNIFIED_AGENT.md
+++ b/docs/UNIFIED_AGENT.md
@@ -670,10 +670,15 @@ requires its own `allowPlaintextHTTP` opt-in; that sends its API token and
reports in cleartext. The primary server's HTTP consent does not authorise an
observer.
-| Proxmox choice | Effect when Proxmox integration is enabled |
-| --- | --- |
-| `"provisionProxmox": false` | Sends agent telemetry without creating or repairing this observer's separately registered PVE/PBS source. It does not disable ordinary host, Docker/Podman or Kubernetes reports. |
-| `true`, or the field omitted | Includes this observer in Proxmox setup and periodic registration health checks. The agent can create or rotate a destination-scoped PVE/PBS API token and register its credentials with that Pulse server. |
+When Proxmox integration is enabled, the choices have different effects:
+
+- **`"provisionProxmox": false`** sends agent telemetry without creating or
+ repairing this observer's separately registered PVE/PBS source. It does not
+ disable ordinary host, Docker/Podman or Kubernetes reports.
+- **`true`, or the field omitted** includes this observer in Proxmox setup and
+ periodic registration health checks. The agent can create or rotate a
+ destination-scoped PVE/PBS API token and register its credentials with that
+ Pulse server.
**Omitting the field defaults to `true`, not telemetry only.** Choose that
additional API access deliberately; do not enable Proxmox integration or widen
diff --git a/frontend-modern/public/docs/UNIFIED_AGENT.md b/frontend-modern/public/docs/UNIFIED_AGENT.md
index e6a9f9deb9..ea750a7344 100644
--- a/frontend-modern/public/docs/UNIFIED_AGENT.md
+++ b/frontend-modern/public/docs/UNIFIED_AGENT.md
@@ -670,10 +670,15 @@ requires its own `allowPlaintextHTTP` opt-in; that sends its API token and
reports in cleartext. The primary server's HTTP consent does not authorise an
observer.
-| Proxmox choice | Effect when Proxmox integration is enabled |
-| --- | --- |
-| `"provisionProxmox": false` | Sends agent telemetry without creating or repairing this observer's separately registered PVE/PBS source. It does not disable ordinary host, Docker/Podman or Kubernetes reports. |
-| `true`, or the field omitted | Includes this observer in Proxmox setup and periodic registration health checks. The agent can create or rotate a destination-scoped PVE/PBS API token and register its credentials with that Pulse server. |
+When Proxmox integration is enabled, the choices have different effects:
+
+- **`"provisionProxmox": false`** sends agent telemetry without creating or
+ repairing this observer's separately registered PVE/PBS source. It does not
+ disable ordinary host, Docker/Podman or Kubernetes reports.
+- **`true`, or the field omitted** includes this observer in Proxmox setup and
+ periodic registration health checks. The agent can create or rotate a
+ destination-scoped PVE/PBS API token and register its credentials with that
+ Pulse server.
**Omitting the field defaults to `true`, not telemetry only.** Choose that
additional API access deliberately; do not enable Proxmox integration or widen
diff --git a/frontend-modern/src/features/docs/__tests__/agentObserverGuide.test.ts b/frontend-modern/src/features/docs/__tests__/agentObserverGuide.test.ts
index 80a442a07d..3d61f95b71 100644
--- a/frontend-modern/src/features/docs/__tests__/agentObserverGuide.test.ts
+++ b/frontend-modern/src/features/docs/__tests__/agentObserverGuide.test.ts
@@ -46,7 +46,7 @@ describe('Agent observer trust and API-access choice', () => {
it('keeps the omitted-field default and irreversible-access limits beside the choice', () => {
const section = observerSection();
- const rows = [...section.querySelectorAll('tbody tr')];
+ const rows = [...section.querySelectorAll('li')];
expect(rows).toHaveLength(2);
expect(rows[0].textContent).toContain('"provisionProxmox": false');
expect(rows[1].textContent).toContain('true, or the field omitted');
diff --git a/internal/agenttarget/documented_observer_test.go b/internal/agenttarget/documented_observer_test.go
index 8bc5aa6fcb..a4224d1f5f 100644
--- a/internal/agenttarget/documented_observer_test.go
+++ b/internal/agenttarget/documented_observer_test.go
@@ -3,6 +3,7 @@ package agenttarget
import (
"encoding/json"
"os"
+ "path"
"path/filepath"
"strings"
"testing"
@@ -36,7 +37,7 @@ func TestDocumentedObserverTelemetryChoice(t *testing.T) {
if target.ProvisionProxmox == nil || *target.ProvisionProxmox || target.InsecureSkipVerify || target.AllowPlaintextHTTP || !strings.HasPrefix(target.URL, "https://") {
t.Fatal("telemetry recipe must explicitly avoid extra API provisioning and retain verified HTTPS")
}
- if !filepath.IsAbs(target.TokenFile) || target.ServerFingerprint == "" {
+ if !path.IsAbs(target.TokenFile) || target.ServerFingerprint == "" {
t.Fatal("recipe must use a private token file and explicit trust")
}