Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Make cluster connection diagnostics usable by touch and keyboard

pulse-triage[bot]a05698f3d8b0
diff --git a/frontend-modern/src/components/Settings/NodeModalClusterMembersSection.tsx b/frontend-modern/src/components/Settings/NodeModalClusterMembersSection.tsx
index 22d24f8417..824c9ddf0a 100644
--- a/frontend-modern/src/components/Settings/NodeModalClusterMembersSection.tsx
+++ b/frontend-modern/src/components/Settings/NodeModalClusterMembersSection.tsx
@@ -52,14 +52,6 @@ export const NodeModalClusterMembersSection: Component<NodeModalClusterMembersSe
<div class="min-w-0">
<div class="flex items-center gap-1.5 text-sm text-base-content">
<span class="truncate">{endpoint.displayName || endpoint.nodeName}</span>
- <Show when={endpoint.pulseReachable === false}>
- <span
- class="inline-flex shrink-0 items-center rounded-full bg-amber-100 px-2 py-0.5 text-[11px] font-medium text-amber-800 dark:bg-amber-950/25 dark:text-amber-300"
- title={endpoint.pulseError || 'Pulse could not connect to this node'}
- >
- Unreachable
- </span>
- </Show>
</div>
<Show when={endpoint.displayName}>
<div class="truncate text-xs text-muted" title={endpoint.nodeName}>
@@ -69,6 +61,17 @@ export const NodeModalClusterMembersSection: Component<NodeModalClusterMembersSe
<div class="truncate text-xs text-muted" title={discoveredAddress(endpoint)}>
Discovered: {discoveredAddress(endpoint)}
</div>
+ <Show when={endpoint.pulseReachable === false}>
+ <details class="mt-2 rounded-md bg-amber-100 text-xs text-amber-800 dark:bg-amber-950/25 dark:text-amber-300">
+ <summary class="min-h-11 cursor-pointer rounded-md px-3 py-3 font-medium focus-visible:outline-2 focus-visible:outline-offset-2 focus-visible:outline-amber-600 dark:focus-visible:outline-amber-300">
+ Unreachable — details
+ <span class="sr-only"> for {endpoint.nodeName}</span>
+ </summary>
+ <p class="break-words whitespace-pre-wrap px-3 pb-3">
+ {endpoint.pulseError || 'Pulse could not connect to this node'}
+ </p>
+ </details>
+ </Show>
</div>
<div class="grid gap-2">
<label class="grid gap-1 text-xs text-muted">
diff --git a/frontend-modern/src/components/Settings/__tests__/NodeModalClusterMembersSection.test.tsx b/frontend-modern/src/components/Settings/__tests__/NodeModalClusterMembersSection.test.tsx
new file mode 100644
index 0000000000..47437d8011
--- /dev/null
+++ b/frontend-modern/src/components/Settings/__tests__/NodeModalClusterMembersSection.test.tsx
@@ -0,0 +1,167 @@
+import { cleanup, fireEvent, render, screen } from '@solidjs/testing-library';
+import { createSignal, type Setter } from 'solid-js';
+import { afterEach, describe, expect, it, vi } from 'vitest';
+import type { ClusterEndpoint, NodeConfig } from '@/types/nodes';
+import { NodeModalClusterMembersSection } from '../NodeModalClusterMembersSection';
+import type { NodeModalProps } from '../nodeModalModel';
+import { useNodeModalState } from '../useNodeModalState';
+
+const trustReason =
+ 'TLS trust conflict - equivalent endpoint URLs have different saved fingerprints; independently verify and reconcile saved trust';
+
+const member = (overrides: Partial<ClusterEndpoint> = {}): ClusterEndpoint => ({
+ nodeId: 'node/member',
+ nodeIdentity: 'member-identity',
+ nodeName: 'member',
+ host: 'https://member.example.invalid:8006',
+ ip: '192.0.2.2',
+ online: true,
+ lastSeen: '2026-10-14T14:00:00Z',
+ pulseReachable: false,
+ pulseError: trustReason,
+ ...overrides,
+});
+
+const cluster = (endpoints: ClusterEndpoint[]): NodeConfig => ({
+ id: 'fixture-cluster',
+ type: 'pve',
+ name: 'Fixture cluster',
+ host: 'https://primary.example.invalid:8006',
+ user: 'fixture@pve',
+ hasToken: true,
+ tokenName: 'fixture@pve!monitoring',
+ verifySSL: true,
+ monitorVMs: true,
+ monitorContainers: true,
+ monitorStorage: true,
+ monitorBackups: true,
+ monitorPhysicalDisks: false,
+ isCluster: true,
+ clusterEndpoints: endpoints,
+});
+
+function renderMembers(endpoints = [member()]) {
+ const onSave = vi.fn();
+ const fetch = vi.fn();
+ vi.stubGlobal('fetch', fetch);
+ let setNode!: Setter<NodeConfig>;
+ const Harness = () => {
+ const [node, updateNode] = createSignal(cluster(endpoints));
+ setNode = updateNode;
+ const modalProps: NodeModalProps = {
+ isOpen: true,
+ nodeType: 'pve',
+ get editingNode() {
+ return node();
+ },
+ onClose: vi.fn(),
+ onSave,
+ };
+ const state = useNodeModalState(modalProps);
+ return (
+ <form onSubmit={state.handleSubmit}>
+ <NodeModalClusterMembersSection modalProps={modalProps} state={state} />
+ <button type="submit">Save fixture</button>
+ </form>
+ );
+ };
+ const view = render(() => <Harness />);
+ return { ...view, fetch, onSave, setNode };
+}
+
+describe('Cluster member connection diagnostics', () => {
+ afterEach(() => {
+ cleanup();
+ vi.unstubAllGlobals();
+ });
+
+ it('gives a refused online member a named native disclosure with its actual reason', () => {
+ const { container, fetch, onSave } = renderMembers();
+ const summary = container.querySelector('summary')!;
+ expect(summary.tagName).toBe('SUMMARY');
+ expect(summary.parentElement?.tagName).toBe('DETAILS');
+ expect(summary).toHaveTextContent('Unreachable — details for member');
+ expect(summary).not.toHaveAttribute('title');
+ expect(screen.getByText(trustReason).tagName).toBe('P');
+ expect(screen.getByText('Discovered: member.example.invalid:8006 (192.0.2.2)')).toBeVisible();
+ // Native keyboard/touch activation and collapsed accessibility are checked
+ // in real browsers, not emulated by jsdom.
+ expect(summary.parentElement).not.toHaveAttribute('open');
+ expect(fetch).not.toHaveBeenCalled();
+ expect(onSave).not.toHaveBeenCalled();
+ });
+
+ it.each([undefined, null, true])(
+ 'does not mislabel reachability %s as a failed connection',
+ (reachable) => {
+ const { container } = renderMembers([member({ pulseReachable: reachable })]);
+ expect(container.querySelector('details')).not.toBeInTheDocument();
+ expect(screen.queryByText(trustReason)).not.toBeInTheDocument();
+ },
+ );
+
+ it.each([undefined, ''])('keeps a usable generic explanation when the error is %s', (error) => {
+ const { container } = renderMembers([member({ pulseError: error })]);
+ expect(container.querySelector('summary')).toHaveTextContent(
+ 'Unreachable — details for member',
+ );
+ expect(screen.getByText('Pulse could not connect to this node')).toBeInTheDocument();
+ });
+
+ it('renders error markup literally rather than making it executable', () => {
+ const error = '<img src="untrusted" onerror="alert(1)">';
+ const { container } = renderMembers([member({ pulseError: error })]);
+ expect(screen.getByText(error)).toBeInTheDocument();
+ expect(container.querySelector('img')).not.toBeInTheDocument();
+ });
+
+ it('keeps each member reason separate, including members with the same native name', () => {
+ const { container } = renderMembers([
+ member(),
+ member({
+ nodeId: 'node/duplicate',
+ nodeIdentity: 'duplicate-identity',
+ pulseError: 'Connection timed out',
+ }),
+ ]);
+ const details = container.querySelectorAll('details');
+ expect(details).toHaveLength(2);
+ expect(details[0]).toHaveTextContent(trustReason);
+ expect(details[0]).not.toHaveTextContent('Connection timed out');
+ expect(details[1]).toHaveTextContent('Connection timed out');
+ expect(details[1]).not.toHaveTextContent(trustReason);
+ });
+
+ it('clears stale diagnostics on recovery without losing dirty names or address overrides', () => {
+ const { container, setNode, fetch, onSave } = renderMembers();
+ fireEvent.input(screen.getByLabelText('Display name for member'), {
+ target: { value: 'Operator label' },
+ });
+ fireEvent.input(screen.getByLabelText('Connection address for member'), {
+ target: { value: 'member.example.invalid:8006' },
+ });
+ setNode(cluster([member({ pulseReachable: true, pulseError: undefined })]));
+ expect(container.querySelector('details')).not.toBeInTheDocument();
+ expect(screen.getByLabelText('Display name for member')).toHaveValue('Operator label');
+ expect(screen.getByLabelText('Connection address for member')).toHaveValue(
+ 'member.example.invalid:8006',
+ );
+ expect(fetch).not.toHaveBeenCalled();
+ expect(onSave).not.toHaveBeenCalled();
+
+ // Saving remains a deliberate, separate action using the existing payload.
+ fireEvent.click(screen.getByRole('button', { name: 'Save fixture' }));
+ expect(onSave).toHaveBeenCalledOnce();
+ expect(onSave.mock.calls[0][0]).toMatchObject({
+ type: 'pve',
+ verifySSL: true,
+ clusterNodeDisplayNameOverrides: [
+ { nodeIdentity: 'member-identity', displayName: 'Operator label' },
+ ],
+ clusterEndpointOverrides: [{ nodeName: 'member', ipOverride: 'member.example.invalid:8006' }],
+ });
+ expect(onSave.mock.calls[0][0]).not.toHaveProperty('tokenValue');
+ expect(onSave.mock.calls[0][0]).not.toHaveProperty('password');
+ expect(fetch).not.toHaveBeenCalled();
+ });
+});