Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Pin the serializer repair to one controlled Solid graph

pulse-triage[bot]a345eca7dd85
diff --git a/docs/release-control/v6/internal/subsystems/deployment-installability.md b/docs/release-control/v6/internal/subsystems/deployment-installability.md
index 84bc546d61..d9114e9568 100644
--- a/docs/release-control/v6/internal/subsystems/deployment-installability.md
+++ b/docs/release-control/v6/internal/subsystems/deployment-installability.md
@@ -5911,8 +5911,9 @@ metadata and a lockfile do not by themselves clear an audit failure.
Ordinary frontend CI must check Solid's actual locked Seroval and plugin
dependency edges before installing the graph. An npm override cannot silently
reuse an older compatibility proof after the consumer changes its requirements.
-`scripts/check-frontend-serialization.mjs` preserves only the exact qualified
-Solid `1.9.15` / Seroval `1.6.3` root override of `~1.5.4`; otherwise each
+`scripts/check-frontend-serialization.mjs` preserves the exact qualified
+Solid `1.9.15` / Seroval `1.6.3` root override of `~1.5.4` and the separately
+controlled current tuple below; otherwise each
resolved serializer must satisfy Solid's full stable tilde range, including
nested consumers and dependencies. New range forms require review. The
standalone regression suite rejects the Solid `1.9.16` / `~1.6.8` update with
@@ -5921,6 +5922,30 @@ the non-optional pre-install CI wiring. This is a graph-admission check, not
official-byte authenticity, a security-audit verdict or installed UI proof;
the existing security floors and actual consumer tests remain required.
+The current serializer override is deliberately narrower than a maintained-major
+range: Solid `1.9.17` continues to declare Seroval and seroval-plugins `~1.6.8`,
+while the root Seroval override is pinned to `1.7.3`. The unchanged root
+seroval-plugins `1.6.8` still declares its Seroval peer as `^1.0`. Seroval's
+Node `>=20` requirement fits the declared Node 24 build. No new Solid, plugin,
+declared edge or nested resolution can borrow this exact compatibility
+exception. The pre-install guard tests enforce those limits; the old `1.9.15`
+exception is not evidence for this tuple. The complete lock retains the
+canonical representation of the unchanged optional Tailwind WASI bundle and
+all unrelated dependency floors.
+
+`solidSerialization.test.ts`, run by the ordinary frontend test command, uses
+the installed Solid Node server export, not a mock Serializer or only the
+standalone Seroval API. Its actual resource/Suspense and late streaming paths
+must preserve cyclic/shared values, typed view offsets and shared buffers,
+default URL/Headers plugins, script-text escaping, nonces, render scopes and
+`noScripts`. Installed versions/resolution must match the committed lock. The
+existing standalone plugin consumers and security floors remain required.
+These executable controls and a structural guard do not themselves qualify an
+unexecuted graph: exact acquired-graph source/type/build and consuming desktop/
+narrow-browser proof, with inspected pixels, and the complete hosted dependency
+audit remain required. Older-graph passes and official resource observations
+cannot substitute for them or establish advisory clearance.
+
That same dev-runtime dependency-manifest boundary now also owns the maintained
Docker engine module floor. `go.mod`, `go.sum`, and
`internal/cloudcp/docker/manager.go` must route hosted runtime orchestration
diff --git a/frontend-modern/package-lock.json b/frontend-modern/package-lock.json
index 82641a166b..b25efc6ec1 100644
--- a/frontend-modern/package-lock.json
+++ b/frontend-modern/package-lock.json
@@ -5315,11 +5315,11 @@
}
},
"node_modules/seroval": {
- "version": "1.6.8",
- "resolved": "https://registry.npmjs.org/seroval/-/seroval-1.6.8.tgz",
- "integrity": "sha512-HlSgSAkTk4EqHcje1ptJjfZi1YDv5KbhVJ/d3P7T/nAXua2VmDu+AKDX5VTdFfZf48nDkWB2TKYt0DrCSa+3wg==",
+ "version": "1.7.3",
+ "resolved": "https://registry.npmjs.org/seroval/-/seroval-1.7.3.tgz",
+ "integrity": "sha512-fYkZS/GrMJhj1CW+IDoPlILRmYl5/S9L/OYju/sA2K/HQ3G5JBWDZHxaUWVZV/0hfAC2n1+9ysBRDtqMbMXvzA==",
"engines": {
- "node": ">=10"
+ "node": ">=20"
}
},
"node_modules/seroval-plugins": {
diff --git a/frontend-modern/package.json b/frontend-modern/package.json
index 0b01b90a23..5e8b93bcaa 100644
--- a/frontend-modern/package.json
+++ b/frontend-modern/package.json
@@ -62,7 +62,7 @@
"overrides": {
"esbuild": "0.28.1",
"form-data": "^4.0.6",
- "seroval": "^1.6.3",
+ "seroval": "1.7.3",
"seroval-plugins": "^1.4.1",
"@babel/core": "^7.29.6",
"js-yaml": "^4.3.2",
diff --git a/frontend-modern/src/security/__tests__/dependencySecurity.test.ts b/frontend-modern/src/security/__tests__/dependencySecurity.test.ts
index 5e1b0d3596..918cffc33a 100644
--- a/frontend-modern/src/security/__tests__/dependencySecurity.test.ts
+++ b/frontend-modern/src/security/__tests__/dependencySecurity.test.ts
@@ -98,7 +98,9 @@ describe('frontend dependency security floors', () => {
// GHSA-68fv-2mgg-jv7q: all PostCSS/source-map consumers need the fix.
['source-map-js', [1, 2, 2]],
])('keeps every %s copy above the October deserialization and parsing floors', (name, floor) => {
- expect(manifest.overrides[name]).toBe(`^${floor.join('.')}`);
+ // Seroval now deliberately crosses Solid's declared minor. Pin that one
+ // reviewed tuple rather than allowing the caret to admit future minors.
+ expect(manifest.overrides[name]).toBe(name === 'seroval' ? '1.7.3' : `^${floor.join('.')}`);
const versions = lockedVersions(name);
expect(versions, `${name} must be locked`).not.toHaveLength(0);
for (const version of versions) {
@@ -108,6 +110,13 @@ describe('frontend dependency security floors', () => {
}
});
+ it('pins every Seroval copy to the override exercised by the real Solid consumers', () => {
+ expect(manifest.overrides.seroval).toBe('1.7.3');
+ expect(lockedVersions('seroval')).toEqual(['1.7.3']);
+ expect(lockedVersions('solid-js')).toEqual(['1.9.17']);
+ expect(lockedVersions('seroval-plugins')).toEqual(['1.6.8']);
+ });
+
it('keeps Vitest and its mocker above the redirect-mock file-read floor', () => {
// GHSA-82fw-gwwq-j7x9: the maintained 4.x fix starts at 4.1.11.
// GHSA-qxg6-89mg-rqv8 (manual mock registration code injection) and
diff --git a/scripts/check-frontend-serialization.mjs b/scripts/check-frontend-serialization.mjs
index d18673226b..2ab3dd9651 100644
--- a/scripts/check-frontend-serialization.mjs
+++ b/scripts/check-frontend-serialization.mjs
@@ -63,10 +63,25 @@ export function serializationGraphErrors(lock) {
// 795e534517 qualified this one security override with actual cyclic,
// typed-array and plugin consumers. Preserve it, but do not apply that
// old proof to a new consumer, dependency, declared range or nested copy.
- const qualifiedOverride = path === 'node_modules/solid-js' &&
+ const legacyOverride = path === 'node_modules/solid-js' &&
consumer.version === '1.9.15' && dependency === 'seroval' &&
range === '~1.5.4' && resolved.path === 'node_modules/seroval' &&
resolved.entry.version === '1.6.3';
+ // This deliberately pinned override has its own actual Solid resource,
+ // async/streaming and default-plugin consumers in solidSerialization.test.ts.
+ // It is not an extension of the old exception or blanket 1.x approval.
+ // Changing either consumer, declared edge, nearest resolution or plugin
+ // requires fresh compatibility review, not another permissive npm range.
+ const plugin = resolvedDependency(packages, path, 'seroval-plugins');
+ const currentOverride = path === 'node_modules/solid-js' &&
+ consumer.version === '1.9.17' && dependency === 'seroval' &&
+ range === '~1.6.8' && resolved.path === 'node_modules/seroval' &&
+ resolved.entry.version === '1.7.3' &&
+ consumer.dependencies?.['seroval-plugins'] === '~1.6.8' &&
+ plugin?.path === 'node_modules/seroval-plugins' &&
+ plugin.entry?.version === '1.6.8' &&
+ plugin.entry.peerDependencies?.seroval === '^1.0';
+ const qualifiedOverride = legacyOverride || currentOverride;
if (!compatible && !qualifiedOverride) {
errors.push(`Solid ${consumer.version} requires ${dependency} ${range}, but resolves ${resolved.entry.version}. Update the coupled graph and retain consumer compatibility proof; an npm override is not that proof.`);
}
diff --git a/scripts/tests/check-frontend-serialization.test.mjs b/scripts/tests/check-frontend-serialization.test.mjs
index aac66a2014..16ae8326a7 100644
--- a/scripts/tests/check-frontend-serialization.test.mjs
+++ b/scripts/tests/check-frontend-serialization.test.mjs
@@ -9,7 +9,7 @@ function graph(solid = '1.9.16', range = '~1.6.8', seroval = '1.6.8', plugins =
packages: {
'node_modules/solid-js': { version: solid, dependencies: { seroval: range, 'seroval-plugins': range } },
'node_modules/seroval': { version: seroval },
- 'node_modules/seroval-plugins': { version: plugins },
+ 'node_modules/seroval-plugins': { version: plugins, peerDependencies: { seroval: '^1.0' } },
},
};
}
@@ -62,6 +62,56 @@ test('a different serializer cannot borrow the exact old override', () => {
assert.equal(serializationGraphErrors(graph('1.9.15', '~1.5.4', '1.6.4', '1.5.5')).length, 1);
});
+test('the deliberate current override preserves the exact Solid and plugin consumers', () => {
+ assert.deepEqual(serializationGraphErrors(graph('1.9.17', '~1.6.8', '1.7.3', '1.6.8')), []);
+});
+
+test('other Solid versions cannot borrow the current override', () => {
+ for (const solid of ['1.9.16', '1.9.18', '2.0.0']) {
+ assert.equal(serializationGraphErrors(graph(solid, '~1.6.8', '1.7.3', '1.6.8')).length, 1);
+ }
+});
+
+test('another serializer version or declared edge cannot borrow the current override', () => {
+ for (const version of ['1.7.2', '1.7.4', '1.8.0', '2.0.0']) {
+ assert.equal(serializationGraphErrors(graph('1.9.17', '~1.6.8', version, '1.6.8')).length, 1);
+ }
+ assert.equal(serializationGraphErrors(graph('1.9.17', '~1.6.7', '1.7.3', '1.6.8')).length, 1);
+});
+
+test('the unchanged plugin tuple is part of current override admission', () => {
+ for (const version of ['1.6.7', '1.6.9', '1.7.3']) {
+ assert.ok(serializationGraphErrors(graph('1.9.17', '~1.6.8', '1.7.3', version)).length > 0);
+ }
+ const lock = graph('1.9.17', '~1.6.8', '1.7.3', '1.6.8');
+ lock.packages['node_modules/solid-js'].dependencies['seroval-plugins'] = '~1.6.7';
+ assert.equal(serializationGraphErrors(lock).length, 1);
+});
+
+test('absent or changed plugin peer metadata cannot borrow the current override', () => {
+ for (const peer of [undefined, '^2.0', '~1.6.8']) {
+ const lock = graph('1.9.17', '~1.6.8', '1.7.3', '1.6.8');
+ lock.packages['node_modules/seroval-plugins'].peerDependencies.seroval = peer;
+ assert.equal(serializationGraphErrors(lock).length, 1);
+ }
+});
+
+test('nested serializer and plugin resolutions cannot borrow the current override', () => {
+ for (const name of ['seroval', 'seroval-plugins']) {
+ const lock = graph('1.9.17', '~1.6.8', '1.7.3', '1.6.8');
+ lock.packages[`node_modules/solid-js/node_modules/${name}`] =
+ structuredClone(lock.packages[`node_modules/${name}`]);
+ assert.equal(serializationGraphErrors(lock).length, 1);
+ }
+});
+
+test('a nested Solid cannot borrow the root-only current override', () => {
+ const lock = graph('1.9.17', '~1.6.8', '1.7.3', '1.6.8');
+ lock.packages['node_modules/fixture/node_modules/solid-js'] =
+ structuredClone(lock.packages['node_modules/solid-js']);
+ assert.equal(serializationGraphErrors(lock).length, 1);
+});
+
test('nested resolution wins over a correct root serializer', () => {
const lock = graph();
lock.packages['node_modules/solid-js/node_modules/seroval'] = { version: '1.6.3' };