Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Use observed capacity and forward report time in node disk controls

pulse-triage[bot]a940a089d815
diff --git a/internal/alerts/alerts_test.go b/internal/alerts/alerts_test.go
index a78ad933bd..5f5bff62a6 100644
--- a/internal/alerts/alerts_test.go
+++ b/internal/alerts/alerts_test.go
@@ -15870,6 +15870,8 @@ func TestCheckNode(t *testing.T) {
Instance: "pve1",
Status: "online",
Disk: models.Disk{
+ Total: 100,
+ Used: 95,
Usage: 95.0, // Above trigger
},
}
diff --git a/internal/alerts/node_disk_observation_test.go b/internal/alerts/node_disk_observation_test.go
index 9ed9289b1a..76f340b695 100644
--- a/internal/alerts/node_disk_observation_test.go
+++ b/internal/alerts/node_disk_observation_test.go
@@ -187,7 +187,7 @@ func TestNodeDiskUnknownHonoursExplicitPolicy(t *testing.T) {
}
func TestNodeDiskUnknownLeavesIndependentMetricsAndAgentHandover(t *testing.T) {
- m, _ := nodeDiskManager(t, false)
+ m, clock := nodeDiskManager(t, false)
m.mu.Lock()
m.config.NodeDefaults.CPU = &HysteresisThreshold{Trigger: 80, Clear: 70}
m.config.NodeDefaults.Memory = &HysteresisThreshold{Trigger: 80, Clear: 70}
@@ -217,10 +217,14 @@ func TestNodeDiskUnknownLeavesIndependentMetricsAndAgentHandover(t *testing.T) {
t.Fatal("handover lost agent disk incident")
}
m.HandleHostRemoved(host)
+ // Handover release uses its real observation time. Later reports must
+ // advance the synthetic clock too, rather than predate that release.
+ clock.Store(int64(time.Second))
m.CheckNode(gap)
if testHasActiveAlert(t, m, canonicalMetricStateID(node.ID, "disk")) {
t.Fatal("removing agent invented a node reading")
}
+ clock.Add(int64(time.Second))
m.CheckNode(node)
if !testHasActiveAlert(t, m, canonicalMetricStateID(node.ID, "disk")) {
t.Fatal("fresh node disk did not regain ownership")