Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Retain disclosed backup task cards while revealing more

pulse-triage[bot]a9b01730b303
diff --git a/docs/release-control/v6/internal/subsystems/storage-recovery.md b/docs/release-control/v6/internal/subsystems/storage-recovery.md
index f137b4d9eb..4c824d6011 100644
--- a/docs/release-control/v6/internal/subsystems/storage-recovery.md
+++ b/docs/release-control/v6/internal/subsystems/storage-recovery.md
@@ -8453,14 +8453,16 @@ recovery path.
When missing, future or tied start times leave multiple possible latest tasks,
Coverage initially renders eight task detail cards, not the whole provider
-history. The preview includes a witness of each observed outcome (including
-error text) and known/unknown-start group, preserving the model's deterministic,
+history. The preview samples each failed-or-error-bearing, running, OK and
+other-status group with known/unknown starts, preserving the model's deterministic,
explicitly non-chronological order. Full-candidate status, error-text and unknown-
start counts remain visible, and every candidate stays available through an
explicit eight-at-a-time control without more API reads. Search continues to
match the complete workload evidence, not just its preview.
Deliberate preview expansion survives ordinary polling of the open workload.
+Existing task cards stay mounted when another page is revealed, rather than
+rebuilding all previously visible cards. Their grid follows the local container.
The same control retains focus when the list shrinks, becomes ordered or empties;
its exhausted state is guarded. Opening another workload or reopening the panel
starts bounded again. No candidate is discarded, no latest task is chosen from
diff --git a/frontend-modern/src/features/proxmox/ProxmoxCoverageTable.tsx b/frontend-modern/src/features/proxmox/ProxmoxCoverageTable.tsx
index 59d9627f72..9eab04c27c 100644
--- a/frontend-modern/src/features/proxmox/ProxmoxCoverageTable.tsx
+++ b/frontend-modern/src/features/proxmox/ProxmoxCoverageTable.tsx
@@ -308,7 +308,7 @@ function CoverageTaskCandidates(props: { tasks: readonly CoverageTask[] }) {
});
return (
<Show when={props.tasks.length > 0 || retainControl()}>
- <div class="space-y-2" data-coverage-task-candidates>
+ <div class="@container/task-evidence min-w-0 space-y-2" data-coverage-task-candidates>
<p class="text-[11px] text-muted whitespace-normal wrap-anywhere" role="status">
Showing {preview().length} of {props.tasks.length} possible latest tasks.
<Show when={props.tasks.length === 0}> No uncertain tasks remain in this read.</Show>
@@ -317,8 +317,8 @@ function CoverageTaskCandidates(props: { tasks: readonly CoverageTask[] }) {
<p class="text-[11px] text-muted whitespace-normal wrap-anywhere">{counts()}</p>
<Show when={props.tasks.length > preview().length}>
<p class="text-[11px] text-muted whitespace-normal wrap-anywhere">
- The preview includes each observed outcome and known or unknown start group. It is not
- a time order.
+ The preview samples outcomes and known or unknown starts. Full counts include tasks
+ outside the preview. It is not a time order.
</p>
</Show>
</Show>
@@ -327,7 +327,7 @@ function CoverageTaskCandidates(props: { tasks: readonly CoverageTask[] }) {
<Show when={retainControl()}>
<button
type="button"
- class="rounded-sm px-2 py-1 text-xs font-medium text-accent hover:bg-surface-hover focus-visible:outline focus-visible:outline-2 focus-visible:outline-offset-2 focus-visible:outline-accent"
+ class="min-h-10 rounded-sm px-2 py-1 text-xs font-medium text-accent hover:bg-surface-hover focus-visible:outline focus-visible:outline-2 focus-visible:outline-offset-2 focus-visible:outline-accent"
aria-disabled={preview().length >= props.tasks.length}
onClick={() => {
if (preview().length < props.tasks.length)
@@ -357,14 +357,27 @@ function CoverageTaskCandidates(props: { tasks: readonly CoverageTask[] }) {
</p>
),
},
- ...preview().map((task) =>
- buildCoverageTaskSection(
- task,
- `Possible latest task ${props.tasks.indexOf(task) + 1}`,
- ),
- ),
]}
/>
+ {/* Keep existing cards when another page is revealed. Rebuilding one
+ large sections array would recreate every previous task as well. */}
+ <div class="grid min-w-0 grid-cols-1 gap-2 @min-[48rem]/task-evidence:grid-cols-2 @min-[64rem]/task-evidence:grid-cols-3">
+ <For each={preview()}>
+ {(task) => (
+ <div class="min-w-0" data-coverage-task-card={task.id}>
+ <DetailSectionTable
+ wrapValues
+ sections={[
+ buildCoverageTaskSection(
+ task,
+ `Possible latest task ${props.tasks.indexOf(task) + 1}`,
+ ),
+ ]}
+ />
+ </div>
+ )}
+ </For>
+ </div>
</Show>
</div>
</Show>
diff --git a/frontend-modern/src/features/proxmox/__tests__/backupTaskEvidence.test.tsx b/frontend-modern/src/features/proxmox/__tests__/backupTaskEvidence.test.tsx
index 51c77107f9..6608191121 100644
--- a/frontend-modern/src/features/proxmox/__tests__/backupTaskEvidence.test.tsx
+++ b/frontend-modern/src/features/proxmox/__tests__/backupTaskEvidence.test.tsx
@@ -372,17 +372,21 @@ describe('bounded uncertain-task inspection', () => {
mount();
const panel = await open();
const more = within(panel).getByRole('button', { name: 'Show 8 more possible latest tasks' });
+ const firstCard = panel.querySelector('[data-coverage-task-card="history-000"]');
+ expect(firstCard).not.toBeNull();
more.focus();
for (let expected = 16; expected <= 200; expected += 8) {
fireEvent.click(more);
expect(cards(panel)).toHaveLength(expected);
expect(document.activeElement).toBe(more);
+ expect(panel.querySelector('[data-coverage-task-card="history-000"]')).toBe(firstCard);
}
expect(more).toHaveTextContent('All 200 possible latest tasks shown');
expect(more).toHaveAttribute('aria-disabled', 'true');
fireEvent.click(more);
expect(cards(panel)).toHaveLength(200);
- for (const task of tasks) expect(panel).toHaveTextContent(task.id);
+ const content = panel.textContent;
+ for (const task of tasks) expect(content).toContain(task.id);
expect(api.fetch).toHaveBeenCalledTimes(2);
expect(api.json).toHaveBeenCalledTimes(1);
});