Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Finish successful automatic updates without a dead API call

pulse-triage[bot]ac3ba2f21fce
diff --git a/scripts/pulse-auto-update.sh b/scripts/pulse-auto-update.sh
index 9b1c534dcd..99bcc8fcc6 100755
--- a/scripts/pulse-auto-update.sh
+++ b/scripts/pulse-auto-update.sh
@@ -885,15 +885,9 @@ main() {
# Perform update
if perform_update "$latest_version"; then
log info "Update completed successfully to $latest_version"
-
- # Send notification if webhooks are configured
- if [[ -f "$CONFIG_DIR/webhooks.enc" ]] || [[ -f "$CONFIG_DIR/webhooks.json" ]]; then
- # Create a simple notification via the Pulse API
- curl -s -X POST "http://localhost:7655/api/internal/notification" \
- -H "Content-Type: application/json" \
- -d "{\"type\":\"update\",\"message\":\"Pulse automatically updated from $current_version to $latest_version\"}" \
- 2>/dev/null || true
- fi
+ # Completion is recorded in the journal. Pulse has no internal
+ # notification endpoint; a best-effort loopback POST cannot prove
+ # delivery and must not hold this successful oneshot open.
else
log error "Update failed"
exit 1