Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Align Docker replacement fixtures with ordinary publication

pulse-triage[bot]acddcdd53f61
diff --git a/docs/release-control/v6/internal/subsystems/registry.json b/docs/release-control/v6/internal/subsystems/registry.json
index 3e89a8a06d..5977b385f7 100644
--- a/docs/release-control/v6/internal/subsystems/registry.json
+++ b/docs/release-control/v6/internal/subsystems/registry.json
@@ -7106,6 +7106,7 @@
"allow_same_subsystem_tests": false,
"test_prefixes": [],
"exact_files": [
+ "internal/dockeragent/docker_hub_reference_test.go",
"internal/dockeragent/image_replacement_test.go",
"internal/dockeragent/registry_credentials_test.go",
"internal/dockeragent/registry_image_change_test.go",
diff --git a/internal/dockeragent/docker_hub_reference_test.go b/internal/dockeragent/docker_hub_reference_test.go
index b4412696ba..0f17b3e985 100644
--- a/internal/dockeragent/docker_hub_reference_test.go
+++ b/internal/dockeragent/docker_hub_reference_test.go
@@ -110,17 +110,19 @@ func TestDockerHubAliasLookupContract(t *testing.T) {
if len(requests) != 3 {
t.Fatalf("requests = %v, want token, HEAD and GET", requests)
}
+ // A different mismatching local image refreshes once; equivalent Hub
+ // aliases for that same image then share the refreshed result.
for _, cachedRef := range []string{wantRepo + ":stable", "docker.io/" + wantRepo + ":stable", "index.docker.io/" + wantRepo + ":stable"} {
got = checker.CheckImageUpdate(context.Background(), cachedRef, "sha256:old", "amd64", "linux", "")
if got == nil || got.Error != "" || !got.UpdateAvailable || got.LatestDigest != indexDigest {
t.Fatalf("changed-image cached lookup = %+v", got)
}
}
- if len(requests) != 3 {
- t.Error("equivalent Hub aliases repeated a cached registry lookup")
+ if len(requests) != 6 {
+ t.Error("equivalent Hub aliases did not share one replacement refresh")
}
got = checker.CheckImageUpdate(context.Background(), ref, "sha256:armv7", "arm", "linux", "v7")
- if got == nil || got.Error != "" || got.UpdateAvailable || got.LatestDigest != indexDigest || len(requests) != 6 {
+ if got == nil || got.Error != "" || got.UpdateAvailable || got.LatestDigest != indexDigest || len(requests) != 9 {
t.Fatalf("ARMv7 lookup did not keep its separate platform cache: %+v", got)
}
})
diff --git a/internal/dockeragent/image_replacement_test.go b/internal/dockeragent/image_replacement_test.go
index f8ef7fc834..fe224015b1 100644
--- a/internal/dockeragent/image_replacement_test.go
+++ b/internal/dockeragent/image_replacement_test.go
@@ -131,6 +131,12 @@ func TestCollectContainerImageReplacementRefreshesRegistry(t *testing.T) {
if len(active) != 0 {
t.Fatalf("%s: update alerted before its delay: %+v", phase, active)
}
+ // Accepted reports coalesce canonical publication over the
+ // monitor's normal two-second window. This fixture produces
+ // reports much faster than the real 30s collection interval;
+ // let the ordinary trailing publication run before the read.
+ // Do not force/invalidate the consumer's store or cache.
+ time.Sleep(2200 * time.Millisecond)
req := httptest.NewRequest(http.MethodGet, "/api/resources?type=app-container&limit=100", nil)
req.Header.Set("X-API-Token", readerToken)
rec := httptest.NewRecorder()