Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Bind the TrueNAS memory fixture to its requested reporting range

pulse-triage[bot]ae04cf9a7f73
diff --git a/internal/truenas/core_realtime_memory_clock_test.go b/internal/truenas/core_realtime_memory_clock_test.go
new file mode 100644
index 0000000000..33655f3749
--- /dev/null
+++ b/internal/truenas/core_realtime_memory_clock_test.go
@@ -0,0 +1,36 @@
+package truenas
+
+import (
+ "context"
+ "testing"
+)
+
+func TestCORE13MemoryFixtureUsesRequestedReportingEnd(t *testing.T) {
+ scenario := &coreMemoryScenario{version: "TrueNAS-SCALE-24.10.2", restARC: 8 << 30}
+ client := coreMemoryClient(t, scenario, ClientConfig{APIKey: "synthetic-key"})
+ // Fixed query windows expose a responder clock outside the request without
+ // relying on a sleep or a lucky wall-clock second rollover. A second query
+ // also prevents a fixture from reusing the first request's timestamp.
+ for _, end := range []int64{1789000060, 1789000120} {
+ responses, err := client.getLegacySystemReportingData(context.Background(), reportingRangeQuery(end-60, end))
+ if err != nil {
+ t.Fatal(err)
+ }
+ for _, response := range responses {
+ if len(response.Data) > 0 && (response.Start != end || response.End != end) {
+ t.Errorf("%s fixture range [%d, %d] does not match requested sample time %d", response.Name, response.Start, response.End, end)
+ }
+ }
+ system := systemInfoFromMetricHistory(parseSystemMetricHistory(liveReportingResponses(responses, end)))
+ if system == nil {
+ t.Error("fixture samples were discarded outside the requested live window")
+ continue
+ }
+ if system.CollectedAt.Unix() != end || system.CPUPercent != 12 || system.MemoryAvailableBytes != 2178945024 || system.ARCSizeBytes != 8<<30 || !system.Telemetry.CPU || !system.Telemetry.Memory {
+ t.Errorf("request-bound fixture lost reporting readings: %+v", system)
+ }
+ }
+ if scenario.sockets.Load() != 0 {
+ t.Fatal("reporting fixture used the native DDP memory path")
+ }
+}
diff --git a/internal/truenas/core_realtime_memory_test.go b/internal/truenas/core_realtime_memory_test.go
index 185a5e710e..4750594a0c 100644
--- a/internal/truenas/core_realtime_memory_test.go
+++ b/internal/truenas/core_realtime_memory_test.go
@@ -185,8 +185,26 @@ func coreMemoryClient(t *testing.T, scenario *coreMemoryScenario, config ClientC
fmt.Fprint(w, `{"error":"synthetic"}`)
return
}
- now := time.Now().Unix()
- fmt.Fprintf(w, `[{"name":"cpu","legend":["usage"],"start":%d,"end":%d,"step":10,"data":[[12]]},{"name":"memory","legend":["free"],"start":%d,"end":%d,"step":10,"data":[[2178945024]]},{"name":"arcsize","legend":["arc_size"],"start":%d,"end":%d,"step":10,"data":[[%d]]}]`, now, now, now, now, now, now, scenario.restARC)
+ var request struct {
+ ReportingQuery struct {
+ End int64 `json:"end"`
+ } `json:"reporting_query"`
+ }
+ if err := json.NewDecoder(r.Body).Decode(&request); err != nil {
+ t.Errorf("decode fixture reporting query: %v", err)
+ w.WriteHeader(http.StatusBadRequest)
+ return
+ }
+ end := request.ReportingQuery.End
+ if end <= 0 {
+ t.Error("fixture reporting query has no positive end")
+ w.WriteHeader(http.StatusBadRequest)
+ return
+ }
+ // The client fixes its query end before the HTTP round trip. Using
+ // the responder's wall clock can cross a second and invent future
+ // samples that the live freshness filter correctly discards.
+ fmt.Fprintf(w, `[{"name":"cpu","legend":["usage"],"start":%d,"end":%d,"step":10,"data":[[12]]},{"name":"memory","legend":["free"],"start":%d,"end":%d,"step":10,"data":[[2178945024]]},{"name":"arcsize","legend":["arc_size"],"start":%d,"end":%d,"step":10,"data":[[%d]]}]`, end, end, end, end, end, end, scenario.restARC)
default:
if response, ok := routes[r.URL.Path]; ok {
if response.status != 0 {