Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Align aggregate disk regressions with observed presence and units

pulse-triage[bot]ae562ede205c
diff --git a/frontend-modern/src/components/Workloads/__tests__/GuestDrawerHistory.disk-provenance.test.tsx b/frontend-modern/src/components/Workloads/__tests__/GuestDrawerHistory.disk-provenance.test.tsx
index 0deaa7576d..ce0768e102 100644
--- a/frontend-modern/src/components/Workloads/__tests__/GuestDrawerHistory.disk-provenance.test.tsx
+++ b/frontend-modern/src/components/Workloads/__tests__/GuestDrawerHistory.disk-provenance.test.tsx
@@ -195,16 +195,22 @@ describe('GuestDrawerHistory filesystem provenance', () => {
},
);
- it.each([-1, NaN, Infinity, undefined])(
- 'does not display unusable retained disk usage %s',
- (usage) => {
- const value = guest('prev-vm-locked');
- value.disk.usage = usage as number;
- expect(getGuestDrawerCurrentMetrics(value).disk).toBeUndefined();
- expect(getGuestDrawerDeferredMetrics(value).disk.lastKnownValue).toBeUndefined();
- expect(getGuestDrawerDeferredMetrics(value).disk.message).toContain('Guest reads paused');
- },
- );
+ it.each([-1, NaN, Infinity])('does not display unusable retained disk usage %s', (usage) => {
+ const value = guest('prev-vm-locked');
+ value.disk.usage = usage as number;
+ expect(getGuestDrawerCurrentMetrics(value).disk).toBeUndefined();
+ expect(getGuestDrawerDeferredMetrics(value).disk.lastKnownValue).toBeUndefined();
+ expect(getGuestDrawerDeferredMetrics(value).disk.message).toContain('Guest reads paused');
+ });
+
+ it('admits retained byte-only disk usage without making it current', () => {
+ const value = guest('prev-vm-locked');
+ value.disk.usage = undefined;
+ expect(getGuestDrawerCurrentMetrics(value).disk).toBeUndefined();
+ expect(getGuestDrawerDeferredMetrics(value).disk.lastKnownValue).toBe(50);
+ value.disk.used = undefined;
+ expect(getGuestDrawerDeferredMetrics(value).disk.lastKnownValue).toBeUndefined();
+ });
it('keeps retained zero valid and honours explicit disk telemetry unavailability', () => {
const value = guest('prev-agent-busy', 0);
diff --git a/frontend-modern/src/components/Workloads/__tests__/GuestRow.test.tsx b/frontend-modern/src/components/Workloads/__tests__/GuestRow.test.tsx
index bcd8c4e085..0febd58396 100644
--- a/frontend-modern/src/components/Workloads/__tests__/GuestRow.test.tsx
+++ b/frontend-modern/src/components/Workloads/__tests__/GuestRow.test.tsx
@@ -797,7 +797,7 @@ describe('GuestRow', () => {
it('shows dash when disk data is unavailable', () => {
renderGuestRow({
- guest: makeGuest({ disk: { total: 0, used: 0, free: 0, usage: 0 } }),
+ guest: makeGuest({ disk: { total: 0, used: 0, free: 0 } }),
});
expect(screen.queryByTestId('disk-bar')).toBeNull();
// Fallback is a hyphen "-"
diff --git a/frontend-modern/src/components/Workloads/__tests__/stackedDiskBarModel.branchcov0712b.test.ts b/frontend-modern/src/components/Workloads/__tests__/stackedDiskBarModel.branchcov0712b.test.ts
index f9515e2da8..c9492ebc38 100644
--- a/frontend-modern/src/components/Workloads/__tests__/stackedDiskBarModel.branchcov0712b.test.ts
+++ b/frontend-modern/src/components/Workloads/__tests__/stackedDiskBarModel.branchcov0712b.test.ts
@@ -460,18 +460,12 @@ describe('stackedDiskBarModel (branch coverage 2)', () => {
]);
});
- it('falls back to getDiskUsagePercent(aggregateDisk) for overall percent when aggregate total is 0', () => {
- // totalCapacity 0 -> overallPercent = aggregateDisk ? getDiskUsagePercent(...) : 0.
- // getDiskUsagePercent: total <= 0, usage 75 (>1) -> 75. Tooltip total>0 arm
- // skipped (total 0) -> empty.
- const p = buildStackedDiskBarPresentation(
- { aggregateDisk: makeDisk({ total: 0, used: 0, free: 0, usage: 75 }) },
- 400,
- );
+ it('shows an independently observed aggregate percentage without inventing byte totals', () => {
+ const p = buildStackedDiskBarPresentation({ aggregateDisk: { usage: 75 } }, 400);
expect(p.displayPercentValue).toBe(75);
expect(p.barPercent).toBe(75);
- expect(p.displaySublabel).toBe('0 B/0 B');
- expect(p.tooltipContent).toEqual([]);
+ expect(p.displaySublabel).toBe('');
+ expect(p.tooltipContent[0]).toMatchObject({ percent: '75%', used: '?', total: '—' });
});
it('maps anomaly severity to a class and formats each anomaly-ratio tier', () => {
diff --git a/frontend-modern/src/hooks/__tests__/useWorkloads.test.ts b/frontend-modern/src/hooks/__tests__/useWorkloads.test.ts
index 0afdd3eff4..26aa3fa2fd 100644
--- a/frontend-modern/src/hooks/__tests__/useWorkloads.test.ts
+++ b/frontend-modern/src/hooks/__tests__/useWorkloads.test.ts
@@ -131,6 +131,7 @@ describe('useWorkloads', () => {
{
...raw,
lastSeen: Date.parse(raw.lastSeen),
+ memory: { current: 50, used: 2048, total: 4096 },
disk: { ...bytes, current: percent ?? value } as Resource['disk'],
} as unknown as Resource,
]);