Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Find native restore-point identifiers in both backup views

pulse-triage[bot]af0bedfe089b
diff --git a/docs/release-control/v6/internal/subsystems/frontend-primitives.md b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
index 8b9bb85592..5b782f4783 100644
--- a/docs/release-control/v6/internal/subsystems/frontend-primitives.md
+++ b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
@@ -20,6 +20,13 @@
## Purpose
+The existing backup text search matches admitted native restore-point identifiers
+in both By date and Coverage, and full archive metadata in Coverage. This is a
+consumer haystack correction: the shared FilterBar/SearchInput, literal search
+grammar, keyboard and touch controls, and exact scope-filter keys are unchanged.
+Normal `ProxmoxBackupsTable.test.tsx` and actual-App desktop/narrow proof cover
+input and cross-view retention without additional provider reads.
+
### Summary buttons activate once per Space press
Native summary disclosure and scope buttons retain their existing keydown-owned
diff --git a/docs/release-control/v6/internal/subsystems/storage-recovery.md b/docs/release-control/v6/internal/subsystems/storage-recovery.md
index bc98bde4dc..738453a242 100644
--- a/docs/release-control/v6/internal/subsystems/storage-recovery.md
+++ b/docs/release-control/v6/internal/subsystems/storage-recovery.md
@@ -21,6 +21,25 @@
## Purpose
+### Existing backup search finds the native record in either view
+
+By date text search includes each admitted restore point's native Identifier.
+Coverage search includes those same identifiers and full archive file metadata,
+not just a shortened format label. Matching remains a case-insensitive literal
+substring after trimming the query; punctuation in provider IDs and file paths
+is not a filter expression or a new identity. Switching views retains the query
+and finds the scoped owner without filtering its evidence preview or inventing
+completion, protection or attribution. Existing node/location/type facets and
+failed-read withdrawal still apply; search performs no provider reads.
+
+`proxmoxBackupRecoveryModel.test.ts` covers all three source kinds, complete file
+metadata, negative matches and undated incomplete evidence. The normal
+`ProxmoxBackupsTable.test.tsx` consumes raw inventory and exercises input, selected
+point, cross-view query retention, namesake isolation and clearing without extra
+reads. Actual-App desktop/narrow proof checks lookup, native disclosure, scoped
+filtering and ordinary read-failure/recovery with inspected pixels. No shared
+search grammar, routes, API, source IDs, matching, policy or collection changes.
+
### A dated backup disclosure identifies the restore point, not only its owner
The By date table keeps its existing native disclosure visible at phone widths,
diff --git a/docs/release-control/v6/internal/subsystems/unified-resources.md b/docs/release-control/v6/internal/subsystems/unified-resources.md
index 10ee3e81ea..a7488391fb 100644
--- a/docs/release-control/v6/internal/subsystems/unified-resources.md
+++ b/docs/release-control/v6/internal/subsystems/unified-resources.md
@@ -23,6 +23,25 @@ and sort the complete canonical change table while startup and ingestion wait.
## Purpose
+### Existing backup search finds the native record in either view
+
+By date text search includes each admitted restore point's native Identifier.
+Coverage search includes those same identifiers and full archive file metadata,
+not just a shortened format label. Matching remains a case-insensitive literal
+substring after trimming the query; punctuation in provider IDs and file paths
+is not a filter expression or a new identity. Switching views retains the query
+and finds the scoped owner without filtering its evidence preview or inventing
+completion, protection or attribution. Existing node/location/type facets and
+failed-read withdrawal still apply; search performs no provider reads.
+
+`proxmoxBackupRecoveryModel.test.ts` covers all three source kinds, complete file
+metadata, negative matches and undated incomplete evidence. The normal
+`ProxmoxBackupsTable.test.tsx` consumes raw inventory and exercises input, selected
+point, cross-view query retention, namesake isolation and clearing without extra
+reads. Actual-App desktop/narrow proof checks lookup, native disclosure, scoped
+filtering and ordinary read-failure/recovery with inspected pixels. No shared
+search grammar, routes, API, source IDs, matching, policy or collection changes.
+
### A dated backup disclosure identifies the restore point, not only its owner
The By date table keeps its existing native disclosure visible at phone widths,
diff --git a/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx b/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx
index 4ec87c042a..9a14086e99 100644
--- a/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx
+++ b/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx
@@ -1757,6 +1757,61 @@ describe('backup-identity: connected Coverage and By date', () => {
};
afterEach(() => vi.restoreAllMocks());
+ it.each([
+ ['pbs-100', 'pbs:pbs-100'],
+ ['FILE-100', 'archive:file-100'],
+ ['snapshot-100', 'snapshot:snapshot-100'],
+ ['local:backup/vzdump-qemu-100.vma.zst', 'archive:file-100'],
+ ])('retains the searched point and scoped owner across views: %s', async (query, pointID) => {
+ mockIdentityAPIs();
+ window.history.replaceState({}, '', '/proxmox/backups/date');
+ renderInRouter(() => (
+ <ProxmoxBackupsTable
+ emptyIcon={<span />}
+ workloads={[
+ identityGuest('west-100', 'west', 'pve-10'),
+ identityGuest('east-100', 'east', 'pve-1'),
+ ]}
+ />
+ ));
+ await waitFor(() => expect(recoverableRows()).toHaveLength(3));
+ const search = screen.getByPlaceholderText(/search backups by workload/i);
+ fireEvent.input(search, { target: { value: query } });
+ await waitFor(() => expect(recoverableRows()).toHaveLength(1));
+ expect(recoverableRows()[0]).toHaveTextContent('east-100');
+ fireEvent.click(
+ within(recoverableRows()[0] as HTMLElement).getByRole('button', {
+ name: /expand details/i,
+ }),
+ );
+ const detail = await screen.findByTestId('proxmox-recoverable-detail');
+ expect(detail).toHaveAttribute('data-inline-detail-for', pointID);
+
+ fireEvent.click(screen.getByRole('link', { name: 'Coverage' }));
+ await waitFor(() => expect(window.location.pathname).toBe('/proxmox/backups/coverage'));
+ expect(new URLSearchParams(window.location.search).get('q')).toBe(query);
+ const rows = () => document.querySelectorAll('[data-proxmox-backup-row="coverage"]');
+ await waitFor(() => expect(rows()).toHaveLength(1));
+ expect(rows()[0]).toHaveTextContent('east-100');
+ expect(rows()[0]).not.toHaveTextContent('west-100');
+ // Lookup narrows the workload list, not its assessment or restore history.
+ fireEvent.click(
+ within(rows()[0] as HTMLElement).getByRole('button', { name: /expand details/i }),
+ );
+ const coverage = await screen.findByTestId('proxmox-coverage-detail');
+ expect(coverage).toHaveTextContent('PBS');
+ expect(coverage).toHaveTextContent('PVE file');
+ expect(coverage).toHaveTextContent('Snapshot');
+ expect(screen.getByRole('button', { name: '2 unknown' })).toBeInTheDocument();
+ expect(apiFetchMock).toHaveBeenCalledTimes(2);
+
+ fireEvent.input(search, { target: { value: 'absent-native-point' } });
+ await waitFor(() => expect(rows()).toHaveLength(0));
+ fireEvent.input(search, { target: { value: '' } });
+ await waitFor(() => expect(rows()).toHaveLength(2));
+ expect(apiFetchMock).toHaveBeenCalledTimes(2);
+ });
+
it('keeps all three artifacts and the successful task with the scoped owner through reorder and display rename', async () => {
mockIdentityAPIs();
window.history.replaceState({}, '', '/proxmox/backups/coverage');
diff --git a/frontend-modern/src/features/proxmox/__tests__/proxmoxBackupRecoveryModel.test.ts b/frontend-modern/src/features/proxmox/__tests__/proxmoxBackupRecoveryModel.test.ts
index ef88d29bc3..320ff1ea73 100644
--- a/frontend-modern/src/features/proxmox/__tests__/proxmoxBackupRecoveryModel.test.ts
+++ b/frontend-modern/src/features/proxmox/__tests__/proxmoxBackupRecoveryModel.test.ts
@@ -99,6 +99,60 @@ const protectionPosture = (resourceId: string, state: ProtectionState): Protecti
});
describe('proxmoxBackupRecoveryModel', () => {
+ it.each([
+ ['pbs-main/main/minipc/ct/112/2026-05-25T01:34:25Z', 'pbs'],
+ ['ARCHIVE-112', 'archive'],
+ [' snap-112 ', 'snapshot'],
+ ['local:backup/vzdump-lxc-112-2026_05_24-02_00_00.tar.zst', 'archive'],
+ ])('finds native identifiers and full file metadata in both views: %s', (query, source) => {
+ const model = buildProxmoxBackupRecoveryModel({
+ workloads: [workload({})],
+ pbsBackups: [pbsBackup()],
+ archives: [archive()],
+ snapshots: [snapshot()],
+ tasks: [],
+ nowMs: Date.parse('2026-05-26T08:00:00Z'),
+ });
+ const matches = model.recoverableArtifacts.filter((point) =>
+ recoverableArtifactMatchesSearch(point, query),
+ );
+ expect(matches).toHaveLength(1);
+ expect(matches[0].sourceKind).toBe(source);
+ expect(coverageRowMatchesSearch(model.coverageRows[0], query)).toBe(true);
+ expect(coverageRowMatchesSearch(model.coverageRows[0], 'absent-native-point')).toBe(false);
+ expect(
+ model.recoverableArtifacts.some((point) =>
+ recoverableArtifactMatchesSearch(point, 'absent-native-point'),
+ ),
+ ).toBe(false);
+ });
+
+ it('finds an incomplete undated point without conferring completion or changing its owner', () => {
+ const model = buildProxmoxBackupRecoveryModel({
+ workloads: [workload({})],
+ pbsBackups: [
+ pbsBackup({
+ id: 'unfinished-native-id',
+ backupTime: 'invalid',
+ inProgress: true,
+ writeActivityObserved: true,
+ writeActive: false,
+ }),
+ ],
+ archives: [],
+ snapshots: [],
+ tasks: [],
+ nowMs: Date.parse('2026-05-26T08:00:00Z'),
+ });
+ const point = model.recoverableArtifacts[0];
+ expect(recoverableArtifactMatchesSearch(point, 'unfinished-native-id')).toBe(true);
+ expect(coverageRowMatchesSearch(model.coverageRows[0], 'unfinished-native-id')).toBe(true);
+ expect(point).toMatchObject({ createdMs: undefined, failed: true, verified: undefined });
+ expect(model.coverageRows[0].workload.resourceId).toBe('vm-112');
+ expect(model.coverageRows[0].latestBackup).toBeUndefined();
+ expect(model.coverageSummary.recoverableArtifacts).toBe(0);
+ });
+
it('retains task origin independently of migrated placement and exposed task search', () => {
const model = buildProxmoxBackupRecoveryModel({
workloads: [workload({})],
diff --git a/frontend-modern/src/features/proxmox/proxmoxBackupRecoveryModel.ts b/frontend-modern/src/features/proxmox/proxmoxBackupRecoveryModel.ts
index 18a3f25269..01582358b4 100644
--- a/frontend-modern/src/features/proxmox/proxmoxBackupRecoveryModel.ts
+++ b/frontend-modern/src/features/proxmox/proxmoxBackupRecoveryModel.ts
@@ -843,11 +843,13 @@ export function coverageRowMatchesSearch(row: WorkloadCoverageRow, term: string)
(task) => [task.label, task.error, task.id, task.instance, task.node],
),
...row.artifacts.flatMap((artifact) => [
+ artifact.nativeId,
artifact.sourceLabel,
artifact.sourceTitle,
artifact.locationConnection || 'unknown connection',
artifact.location,
artifact.detail,
+ artifact.detailTitle,
]),
];
return haystack.filter(Boolean).join(' ').toLowerCase().includes(normalizedTerm);
@@ -868,6 +870,7 @@ export function recoverableArtifactMatchesSearch(
artifact.workload.nativeNode,
...(artifact.workload.nativeNodeAliases ?? []),
artifact.workload.instance,
+ artifact.nativeId,
artifact.sourceLabel,
artifact.sourceTitle,
artifact.locationConnection || 'unknown connection',