Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Do not read a byte metric's default value as a disk percentage

pulse-triage[bot]b1957c99d61f
diff --git a/docs/release-control/v6/internal/subsystems/performance-and-scalability.md b/docs/release-control/v6/internal/subsystems/performance-and-scalability.md
index 80ff5937d1..1726f32f59 100644
--- a/docs/release-control/v6/internal/subsystems/performance-and-scalability.md
+++ b/docs/release-control/v6/internal/subsystems/performance-and-scalability.md
@@ -36,6 +36,11 @@ zero bytes retain their existing wire semantics and are not aggregate metrics.
No collector, guest request, timer, store/history point, threshold or alert
policy is changed.
+Raw byte metrics always serialize a generic `value`, even its default zero.
+That scalar cannot confer a current percentage: an explicit `percent` or a
+valid used/total byte pair is required when `unit` names bytes. Legacy untyped
+value-only percentages and explicit percent-unit values remain usable.
+
Verification: `workloadDiskUsage.test.ts`, `useWorkloads.test.ts` (REST and owning
snapshot refreshes), `workloadSelectors.test.ts`, `GuestRow.test.ts`,
`GuestDrawerHistory.disk-provenance.test.tsx` and stacked-disk tests cover low
diff --git a/docs/release-control/v6/internal/subsystems/unified-resources.md b/docs/release-control/v6/internal/subsystems/unified-resources.md
index 5d2b3574b7..2752f63a77 100644
--- a/docs/release-control/v6/internal/subsystems/unified-resources.md
+++ b/docs/release-control/v6/internal/subsystems/unified-resources.md
@@ -33,6 +33,11 @@ metrics remain available. This aggregate metric contract is distinct from
DiskInfo filesystem records whose zero byte fields may be omitted. Identity,
producer selection, collection, retention and History transport are unchanged.
+Raw byte metrics always serialize a generic `value`, even its default zero.
+That scalar cannot confer a current percentage: an explicit `percent` or a
+valid used/total byte pair is required when `unit` names bytes. Legacy untyped
+value-only percentages and explicit percent-unit values remain usable.
+
Verification: `useWorkloads.test.ts` exercises mounted REST and owning-snapshot
refreshes and `workloadDiskUsage.test.ts` covers numeric admission. The
`workload-disk-metrics` browser fixture consumes the REST mapper into production
diff --git a/frontend-modern/browser-tests/workload-disk-metrics.cjs b/frontend-modern/browser-tests/workload-disk-metrics.cjs
index 4c1ab22fa7..0694a7595b 100644
--- a/frontend-modern/browser-tests/workload-disk-metrics.cjs
+++ b/frontend-modern/browser-tests/workload-disk-metrics.cjs
@@ -44,12 +44,16 @@ const resource = (name, metric, extras = {}) => ({
metrics: {
cpu: { percent: 10 },
memory: { percent: 25, used: GB, total: 4 * GB },
- disk: Object.fromEntries(
- Object.entries(metric).map(([key, value]) => [
- key,
- key === 'used' || key === 'total' ? value * GB : value,
- ]),
- ),
+ disk: {
+ value: 0,
+ unit: 'bytes',
+ ...Object.fromEntries(
+ Object.entries(metric).map(([key, value]) => [
+ key,
+ key === 'used' || key === 'total' ? value * GB : value,
+ ]),
+ ),
+ },
},
proxmox: {
vmid: 101,
diff --git a/frontend-modern/src/hooks/__tests__/useWorkloads.test.ts b/frontend-modern/src/hooks/__tests__/useWorkloads.test.ts
index 2ab9d70d1b..0afdd3eff4 100644
--- a/frontend-modern/src/hooks/__tests__/useWorkloads.test.ts
+++ b/frontend-modern/src/hooks/__tests__/useWorkloads.test.ts
@@ -107,10 +107,15 @@ describe('useWorkloads', () => {
[{ percent: 0.5 }, 0.5],
[{ percent: 1 }, 1],
[{ value: 0.5 }, 0.5],
+ [{ value: 0, total: 100, unit: 'bytes' }, null],
+ [{ value: 0, used: 0, total: 100, unit: 'bytes' }, 0],
+ [{ value: 0, used: 50, total: 200, unit: 'bytes' }, 25],
+ [{ value: 0.5, unit: 'percent' }, 0.5],
[{ used: 50, total: 200 }, 25],
[{ percent: -1, used: 0, total: 100 }, null],
[{ percent: Infinity, used: 0, total: 100 }, null],
] as const) {
+ if (transport === 'snapshot' && 'unit' in metric) continue;
const raw = { ...sampleResource, metrics: { ...sampleResource.metrics, disk: metric } };
if (transport === 'api') {
apiFetchJSONMock.mockResolvedValue({ data: [raw] });
diff --git a/frontend-modern/src/hooks/useWorkloads.ts b/frontend-modern/src/hooks/useWorkloads.ts
index 00ce7ad6d0..d2afcaff1e 100644
--- a/frontend-modern/src/hooks/useWorkloads.ts
+++ b/frontend-modern/src/hooks/useWorkloads.ts
@@ -336,7 +336,10 @@ const buildDiskMetric = (metric?: APIMetricValue): WorkloadGuest['disk'] => {
const disk = {
total: metric?.total,
used: metric?.used,
- usage: metric?.percent ?? metric?.value,
+ // Byte metrics always serialize a generic value, including default zero.
+ // Only an explicit percentage or measured byte pair establishes usage.
+ usage:
+ metric?.percent ?? (!metric?.unit || metric.unit === 'percent' ? metric?.value : undefined),
};
return {
...disk,