Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Keep exact reported dates inspectable in By date records

pulse-triage[bot]b59544fbad34
diff --git a/docs/release-control/v6/internal/subsystems/frontend-primitives.md b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
index 4a5d4b3367..9bd4ad6e59 100644
--- a/docs/release-control/v6/internal/subsystems/frontend-primitives.md
+++ b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
@@ -10988,3 +10988,27 @@ missing jobs do not establish that none are configured. Neither raw provider
body nor JSON parser details enter the rendered error. This is a failed read,
not an empty-state or a new error surface; full retry, normal status filters,
phone columns and disclosure interactions retain their existing owners.
+
+
+### By date retains literal restore-point date evidence
+
+The existing Proxmox By date record exposes the provider's exact reported date
+beside its formatted Created interpretation. Offsets and subsecond precision
+remain literal wrapping text for PBS snapshots, PVE backup files and guest
+snapshots, including malformed and future values; missing values say Not
+reported. Unknown Created values remain unknown. The existing By date notice
+continues to explain unavailable/future dates and their exclusion from activity
+and day filters; no duplicate per-point warning is added. Raw dates are not an
+inferred completion time, freshness, protection or restore assertion.
+
+The same open point updates its raw date and interpretation on ordinary
+inventory polling without borrowing another point's date or losing owned focus.
+Normal-suite `recoverableIdentityAccess.test.tsx` covers all three sources,
+precise/malformed/future/missing/literal-markup dates, desktop/narrow widths and
+in-place replacement/withdrawal. Registered `ProxmoxBackupsTable.test.tsx`
+protects unknown-date evidence through the parsed inventory consumer and
+`ProxmoxRecoverableTable.test.tsx` protects direct presentation. Browser proof
+must exercise the actual By date consumer at desktop and narrow widths and
+inspect wrapping, uncertainty, keyboard/touch disclosure and live replacement.
+No parser, association, ordering, count, filter, posture, API, permission or
+provider-operation contract changes. This is inspection, not guest recovery.
diff --git a/docs/release-control/v6/internal/subsystems/storage-recovery.md b/docs/release-control/v6/internal/subsystems/storage-recovery.md
index 4183926373..cf1db1a1c1 100644
--- a/docs/release-control/v6/internal/subsystems/storage-recovery.md
+++ b/docs/release-control/v6/internal/subsystems/storage-recovery.md
@@ -8902,3 +8902,27 @@ per-workload reset. Desktop and narrow browser proof must exercise the actual
inventory consumer, the bounded disclosure, keyboard/touch expansion and live
shrink/ordering with actual pixel inspection. This is an inspection/rendering
bound, not a measured installed CPU improvement or original guest recovery.
+
+
+### By date retains literal restore-point date evidence
+
+The existing Proxmox By date record exposes the provider's exact reported date
+beside its formatted Created interpretation. Offsets and subsecond precision
+remain literal wrapping text for PBS snapshots, PVE backup files and guest
+snapshots, including malformed and future values; missing values say Not
+reported. Unknown Created values remain unknown. The existing By date notice
+continues to explain unavailable/future dates and their exclusion from activity
+and day filters; no duplicate per-point warning is added. Raw dates are not an
+inferred completion time, freshness, protection or restore assertion.
+
+The same open point updates its raw date and interpretation on ordinary
+inventory polling without borrowing another point's date or losing owned focus.
+Normal-suite `recoverableIdentityAccess.test.tsx` covers all three sources,
+precise/malformed/future/missing/literal-markup dates, desktop/narrow widths and
+in-place replacement/withdrawal. Registered `ProxmoxBackupsTable.test.tsx`
+protects unknown-date evidence through the parsed inventory consumer and
+`ProxmoxRecoverableTable.test.tsx` protects direct presentation. Browser proof
+must exercise the actual By date consumer at desktop and narrow widths and
+inspect wrapping, uncertainty, keyboard/touch disclosure and live replacement.
+No parser, association, ordering, count, filter, posture, API, permission or
+provider-operation contract changes. This is inspection, not guest recovery.
diff --git a/docs/release-control/v6/internal/subsystems/unified-resources.md b/docs/release-control/v6/internal/subsystems/unified-resources.md
index 7d2765be1e..7aef2ca6cc 100644
--- a/docs/release-control/v6/internal/subsystems/unified-resources.md
+++ b/docs/release-control/v6/internal/subsystems/unified-resources.md
@@ -9409,3 +9409,27 @@ accepted. Alert lifecycle rows are announced only through `RecordLiveChange`;
as new. The API agent event stream is the only observer today. Proof:
`TestMonitorAdapterChangeObserverHearsOnlyRecordedLiveChanges` in
`internal/unifiedresources/history_identity_test.go`.
+
+
+### By date retains literal restore-point date evidence
+
+The existing Proxmox By date record exposes the provider's exact reported date
+beside its formatted Created interpretation. Offsets and subsecond precision
+remain literal wrapping text for PBS snapshots, PVE backup files and guest
+snapshots, including malformed and future values; missing values say Not
+reported. Unknown Created values remain unknown. The existing By date notice
+continues to explain unavailable/future dates and their exclusion from activity
+and day filters; no duplicate per-point warning is added. Raw dates are not an
+inferred completion time, freshness, protection or restore assertion.
+
+The same open point updates its raw date and interpretation on ordinary
+inventory polling without borrowing another point's date or losing owned focus.
+Normal-suite `recoverableIdentityAccess.test.tsx` covers all three sources,
+precise/malformed/future/missing/literal-markup dates, desktop/narrow widths and
+in-place replacement/withdrawal. Registered `ProxmoxBackupsTable.test.tsx`
+protects unknown-date evidence through the parsed inventory consumer and
+`ProxmoxRecoverableTable.test.tsx` protects direct presentation. Browser proof
+must exercise the actual By date consumer at desktop and narrow widths and
+inspect wrapping, uncertainty, keyboard/touch disclosure and live replacement.
+No parser, association, ordering, count, filter, posture, API, permission or
+provider-operation contract changes. This is inspection, not guest recovery.
diff --git a/frontend-modern/src/features/proxmox/ProxmoxRecoverableTable.tsx b/frontend-modern/src/features/proxmox/ProxmoxRecoverableTable.tsx
index c0410718a4..6372bbf0b8 100644
--- a/frontend-modern/src/features/proxmox/ProxmoxRecoverableTable.tsx
+++ b/frontend-modern/src/features/proxmox/ProxmoxRecoverableTable.tsx
@@ -92,16 +92,22 @@ function groupByDay(artifacts: readonly RecoverableArtifact[]): DayGroup[] {
}
// The drawer dot repeats the row's State badge: the same states, the same colours.
-const artifactStateIndicator = (artifact: RecoverableArtifact): StatusIndicator => {
- const label = artifactStateLabel(artifact);
- if (artifact.running) return { variant: 'info', label };
- if (artifact.failed) return { variant: 'danger', label };
- if (artifact.sourceKind === 'snapshot') return { variant: 'info', label };
- if (artifact.verified === true) return { variant: 'success', label };
- if (artifact.verified === false) return { variant: 'warning', label };
- if (artifact.protected) return { variant: 'info', label };
- return { variant: 'muted', label };
-};
+const artifactStateIndicator = (artifact: RecoverableArtifact): StatusIndicator => ({
+ variant: artifact.running
+ ? 'info'
+ : artifact.failed
+ ? 'danger'
+ : artifact.sourceKind === 'snapshot'
+ ? 'info'
+ : artifact.verified === true
+ ? 'success'
+ : artifact.verified === false
+ ? 'warning'
+ : artifact.protected
+ ? 'info'
+ : 'muted',
+ label: artifactStateLabel(artifact),
+});
const artifactVerificationText = (artifact: RecoverableArtifact): string => {
if (artifact.verified === true) return 'Verified';
@@ -154,6 +160,7 @@ const artifactEvidenceLimit = (artifact: RecoverableArtifact): string => {
// repository identity must also be readable before choosing a point on a phone.
const buildRecoverableDetailSections = (artifact: RecoverableArtifact): DetailSection[] => {
const source = getProxmoxBackupSourcePresentation(artifact.sourceKind);
+ const hasSize = artifact.size && artifact.size > 0;
return compactDetailSections([
{
label: 'Restore point',
@@ -166,16 +173,17 @@ const buildRecoverableDetailSections = (artifact: RecoverableArtifact): DetailSe
makeDetailRow(PROXMOX_BACKUP_COLUMN_LABELS.created, artifactCreatedLabel(artifact), {
tone: artifact.createdMs === undefined ? 'warning' : undefined,
}),
+ // Keep the provider's exact value beside its interpretation. Formatting
+ // loses subsecond precision/offsets; Unknown otherwise hides bad dates.
+ makeDetailRow('Reported date', artifact.createdAt || 'Not reported', { wrap: true }),
makeDetailRow(
'Size',
- artifact.size && artifact.size > 0
- ? formatPlatformTableBytesValue(artifact.size)
- : 'Unknown size',
- { tone: artifact.size && artifact.size > 0 ? undefined : 'muted' },
+ hasSize ? formatPlatformTableBytesValue(artifact.size) : 'Unknown size',
+ { tone: hasSize ? undefined : 'muted' },
),
]),
footerContent: (
- <Show when={!(artifact.size && artifact.size > 0)}>
+ <Show when={!hasSize}>
<p class="whitespace-normal text-[11px] leading-snug text-muted wrap-anywhere">
No usable size was reported. Unknown does not mean this restore point is empty.
</p>
diff --git a/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx b/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx
index 50a6a4c51a..213a2dec7b 100644
--- a/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx
+++ b/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx
@@ -1733,6 +1733,26 @@ describe('backup-date-evidence connected inventory', () => {
<ProxmoxBackupsTable emptyIcon={<span />} workloads={[workloadResource]} />
));
+ it.each(['not-a-date', '0001-01-01T00:00:00Z', '2026-10-04T12:00:01Z'])(
+ '[regression] By date exposes the reported %s without granting it an age',
+ async (date) => {
+ window.history.replaceState({}, '', '/?view=date');
+ supply(date);
+ mount();
+ const toggle = await screen.findByRole('button', { name: /Expand details.*Identifier:/ });
+ await fireEvent.click(toggle);
+ const panel = screen.getByTestId('proxmox-recoverable-detail');
+ expect(within(panel).getByText('Reported date').closest('tr')).toHaveTextContent(date);
+ expect(within(panel).getByText('Created').closest('tr')).toHaveTextContent('Unknown');
+ const notice = screen.getByText(
+ /Backup entries with unavailable or future dates remain listed/,
+ );
+ expect(notice).toHaveTextContent('Their ages are unknown.');
+ expect(notice).toHaveTextContent('excluded from the activity chart and day filters');
+ expect(apiFetchMock).toHaveBeenCalledTimes(2);
+ },
+ );
+
it.each(['not-a-date', '0001-01-01T00:00:00Z', '2026-10-04T12:00:01Z'])(
'[regression] Coverage preserves %s uncertainty instead of absence or healthy age',
async (date) => {
diff --git a/frontend-modern/src/features/proxmox/__tests__/ProxmoxRecoverableTable.test.tsx b/frontend-modern/src/features/proxmox/__tests__/ProxmoxRecoverableTable.test.tsx
index c116cda7b2..57d851277c 100644
--- a/frontend-modern/src/features/proxmox/__tests__/ProxmoxRecoverableTable.test.tsx
+++ b/frontend-modern/src/features/proxmox/__tests__/ProxmoxRecoverableTable.test.tsx
@@ -107,6 +107,9 @@ describe('ProxmoxRecoverableTable record drawer', () => {
artifact.nativeId,
);
expect(within(panel).getByText('Created').closest('tr')).toHaveTextContent('2026');
+ expect(within(panel).getByText('Reported date').closest('tr')).toHaveTextContent(
+ artifact.createdAt,
+ );
expect(within(panel).getByRole('link', { name: 'Open web' })).toHaveAttribute(
'href',
'/proxmox/overview?resource=vm-100',
diff --git a/frontend-modern/src/features/proxmox/__tests__/recoverableIdentityAccess.test.tsx b/frontend-modern/src/features/proxmox/__tests__/recoverableIdentityAccess.test.tsx
index 1222854cdc..10543b4b01 100644
--- a/frontend-modern/src/features/proxmox/__tests__/recoverableIdentityAccess.test.tsx
+++ b/frontend-modern/src/features/proxmox/__tests__/recoverableIdentityAccess.test.tsx
@@ -81,6 +81,102 @@ afterEach(() => {
});
describe('restore-point identity without hover', () => {
+ it.each([320, 720, 1200])(
+ 'keeps each source’s exact reported date and uncertainty inspectable at %ipx',
+ async (width) => {
+ api.width = width;
+ const exact = '2026-10-04T12:15:34.123456789+02:00';
+ const literal = '<img src=x onerror=alert(1)>';
+ const dates = [exact, '2026-09-31T10:00:00Z', '2099-10-04T10:00:00Z', '', literal];
+ mount({
+ guests: workloads().slice(0, 1),
+ pve: () => ({
+ ...emptyPVE,
+ storageBackups: dates.map((time, index) =>
+ identityArchive({ id: `file-${index}`, instance: scopes[0], time }),
+ ),
+ guestSnapshots: dates.map((time, index) =>
+ identitySnapshot({ id: `snapshot-${index}`, instance: scopes[0], time }),
+ ),
+ }),
+ pbs: () =>
+ dates.map((backupTime, index) => identityPBS({ id: `pbs-${index}`, backupTime })),
+ });
+ const points = await rows();
+ expect(points).toHaveLength(15);
+ for (const kind of ['pbs', 'file', 'snapshot']) {
+ for (const [index, date] of dates.entries()) {
+ const button = screen.getByRole('button', {
+ name: new RegExp(`Identifier: ${kind}-${index}$`),
+ });
+ await fireEvent.click(button);
+ const panel = screen.getByTestId('proxmox-recoverable-detail');
+ const reported = within(panel).getByText('Reported date').closest('tr')!;
+ expect(reported).toHaveTextContent(date || 'Not reported');
+ expect(reported.querySelector('td:last-child span')).not.toHaveClass('truncate');
+ const created = within(panel).getByText('Created').closest('tr')!;
+ if (index === 0) {
+ expect(created).toHaveTextContent('2026');
+ } else {
+ expect(created).toHaveTextContent('Unknown');
+ const notice = screen.getByText(
+ /Backup entries with unavailable or future dates remain listed/,
+ );
+ expect(notice).toHaveTextContent('Their ages are unknown.');
+ expect(notice).toHaveTextContent('excluded from the activity chart and day filters');
+ }
+ expect(panel.querySelector('img')).toBeNull();
+ }
+ }
+ expect(screen.getAllByTestId('proxmox-recoverable-detail')).toHaveLength(1);
+ expect(api.fetch).toHaveBeenCalledTimes(2);
+ },
+ );
+
+ it.each([320, 1200])(
+ 'updates the open reported date and its interpretation without replacing the record at %ipx',
+ async (width) => {
+ api.width = width;
+ vi.useFakeTimers({
+ now: BACKUP_IDENTITY_NOW,
+ toFake: ['Date', 'setInterval', 'clearInterval'],
+ });
+ let date = '2026-09-31T10:00:00Z';
+ mount({
+ guests: workloads().slice(0, 1),
+ pve: () => emptyPVE,
+ pbs: () => [identityPBS({ backupTime: date })],
+ });
+ const [point] = await rows();
+ const toggle = within(point).getByRole('button', { name: /Expand details/ });
+ await fireEvent.click(toggle);
+ toggle.focus();
+ const panel = screen.getByTestId('proxmox-recoverable-detail');
+ expect(
+ screen.getByText(/Backup entries with unavailable or future dates remain listed/),
+ ).toBeVisible();
+ for (const next of ['2026-10-04T12:15:34.123456789+02:00', '']) {
+ date = next;
+ await vi.advanceTimersByTimeAsync(30_000);
+ await waitFor(() =>
+ expect(within(panel).getByText('Reported date').closest('tr')).toHaveTextContent(
+ next || 'Not reported',
+ ),
+ );
+ expect(screen.getByTestId('proxmox-recoverable-detail')).toBe(panel);
+ expect(toggle).toHaveFocus();
+ const notice = screen.queryByText(
+ /Backup entries with unavailable or future dates remain listed/,
+ );
+ if (next) expect(notice).toBeNull();
+ else expect(notice).toBeVisible();
+ }
+ expect(api.fetch).toHaveBeenCalledTimes(6);
+ expect(panel).not.toHaveTextContent('2026-09-31');
+ expect(panel).not.toHaveTextContent('.123456789');
+ },
+ );
+
it.each([320, 479, 480, 719, 720, 1200])(
'keeps namesake workload and reader scope distinct at %ipx',
async (width) => {