Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Keep the phone backup indicator from taking over guest rows

rcourtmanb6fb2061f669
diff --git a/docs/release-control/v6/internal/subsystems/performance-and-scalability.md b/docs/release-control/v6/internal/subsystems/performance-and-scalability.md
index 50fa9900fc..f6166a195b 100644
--- a/docs/release-control/v6/internal/subsystems/performance-and-scalability.md
+++ b/docs/release-control/v6/internal/subsystems/performance-and-scalability.md
@@ -84,8 +84,8 @@ guest recovery, ordinary QEMU-only polling or release availability.
### Narrow Workloads identity during guest locks
In narrow and phone layouts, the guest name and status occupy the first line;
-the unchanged backup evidence control moves below the name, retaining its
-44 px touch target. The guest lock occupies a separate, wrapping line below
+the unchanged backup evidence control moves below the name with a 24 px touch
+target (see Accessible Workloads backup evidence). The guest lock occupies a separate, wrapping line below
that identity. It must not consume the name's
horizontal space or spill into the adjacent metrics. The full lock remains
visible; a long name keeps its full title and existing truncation. Wider layouts
@@ -4033,8 +4033,12 @@ open the same named-guest completion evidence that fine-pointer hover shows.
Exact time and age use readable theme text rather than colour alone. The shared
Dialog owns focus, Escape/backdrop dismissal and background isolation, and
returns focus to the originating disclosure. Nested evidence activation must
-not trigger the enclosing guest row. Touch targets are at least 44px; compact
-desktop shields and the existing status colours remain.
+not trigger the enclosing guest row. The Backup column badge keeps a touch
+target of at least 44px. The name indicator keeps 24px (the WCAG 2.2 AA
+minimum): on phones the whole guest row is the disclosure target and the expand
+chevron is screen-reader only, so a 44px box covered the lower left of every
+row's tap area and grew phone rows from about 34px to 64px. Compact desktop
+shields and the existing status colours remain.
The Backup column badge does not truncate. Running (73px with its shield) and
Unknown (79px) need about 95px with cell padding, so the compact layout weights
diff --git a/frontend-modern/browser-verification/bbf267541177a415.json b/frontend-modern/browser-verification/bbf267541177a415.json
new file mode 100644
index 0000000000..7a38c6f61a
--- /dev/null
+++ b/frontend-modern/browser-verification/bbf267541177a415.json
@@ -0,0 +1,42 @@
+{
+ "version": 1,
+ "base_sha": "b1239bd6108d85facc2ec91345c532923d41a6e0",
+ "verified_at": "2026-10-11T21:27:00Z",
+ "result": "passed",
+ "changed_paths": [
+ "frontend-modern/src/components/Workloads/GuestRowCells.tsx"
+ ],
+ "content_sha256": {
+ "frontend-modern/src/components/Workloads/GuestRowCells.tsx": "decaec733aec0080cb186d6168eb7112c9234e32fcb46e581d41c5c4d1b3e1fb"
+ },
+ "routes": [
+ "/proxmox"
+ ],
+ "viewports": [
+ {
+ "width": 1280,
+ "height": 900
+ },
+ {
+ "width": 768,
+ "height": 1024
+ },
+ {
+ "width": 375,
+ "height": 812
+ }
+ ],
+ "states": [
+ "private mock stack (PULSE_MOCK_MODE, 4 nodes, 34 guests) built from origin/main with Vite HMR on the edited file",
+ "375px phone, guest workloads table with the Backup column hidden: name-cell backup indicator is 24x24 (was 44x44), every guest row is 43.5px tall (was 63.5px)",
+ "375px phone: the expand chevron stays screen-reader only (position absolute, clip-path inset(50%)); with keyboard focus it becomes visible and does not overlap the indicator",
+ "768px: chevron 24px and indicator 14px in the name cell, no overlap, elementFromPoint at every chevron centre returns that chevron",
+ "1280px desktop: Backup column badge in its own cell (52x20), chevron 24px, row 32px, unchanged"
+ ],
+ "interactions": [
+ "375px: real tap at (60,418) inside the old 44px indicator zone opens the auth-service-01 guest drawer (aria-expanded true) and no backup dialog",
+ "375px: real tap on the shield at (37,415) opens \"Backup status details for auth-service-01\" and leaves the row collapsed",
+ "375px: Close button dismisses the backup dialog",
+ "hit-zone grid scan of the name cell before/after: backup zone shrank from 44x44 to 24x24"
+ ]
+}
diff --git a/frontend-modern/src/components/Workloads/GuestRowCells.tsx b/frontend-modern/src/components/Workloads/GuestRowCells.tsx
index 1c87bcd783..f69be05198 100644
--- a/frontend-modern/src/components/Workloads/GuestRowCells.tsx
+++ b/frontend-modern/src/components/Workloads/GuestRowCells.tsx
@@ -403,6 +403,11 @@ function BackupStatusCell(props: {
const focusClass =
'focus-visible:outline-hidden focus-visible:ring-2 focus-visible:ring-blue-500 focus-visible:ring-offset-1 focus-visible:ring-offset-surface';
+ // The indicator sits in the guest name cell, where on phones the whole row
+ // is the disclosure target (the expand chevron is screen-reader only). Keep
+ // its touch target at the 24px minimum: a 44px box covered most of the
+ // name cell's row-tap area and doubled every phone row's height. The
+ // backup-column badge owns its own cell, so it keeps the 44px target.
return (
<>
<button
@@ -410,7 +415,7 @@ function BackupStatusCell(props: {
type="button"
class={
props.indicator
- ? `inline-flex min-h-11 min-w-11 shrink-0 items-center justify-center rounded-sm sm:min-h-0 sm:min-w-0 ${config().color} ${focusClass}`
+ ? `inline-flex min-h-6 min-w-6 shrink-0 items-center justify-center rounded-sm sm:min-h-0 sm:min-w-0 ${config().color} ${focusClass}`
: `${getBackupAgeBadgeClass(displayStatus())} min-h-11 min-w-11 sm:min-h-0 ${focusClass}`
}
onMouseEnter={tip.onMouseEnter}
diff --git a/frontend-modern/src/components/Workloads/__tests__/GuestRow.test.tsx b/frontend-modern/src/components/Workloads/__tests__/GuestRow.test.tsx
index c8e181076b..680df9a2c9 100644
--- a/frontend-modern/src/components/Workloads/__tests__/GuestRow.test.tsx
+++ b/frontend-modern/src/components/Workloads/__tests__/GuestRow.test.tsx
@@ -2158,6 +2158,56 @@ describe('GuestRow', () => {
expect(disclosureButton.className).not.toContain('sr-only');
});
+
+ // jsdom has no layout, so this pins the classes that decide phone
+ // geometry. On a 375px mock stack a 44px name-cell backup indicator
+ // covered the lower left of every row (the row is the phone disclosure
+ // target) and grew rows from 33.5px to 63.5px; at 24px rows are 43.5px
+ // and a tap beside the shield opens the guest drawer.
+ it('regression: keeps the phone name-cell backup indicator to a 24px target', () => {
+ const onClick = vi.fn();
+ const guest = makeGuest({
+ type: 'qemu',
+ workloadType: 'vm',
+ lastBackup: Date.now() - 3_600_000,
+ });
+ renderGuestRow({
+ guest,
+ isGroupedView: true,
+ workloadTableLayoutMode: 'phone',
+ visibleColumnIds: ['name', 'cpu'],
+ onClick,
+ });
+ const disclosure = screen.getByRole('button', { name: `Expand ${guest.name}` });
+ const indicator = screen.getByRole('button', { name: /^Last backup:/ });
+ const indicatorClasses = indicator.className.split(/\s+/);
+
+ expect(disclosure.className.split(/\s+/)).toEqual(expect.arrayContaining(['h-9', 'w-9']));
+ expect(indicatorClasses).toEqual(
+ expect.arrayContaining(['min-h-6', 'min-w-6', 'sm:min-h-0', 'sm:min-w-0']),
+ );
+ expect(indicatorClasses).not.toContain('min-h-11');
+ expect(indicatorClasses).not.toContain('min-w-11');
+
+ fireEvent.click(indicator);
+ expect(
+ screen.getByRole('dialog', { name: `Backup status details for ${guest.name}` }),
+ ).toBeVisible();
+ expect(onClick).not.toHaveBeenCalled();
+ });
+
+ it('keeps the 44px touch target on the Backup column badge', () => {
+ renderGuestRow({
+ guest: makeGuest({ type: 'qemu', workloadType: 'vm', lastBackup: Date.now() }),
+ workloadTableLayoutMode: 'phone',
+ visibleColumnIds: ['name', 'backup'],
+ });
+ const badge = screen.getByRole('button', { name: /^Backup status:/ });
+
+ expect(badge.className.split(/\s+/)).toEqual(
+ expect.arrayContaining(['min-h-11', 'min-w-11']),
+ );
+ });
});
describe('custom URL on the name cell', () => {