Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Use sentences in scoped Proxmox TLS guidance

pulse-triage[bot]b782b8d8674a
diff --git a/frontend-modern/src/components/Settings/NodeModalClusterMembersSection.tsx b/frontend-modern/src/components/Settings/NodeModalClusterMembersSection.tsx
index 7df17f8038..1acd165049 100644
--- a/frontend-modern/src/components/Settings/NodeModalClusterMembersSection.tsx
+++ b/frontend-modern/src/components/Settings/NodeModalClusterMembersSection.tsx
@@ -157,7 +157,7 @@ export const NodeModalClusterMembersSection: Component<NodeModalClusterMembersSe
? 'Primary endpoint only.'
: endpoint.tlsFirstUse &&
!state.formData().clusterEndpointTrustEdited[endpoint.tlsEndpoint!]
- ? 'No saved member pin. Existing first-use policy applies; enter a verified pin or explicitly choose CA validation.'
+ ? 'No saved member pin. Existing first-use policy applies. Enter a verified pin or explicitly choose CA validation.'
: (state.formData().clusterEndpointFingerprints[
endpoint.tlsEndpoint!
] ??
diff --git a/frontend-modern/src/components/Settings/__tests__/NodeModalClusterMembersSection.test.tsx b/frontend-modern/src/components/Settings/__tests__/NodeModalClusterMembersSection.test.tsx
index 5013bd22af..3a462a8755 100644
--- a/frontend-modern/src/components/Settings/__tests__/NodeModalClusterMembersSection.test.tsx
+++ b/frontend-modern/src/components/Settings/__tests__/NodeModalClusterMembersSection.test.tsx
@@ -195,7 +195,11 @@ describe('Cluster member connection diagnostics', () => {
const { onSave } = renderMembers([
member({ tlsEndpoint: 'https://member.test:8006', tlsFirstUse: true, fingerprint: '' }),
]);
- expect(screen.getByText(/No saved member pin/)).toBeVisible();
+ expect(
+ screen.getByText(
+ 'No saved member pin. Existing first-use policy applies. Enter a verified pin or explicitly choose CA validation.',
+ ),
+ ).toBeVisible();
fireEvent.click(screen.getByRole('button', { name: 'Use CA validation for member' }));
expect(
screen.getByText('No pin: a trusted, hostname-matching certificate is required.'),
diff --git a/frontend-modern/src/components/Settings/__tests__/useNodeModalState.connectionTest.test.ts b/frontend-modern/src/components/Settings/__tests__/useNodeModalState.connectionTest.test.ts
index 29cb22c90e..c0563ee227 100644
--- a/frontend-modern/src/components/Settings/__tests__/useNodeModalState.connectionTest.test.ts
+++ b/frontend-modern/src/components/Settings/__tests__/useNodeModalState.connectionTest.test.ts
@@ -133,7 +133,9 @@ describe('connection tests with retained credentials', () => {
verifySSL: true,
});
expect(NodesAPI.testConnection).not.toHaveBeenCalled();
- expect(state.testResult()?.message).toContain('peer:');
+ expect(state.testResult()?.message).toBe(
+ 'peer: Endpoint connection successful. Background collection was not tested.',
+ );
expect(state.testResult()?.endpoint).toBe(peer.tlsEndpoint);
state.updateClusterEndpointFingerprint(peer.tlsEndpoint, 'new-pin');
expect(state.testResult()).toBeNull();
diff --git a/frontend-modern/src/components/Settings/useNodeModalState.ts b/frontend-modern/src/components/Settings/useNodeModalState.ts
index 8e5f5145bd..c3b27b949e 100644
--- a/frontend-modern/src/components/Settings/useNodeModalState.ts
+++ b/frontend-modern/src/components/Settings/useNodeModalState.ts
@@ -604,7 +604,7 @@ export const useNodeModalState = (props: NodeModalProps) => {
setTestResult({
endpoint: endpoint?.tlsEndpoint,
status: result.warnings?.length ? 'warning' : 'success',
- message: `${endpoint ? endpoint.nodeName + ': ' : ''}${result.message || 'Endpoint connection successful; background collection was not tested.'}`,
+ message: `${endpoint ? endpoint.nodeName + ': ' : ''}${result.message || 'Endpoint connection successful. Background collection was not tested.'}`,
warnings: result.warnings,
});
} catch (error) {