Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.
Go aialertsdashboarddockerdocker-monitoringgohomelabinfrastructure-monitoringkubernetesmonitoringmspproxmoxproxmox-backup-serverproxmox-mail-gatewayproxmox-veself-hostedtruenastypescriptvspherewebhooks
Keep feature-request context out of secondary-topic review
pulse-triage[bot]b8e64d1fffe9
diff --git a/.github/scripts/issue-version-triage.cjs b/.github/scripts/issue-version-triage.cjsindex 3a8e6fa8d7..31700858f8 100644--- a/.github/scripts/issue-version-triage.cjs+++ b/.github/scripts/issue-version-triage.cjs@@ -135,6 +135,10 @@ function additionalActionableTopicsValue(body) {"Additional context","Logs, screenshots, or diagnostics","Confirmations",+ "Problem",+ "Current workflow",+ "Desired outcome",+ "Alternatives considered",]);}diff --git a/.github/scripts/issue-version-triage.test.cjs b/.github/scripts/issue-version-triage.test.cjsindex f706b7e679..e8ef68125d 100644--- a/.github/scripts/issue-version-triage.test.cjs+++ b/.github/scripts/issue-version-triage.test.cjs@@ -542,8 +542,9 @@ test("topic classification stops at form fields but retains topic subheadings",function topicBoundaryFields() {const fields = new Set(["Additional context"]);- for (const name of ["bug_report.yml", "v6_rc_feedback.yml"]) {- const form = fs.readFileSync(path.resolve(__dirname, "../ISSUE_TEMPLATE", name), "utf8");+ const directory = path.resolve(__dirname, "../ISSUE_TEMPLATE");+ for (const name of fs.readdirSync(directory).filter(name => /\.ya?ml$/.test(name))) {+ const form = fs.readFileSync(path.join(directory, name), "utf8");for (const [, label] of form.matchAll(/^ label: (.+)$/gm)) {if (label !== "Additional actionable topics") fields.add(label);}@@ -612,6 +613,35 @@ test("opening or editing neighbouring context cannot invent a decomposition task}});+test("feature context edits preserve a cleared review while real topic edits restore it", async () => {+ const { github, calls } = createGithub();+ const body = (context, topic = "None") => [+ "### Additional actionable topics", topic, "",+ "### Desired outcome", context, "",+ "### Alternatives considered", "An existing workaround.",+ ].join("\n");+ const labels = ["enhancement", "needs-human", "needs-retest-on-latest"];+ const issue = { number: 2925, title: "Existing feature request", body: body("Clarified outcome"),+ labels: labels.map(name => ({ name })) };+ await syncLabels({ github, core: createCore(), context: createContext({+ action: "edited", issue, previousBody: body("Original outcome"),+ }) });+ assert.deepEqual(calls.addLabels, []);+ assert.deepEqual(calls.createLabel, []);++ const revised = { ...issue, body: body("Clarified outcome", "Also retain failed attempts in History.") };+ const context = createContext({+ action: "edited", issue: revised, previousBody: issue.body,+ });+ github.currentIssue = { ...context.payload.issue, state: "open" };+ await syncLabels({ github, core: createCore(), context });+ assert.deepEqual(calls.addLabels.map(call => call.labels), [["needs-decomposition"]]);+ assert.deepEqual(calls.removeLabel, []);+ assert.deepEqual(calls.createComment, []);+ assert.deepEqual(calls.getLatestRelease, []);+ assert.deepEqual(calls.paginate, []);+});+test("real revised topics still reopen review without disposing of existing tasks", async () => {for (const existingTask of [false, true]) {const { github, calls } = createGithub();