Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Anchor Assistant mode-menu bounds to its actual toolbar

pulse-triage[bot]b908be2e55f5
diff --git a/frontend-modern/browser-tests/assistant-control-compatibility.cjs b/frontend-modern/browser-tests/assistant-control-compatibility.cjs
index a81a933f8e..776edc9a03 100644
--- a/frontend-modern/browser-tests/assistant-control-compatibility.cjs
+++ b/frontend-modern/browser-tests/assistant-control-compatibility.cjs
@@ -93,7 +93,7 @@ const hash = (f) => crypto.createHash('sha256').update(fs.readFileSync(f)).diges
await page.keyboard.press('Home'); assert.ok(await modes.first().evaluate((el) => el === document.activeElement));
await page.keyboard.press('ArrowUp'); assert.ok(await ask.evaluate((el) => el === document.activeElement));
const bounds = await page.getByRole('menu').boundingBox();
- const composer = await page.locator('[data-assistant-composer]').boundingBox();
+ const composer = await page.locator('[data-assistant-control-toolbar]').boundingBox();
assert.ok(bounds.x >= composer.x - 1 && bounds.x + bounds.width <= composer.x + composer.width + 1);
assert.ok(bounds.x >= 0 && bounds.x + bounds.width <= width + 1);
await capture('chat-menu');
diff --git a/frontend-modern/browser-verification/f0395e0381f0f6ea.json b/frontend-modern/browser-verification/f0395e0381f0f6ea.json
new file mode 100644
index 0000000000..1d6ee2708e
--- /dev/null
+++ b/frontend-modern/browser-verification/f0395e0381f0f6ea.json
@@ -0,0 +1,45 @@
+{
+ "version": 1,
+ "base_sha": "6488742416d991435646ea5272fe6d510c808de8",
+ "result": "passed",
+ "verified_at": "2026-10-10T00:37:41Z",
+ "changed_paths": [
+ "frontend-modern/src/components/AI/Chat/index.tsx"
+ ],
+ "content_sha256": {
+ "frontend-modern/src/components/AI/Chat/index.tsx": "a351601dfcd240ca8438b414523e2437513fd32aac16874dde24540af52cc8d2"
+ },
+ "routes": [
+ "Existing Settings/Chat/Docs in local /browser-tests/assistant-control-compatibility.html fixture",
+ "/settings/ai/assistant",
+ "/docs/AI#control-levels",
+ "/docs/AI_AUTONOMY#assistant-control-levels"
+ ],
+ "states": [
+ "Five raw saved modes without preference/policy rewrites",
+ "Legacy protected list value and accessible no-plan-exclusion limitation",
+ "Read-only and Ask first, saved-error preservation, explicit opt-out",
+ "Scoped alert identity and false-autonomy/approval context",
+ "Chromium desktop light and WebKit 390px dark/320px light"
+ ],
+ "interactions": [
+ "51 assertion groups, including actual containing toolbar/viewport popup bounds and resize-close/reopen",
+ "19 inspected captures, three fresh mode-menu captures and sixteen byte-identical prior inspections",
+ "Actual Docs links, planning/approval/legacy limits and local table scroll"
+ ],
+ "viewports": [
+ {
+ "width": 1365,
+ "height": 900
+ },
+ {
+ "width": 390,
+ "height": 844
+ },
+ {
+ "width": 320,
+ "height": 740
+ }
+ ],
+ "notes": "Correct the existing clamp anchor: the input form is a sibling of the route controls, not their ancestor. Native form click behaviour is unchanged. Playwright 1.56.1; Chromium 141.0.7390.37 and WebKit 26.0. Browser/server closed. Synthetic transport, no inference/action/native or release claim."
+}
diff --git a/frontend-modern/src/components/AI/Chat/__tests__/AIChat.test.tsx b/frontend-modern/src/components/AI/Chat/__tests__/AIChat.test.tsx
index 9e40ec4bfb..4566aa3518 100644
--- a/frontend-modern/src/components/AI/Chat/__tests__/AIChat.test.tsx
+++ b/frontend-modern/src/components/AI/Chat/__tests__/AIChat.test.tsx
@@ -3585,7 +3585,8 @@ describe('AIChat', () => {
it('clamps the mode menu inside the composer and closes it on viewport resize', () => {
renderChat();
const trigger = screen.getByRole('button', { name: 'Assistant chat action mode: Read-only' });
- const composer = trigger.closest('[data-assistant-composer]') as HTMLElement;
+ const composer = trigger.closest('[data-assistant-control-toolbar]') as HTMLElement;
+ expect(composer).not.toBeNull();
vi.spyOn(trigger, 'getBoundingClientRect').mockReturnValue({ left: 185 } as DOMRect);
vi.spyOn(composer, 'getBoundingClientRect').mockReturnValue({
left: 16,
diff --git a/frontend-modern/src/components/AI/Chat/index.tsx b/frontend-modern/src/components/AI/Chat/index.tsx
index 3b9e8e0cbd..2d274e1bc7 100644
--- a/frontend-modern/src/components/AI/Chat/index.tsx
+++ b/frontend-modern/src/components/AI/Chat/index.tsx
@@ -1500,7 +1500,7 @@ export const AIChat: Component<AIChatProps> = (props) => {
// review-only menu inside the composer, not clipped by the chat panel.
const trigger = controlModeButtonRef?.getBoundingClientRect();
const composer = controlModeButtonRef
- ?.closest('[data-assistant-composer]')
+ ?.closest('[data-assistant-control-toolbar]')
?.getBoundingClientRect();
const leftEdge = Math.max(16, composer?.left ?? 16);
const rightEdge = Math.min(window.innerWidth - 16, composer?.right || window.innerWidth - 16);
@@ -5391,6 +5391,7 @@ export const AIChat: Component<AIChatProps> = (props) => {
<div
class="flex min-w-0 flex-wrap items-center gap-1.5 sm:flex-1"
data-testid="assistant-composer-route-controls"
+ data-assistant-control-toolbar
>
<ModelSelector
models={aiRuntimeModels()}