Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Keep Coverage expansion focus when retained evidence shrinks

pulse-triage[bot]b94e3fc46402
diff --git a/frontend-modern/src/features/proxmox/ProxmoxCoverageTable.tsx b/frontend-modern/src/features/proxmox/ProxmoxCoverageTable.tsx
index 9e9ab39b9b..b32f639d2d 100644
--- a/frontend-modern/src/features/proxmox/ProxmoxCoverageTable.tsx
+++ b/frontend-modern/src/features/proxmox/ProxmoxCoverageTable.tsx
@@ -707,25 +707,25 @@ export function ProxmoxCoverageTable(props: {
sections={buildCoverageDetailSections(row)}
onClose={() => props.onToggleExpand(row.key)}
>
- <Show
- when={evidence().length > 0}
- fallback={
- <InlineNotice
- tone={
- row.posture === 'unprotected' || row.posture === 'attention'
- ? 'warning'
- : 'info'
- }
- role="status"
- class="text-xs"
- >
- {!backupHistoryComplete()
- ? 'Restore-point history is not confirmed complete. Missing entries do not mean no backups exist.'
- : 'No restore-point details are visible in the current list. The posture above may use previously recorded evidence.'}
- </InlineNotice>
- }
- >
- <div class="overflow-hidden rounded-sm border border-border bg-surface">
+ <div class="overflow-hidden rounded-sm border border-border bg-surface">
+ <Show
+ when={evidence().length > 0}
+ fallback={
+ <InlineNotice
+ tone={
+ row.posture === 'unprotected' || row.posture === 'attention'
+ ? 'warning'
+ : 'info'
+ }
+ role="status"
+ class="text-xs"
+ >
+ {!backupHistoryComplete()
+ ? 'Restore-point history is not confirmed complete. Missing entries do not mean no backups exist.'
+ : 'No restore-point details are visible in the current list. The posture above may use previously recorded evidence.'}
+ </InlineNotice>
+ }
+ >
<div class="flex items-center justify-between gap-2 bg-surface-alt px-2 py-1 text-[10px] font-semibold uppercase tracking-wide text-muted">
<span>Restore evidence</span>
<Show when={row.artifacts.length > evidence().length}>
@@ -886,39 +886,45 @@ export function ProxmoxCoverageTable(props: {
</For>
</PlatformDetailTableBody>
</PlatformDetailTable>
- <Show
- when={row.artifacts.length > COVERAGE_RESTORE_EVIDENCE_PAGE_SIZE}
- >
- <div class="border-t border-border px-2 py-2">
- <button
- type="button"
- class="rounded-sm px-2 py-1 text-xs font-medium text-accent hover:bg-surface-hover focus-visible:outline focus-visible:outline-2 focus-visible:outline-offset-2 focus-visible:outline-accent"
- aria-disabled={evidence().length >= row.artifacts.length}
- onClick={() => {
- if (evidence().length < row.artifacts.length)
- setEvidenceLimit(
- evidence().length + COVERAGE_RESTORE_EVIDENCE_PAGE_SIZE,
- );
- }}
+ </Show>
+ <Show
+ when={
+ row.artifacts.length > COVERAGE_RESTORE_EVIDENCE_PAGE_SIZE ||
+ evidenceLimit() > COVERAGE_RESTORE_EVIDENCE_PAGE_SIZE
+ }
+ >
+ <div class="border-t border-border px-2 py-2">
+ <button
+ type="button"
+ class="rounded-sm px-2 py-1 text-xs font-medium text-accent hover:bg-surface-hover focus-visible:outline focus-visible:outline-2 focus-visible:outline-offset-2 focus-visible:outline-accent"
+ aria-disabled={evidence().length >= row.artifacts.length}
+ onClick={() => {
+ if (evidence().length < row.artifacts.length)
+ setEvidenceLimit(
+ evidence().length + COVERAGE_RESTORE_EVIDENCE_PAGE_SIZE,
+ );
+ }}
+ >
+ <Show
+ when={evidence().length < row.artifacts.length}
+ fallback={
+ <>
+ All {evidence().length} evidence{' '}
+ {evidence().length === 1 ? 'entry' : 'entries'} shown
+ </>
+ }
>
- <Show
- when={evidence().length < row.artifacts.length}
- fallback={
- <>All {evidence().length} evidence entries shown</>
- }
- >
- Show{' '}
- {Math.min(
- COVERAGE_RESTORE_EVIDENCE_PAGE_SIZE,
- row.artifacts.length - evidence().length,
- )}{' '}
- more evidence entries
- </Show>
- </button>
- </div>
- </Show>
- </div>
- </Show>
+ Show{' '}
+ {Math.min(
+ COVERAGE_RESTORE_EVIDENCE_PAGE_SIZE,
+ row.artifacts.length - evidence().length,
+ )}{' '}
+ more evidence entries
+ </Show>
+ </button>
+ </div>
+ </Show>
+ </div>
</InlineDetailPanel>
</InlineDetailTableRow>
</Show>
diff --git a/frontend-modern/src/features/proxmox/__tests__/ProxmoxCoverageTable.test.tsx b/frontend-modern/src/features/proxmox/__tests__/ProxmoxCoverageTable.test.tsx
index e458873e0d..9c5589f76a 100644
--- a/frontend-modern/src/features/proxmox/__tests__/ProxmoxCoverageTable.test.tsx
+++ b/frontend-modern/src/features/proxmox/__tests__/ProxmoxCoverageTable.test.tsx
@@ -70,7 +70,7 @@ const headerTexts = () =>
afterEach(cleanup);
describe('ProxmoxCoverageTable column visibility', () => {
- it('keeps uncertain archive evidence inspectable without changing server posture or its owner', () => {
+ it('keeps uncertain archive evidence inspectable without changing server posture or its owner', async () => {
const model = buildProxmoxBackupRecoveryModel({
workloads: [identityGuest('east-100', 'east', 'pve-1')],
pbsBackups: [],
@@ -83,9 +83,10 @@ describe('ProxmoxCoverageTable column visibility', () => {
],
});
const current = model.coverageRows[0];
+ const [rows, setRows] = createSignal(model.coverageRows);
renderInRouter(() => (
<ProxmoxCoverageTable
- rows={[current]}
+ rows={rows()}
hasAnyRows
emptyIcon={<span />}
emptyTitle=""
@@ -115,6 +116,18 @@ describe('ProxmoxCoverageTable column visibility', () => {
within(panel).getByRole('button', { name: 'All 13 evidence entries shown' }),
).toHaveAttribute('aria-disabled', 'true');
expect(model.coverageRows[0]).toBe(current);
+ const more = within(panel).getByRole('button', { name: 'All 13 evidence entries shown' });
+ more.focus();
+ setRows([{ ...current, artifacts: [current.artifacts[0]] }]);
+ await waitFor(() => expect(more).toHaveTextContent('All 1 evidence entry shown'));
+ expect(document.activeElement).toBe(more);
+ setRows([{ ...current, artifacts: [] }]);
+ await waitFor(() => expect(more).toHaveTextContent('All 0 evidence entries shown'));
+ expect(panel).not.toHaveTextContent('Restore evidence');
+ expect(document.activeElement).toBe(more);
+ setRows(model.coverageRows);
+ await waitFor(() => expect(evidence().querySelectorAll('tbody > tr')).toHaveLength(13));
+ expect(document.activeElement).toBe(more);
});
it('keeps full-width identity columns alongside the workload connection', () => {
diff --git a/frontend-modern/src/features/proxmox/__tests__/coverageEvidenceInspection.test.tsx b/frontend-modern/src/features/proxmox/__tests__/coverageEvidenceInspection.test.tsx
index b2c74a495e..61a7878a81 100644
--- a/frontend-modern/src/features/proxmox/__tests__/coverageEvidenceInspection.test.tsx
+++ b/frontend-modern/src/features/proxmox/__tests__/coverageEvidenceInspection.test.tsx
@@ -133,7 +133,7 @@ describe('Coverage uncertain evidence inspection through parsed inventory', () =
const evidence = evidenceTable(panel);
expect(within(evidence).getAllByText('Unknown', { exact: true })).toHaveLength(5);
expect(evidence).toHaveTextContent('Running');
- expect(evidence).toHaveTextContent('Incomplete');
+ expect(evidence).toHaveTextContent('Failed');
expect(evidence).toHaveTextContent(literal);
expect(evidence.querySelector('img')).toBeNull();
expect(evidence).toHaveTextContent('archive-undated-0');