Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.
Go aialertsdashboarddockerdocker-monitoringgohomelabinfrastructure-monitoringkubernetesmonitoringmspproxmoxproxmox-backup-serverproxmox-mail-gatewayproxmox-veself-hostedtruenastypescriptvspherewebhooks
Keep Machines, thresholds and infrastructure rows on one line
rcourtmanb9d3039cd82b
diff --git a/docs/release-control/v6/internal/subsystems/agent-lifecycle.md b/docs/release-control/v6/internal/subsystems/agent-lifecycle.mdindex 1addccdea9..200bca9f7b 100644--- a/docs/release-control/v6/internal/subsystems/agent-lifecycle.md+++ b/docs/release-control/v6/internal/subsystems/agent-lifecycle.md@@ -3995,6 +3995,8 @@ screenshots as enrollment, update readiness or lifecycle verification.operator to review the same machine twice under a hostname row and anIP-only candidate row. Per-row Manage actions live directly on the`InfrastructureSourceManager` row and open the governed edit/detail flow;+ the row stays one 33px line (4px cell padding, actions overhanging the+ row, a system line that does not wrap its badges);`frontend-modern/src/components/Settings/useConnectionRowActions.ts`owns the pause/remove API dispatch, two-click remove confirm, andper-id action error presentation inside that flow. Last-error detail is rendereddiff --git a/docs/release-control/v6/internal/subsystems/alerts.md b/docs/release-control/v6/internal/subsystems/alerts.mdindex 8fa70e7f3e..fac882b24b 100644--- a/docs/release-control/v6/internal/subsystems/alerts.md+++ b/docs/release-control/v6/internal/subsystems/alerts.md@@ -5204,8 +5204,12 @@ without deleting mount identity, saved overrides or threshold controls. Nativeanother source. Independent LXC platform storage does not inherit VM-onlyread reasons. A new accepted reading clears the explanation, including zero.-The shared desktop row and phone card display the optional `readingMessage`-as wrapping text beside the reading, not hover-only or truncated guidance.+The phone card displays the optional `readingMessage` as wrapping text beside+the reading. The desktop row puts it on the name's line, ending in an+ellipsis with the whole note in its title, so the row stays one line instead+of wrapping a paragraph under the name (rows had reached 65px). Desktop rows+are 33px: the 24px alert toggles and the 26px Global Defaults threshold+inputs overhang the row instead of setting a 35px height.Missing filesystem samples keep saved settings editable with an explicitunavailable label. Existing numeric serialization, identity, persistence,active-alert linkage, edit-time row stabilisation and threshold evaluationdiff --git a/docs/release-control/v6/internal/subsystems/frontend-primitives.md b/docs/release-control/v6/internal/subsystems/frontend-primitives.mdindex fc527989b1..a33f11009b 100644--- a/docs/release-control/v6/internal/subsystems/frontend-primitives.md+++ b/docs/release-control/v6/internal/subsystems/frontend-primitives.md@@ -1012,6 +1012,21 @@ fragments do not throw or move focus. The renderer and fragment helper arecovered by `frontend-modern/src/features/docs/__tests__/docMarkdown.test.ts`,with direct-link, reload and keyboard navigation verified in the live viewer.+### Desktop table rows stay single-line++Platform, Machines, alert threshold and Settings > Infrastructure desktop+rows are one line of at most 33px, the height of the platform tables.+Controls taller than the 24px line overhang the row with negative margins+instead of setting its height: the Machines actions button (`sm:-my-0.5`,+37px rows before), the Settings > Infrastructure Manage actions, and the+alert threshold toggles and inputs. Settings > Infrastructure body cells use+the platform tables' 4px vertical padding (39px rows before), and its system+line keeps the name, collection badge and member toggle on one line,+truncating the name, where a wrapped badge had made a 63px row. Long text+ends in an ellipsis with its full value in the title. Alert History keeps+its two-line Message below an 80rem card: at a 1280px window its message+track is about 180px, and one line read "Docker service..." for most rows.+### Visible phone row disclosure keeps rows single-line`SummaryRowActionButton` keeps a 36 px disclosure target on phones, where@@ -9792,8 +9807,9 @@ History and the native-facet-to-workload mapping with an unaffected second site.The Alerts Guest Filesystems projection now consumes the Workloads readadmission instead of treating retained numeric fields as a current reading.Explicit native stopped-VM state and unavailable reads withdraw usage; retained-reads are labelled Last known. The shared threshold row/card display a wrapping-`readingMessage` next to the reading, including before a missing saved mount+reads are labelled Last known. The threshold card displays a wrapping+`readingMessage` next to the reading and the desktop row puts it on the+name's line with its full text in the title, including before a missing saved mounthas another sample, while preserving threshold values and override identities.Independent LXC platform storage and fresh zero remain unchanged.diff --git a/docs/release-control/v6/internal/subsystems/unified-resources.md b/docs/release-control/v6/internal/subsystems/unified-resources.mdindex 1bc2e6d199..ef9007c8ec 100644--- a/docs/release-control/v6/internal/subsystems/unified-resources.md+++ b/docs/release-control/v6/internal/subsystems/unified-resources.md@@ -2668,7 +2668,9 @@ reads before it carries a Proxmox disk reading forward.For SMART disktemperatures on rows that still render, the provenance travels on`agent.sensors.smart[].collection`: the Machines temperature cell-(`AgentsMachinesTable.tsx`, `agentMachineTableModel.ts`), its tooltip and the+(`AgentsMachinesTable.tsx`, `agentMachineTableModel.ts`; its desktop actions+button overhangs the row by 2px each way so Machines rows are 33px, not 37px),+its tooltip and thedrawer's Thermals rows (`resourceDetailMappers.ts`) read it through`isPhysicalDiskTemperatureCurrent`, so a retained disk reading never stands forthe machine while another disk has a current one. A positive directdiff --git a/frontend-modern/browser-verification/f8b0ff8b4fa3e4b9.json b/frontend-modern/browser-verification/f8b0ff8b4fa3e4b9.jsonnew file mode 100644index 0000000000..21869e6942--- /dev/null+++ b/frontend-modern/browser-verification/f8b0ff8b4fa3e4b9.json@@ -0,0 +1,50 @@+{+ "version": 1,+ "base_sha": "c5658b187e823477c78c45ef7328026318572316",+ "verified_at": "2026-10-25T19:42:02Z",+ "result": "passed",+ "changed_paths": [+ "frontend-modern/src/components/Alerts/AlertResourceMetricEditor.tsx",+ "frontend-modern/src/components/Alerts/AlertResourceTableDesktop.tsx",+ "frontend-modern/src/components/Alerts/AlertResourceTableRow.tsx",+ "frontend-modern/src/components/Settings/InfrastructureSourceManager.tsx",+ "frontend-modern/src/features/standalone/AgentsMachinesTable.tsx"+ ],+ "content_sha256": {+ "frontend-modern/src/components/Alerts/AlertResourceMetricEditor.tsx": "f8e4998a9b2d08ca3c8d630d198d70846c776f7a71a6e408d9dbc9d613996e6e",+ "frontend-modern/src/components/Alerts/AlertResourceTableDesktop.tsx": "4cf1a55a197633917dda9170455041d2d785efed42ff0420ebe223cefc0a8271",+ "frontend-modern/src/components/Alerts/AlertResourceTableRow.tsx": "09e72e4883768b6386f18bdd7231900d20c90469752317032904e547f86340cf",+ "frontend-modern/src/components/Settings/InfrastructureSourceManager.tsx": "3503bfa8663123fcd181755a282dfa512b2215217a8d038b66a826463ed6625b",+ "frontend-modern/src/features/standalone/AgentsMachinesTable.tsx": "c75ba11cbb2c665b6d2fafa618bd3fc53cce71b3d241a4d7af1dd2d580073d8f"+ },+ "routes": [+ "/standalone/machines",+ "/alerts/thresholds/proxmox",+ "/settings/infrastructure"+ ],+ "viewports": [+ {+ "width": 1280,+ "height": 900+ },+ {+ "width": 430,+ "height": 932+ },+ {+ "width": 375,+ "height": 812+ }+ ],+ "states": [+ "Embedded production build of this tree in mock mode on pulse-dev, headless Chromium, dark theme; the three changed files per table are byte-identical (sha256 checked) to the build measured.",+ "Before at 1280px: Machines rows 37px (28px actions button), alert threshold rows 35px (24px toggles with my-px, 26px Global Defaults inputs) and 65px where a guest-filesystem reading note wrapped under the name, Settings > Infrastructure rows 39px (6px padding, 26px Manage) and 63px where a badge wrapped. After: Machines 33px (4 rows), thresholds 33px (92 + 104 rows), Settings > Infrastructure 33px (71 rows).",+ "Expanded the Guest Filesystems thresholds group: rows with a reading note are 33px and read \"/ Usage unavailable Guest filesystem stats unavailable while the VM is stopped.\" on one line, with the whole note in the title.",+ "Row sweep of every platform tab at 375, 430 and 1280px (138 page loads, 220 tables): these three tables have no rows above 33.5px and no stacked cells. Phone widths are unchanged (these desktop tables give way to cards or keep their phone touch targets)."+ ],+ "interactions": [+ "Inspected 1280px screenshots of Machines, Settings > Infrastructure and the expanded thresholds group; buttons, toggles and inputs keep their sizes and touch targets, only their layout overhang changed.",+ "Alerts, Settings, standalone and pages component tests (271 files) pass under Node 24, including new pins for the Machines button overhang, Settings cell padding and non-wrapping system line, and the threshold reading note title."+ ],+ "proof_scope": "Desktop row height for Machines, alert thresholds and Settings > Infrastructure; thresholds, actions and infrastructure management behaviour unchanged."+}diff --git a/frontend-modern/src/components/Alerts/AlertResourceMetricEditor.tsx b/frontend-modern/src/components/Alerts/AlertResourceMetricEditor.tsxindex 1c2534f5d8..39fb4655da 100644--- a/frontend-modern/src/components/Alerts/AlertResourceMetricEditor.tsx+++ b/frontend-modern/src/components/Alerts/AlertResourceMetricEditor.tsx@@ -69,7 +69,9 @@ export function AlertResourceMetricEditor(props: AlertResourceMetricEditorProps)return (<div- class={`flex items-center gap-1.5 ${props.layout === 'card' ? '[&_button]:min-h-11' : 'justify-center'} ${isDefault() ? 'w-full' : ''}`}+ // In a table row the 26px input overhangs by 2px each way, so it does+ // not set a 35px row beside the 33px rows of the other tables.+ class={`flex items-center gap-1.5 ${props.layout === 'card' ? '[&_button]:min-h-11' : '-my-0.5 justify-center'} ${isDefault() ? 'w-full' : ''}`}><div class={`relative ${props.layout === 'card' && isDefault() ? 'flex-1 min-w-0' : ''}`}><inputdiff --git a/frontend-modern/src/components/Alerts/AlertResourceTableDesktop.tsx b/frontend-modern/src/components/Alerts/AlertResourceTableDesktop.tsxindex 184f62a5b9..0e079fcb83 100644--- a/frontend-modern/src/components/Alerts/AlertResourceTableDesktop.tsx+++ b/frontend-modern/src/components/Alerts/AlertResourceTableDesktop.tsx@@ -262,7 +262,7 @@ export function AlertResourceTableDesktop(props: AlertResourceTableDesktopProps)props.table.onToggleGlobalDisable?.();props.table.setHasUnsavedChanges?.(true);}}- class="my-px"+ class="-my-0.5"title="Global alerts toggle - disable all alerts for this resource type"ariaLabel="Global alerts toggle"/>diff --git a/frontend-modern/src/components/Alerts/AlertResourceTableRow.tsx b/frontend-modern/src/components/Alerts/AlertResourceTableRow.tsxindex 89c78a098c..91ac90a1f5 100644--- a/frontend-modern/src/components/Alerts/AlertResourceTableRow.tsx+++ b/frontend-modern/src/components/Alerts/AlertResourceTableRow.tsx@@ -279,7 +279,7 @@ export function AlertResourceTableRow(props: AlertResourceTableRowProps) {checked={isChecked}disabled={globallyDisabled}onToggle={() => !globallyDisabled && props.onToggleDisabled?.(props.resource.id)}- class="my-px"+ class="-my-0.5"title={globallyDisabled? 'Alerts disabled globally'@@ -297,10 +297,7 @@ export function AlertResourceTableRow(props: AlertResourceTableRowProps) {</TableCell><TableCell class={getPlatformTableCellClassForKind('name')}>- <div- class="flex items-center gap-2 min-w-0"- classList={{ 'flex-wrap': Boolean(props.resource.readingMessage) }}- >+ <div class="flex items-center gap-2 min-w-0"><Showwhen={props.resource.type === 'agent'}fallback={@@ -341,12 +338,19 @@ export function AlertResourceTableRow(props: AlertResourceTableRowProps) {{getAlertResourceTableCustomBadgeLabel()}</span></Show>+ {/* The reading note joins the name on its line and ends in an+ ellipsis, with the whole note in its title, so the row stays+ one line tall instead of wrapping a paragraph under the name. */}+ <Show when={props.resource.readingMessage}>+ <span+ class="min-w-0 truncate text-xs text-muted"+ title={props.resource.readingMessage}+ data-alert-resource-reading-message+ >+ {props.resource.readingMessage}+ </span>+ </Show></div>- <Show when={props.resource.readingMessage}>- <p class="mt-1 max-w-prose text-xs text-muted whitespace-normal break-words">- {props.resource.readingMessage}- </p>- </Show><Show when={isEditing()}><FormTextareaid={`note-${props.resource.id}`}diff --git a/frontend-modern/src/components/Alerts/ResourceTable.test.tsx b/frontend-modern/src/components/Alerts/ResourceTable.test.tsxindex edba838fe5..f2cb4c6ea4 100644--- a/frontend-modern/src/components/Alerts/ResourceTable.test.tsx+++ b/frontend-modern/src/components/Alerts/ResourceTable.test.tsx@@ -244,9 +244,22 @@ describe('ResourceTable', () => {]);const props = makeProps({ columns: ['Disk %'] });render(() => <ResourceTable {...props} resources={resources()} />);- expect(- screen.getByText('Guest reads paused while the backup lock is reported.'),- ).not.toHaveClass('truncate');+ const explanation = screen.getByText(+ 'Guest reads paused while the backup lock is reported.',+ );+ if (mobile) {+ expect(explanation).not.toHaveClass('truncate');+ } else {+ // A desktop row stays one line: the note joins the name and ends in+ // an ellipsis, with the whole note in its title.+ expect(explanation).toHaveClass('truncate');+ expect(explanation).toHaveAttribute(+ 'title',+ 'Guest reads paused while the backup lock is reported.',+ );+ expect(explanation.parentElement).toHaveClass('flex', 'items-center');+ expect(explanation.parentElement).not.toHaveClass('flex-wrap');+ }if (mobile)expect(screen.getByText('Last known 9.0 / 10.0 GB · 90.0%')).not.toHaveClass('truncate');setResources([diff --git a/frontend-modern/src/components/Settings/InfrastructureSourceManager.tsx b/frontend-modern/src/components/Settings/InfrastructureSourceManager.tsxindex 0ff1833d43..81936b216b 100644--- a/frontend-modern/src/components/Settings/InfrastructureSourceManager.tsx+++ b/frontend-modern/src/components/Settings/InfrastructureSourceManager.tsx@@ -961,8 +961,8 @@ export const InfrastructureSourceManager: Component<InfrastructureSourceManagerProw.isCluster ? '' : ''}`}>- <TableCell class="py-1.5 pl-3 pr-3 align-middle">- <div class="flex min-w-0 flex-wrap items-center gap-1.5">+ <TableCell class="py-1 pl-3 pr-3 align-middle">+ <div class="flex min-w-0 items-center gap-1.5"><Showwhen={infrastructureRowMonitoringPath(row)}fallback={@@ -1008,7 +1008,7 @@ export const InfrastructureSourceManager: Component<InfrastructureSourceManagerP<Show when={row.members.length > 0}><buttontype="button"- class="inline-flex items-center gap-0.5 rounded-sm px-1 py-0.5 text-[11px] font-medium text-muted transition-colors hover:bg-surface-alt hover:text-base-content"+ class="inline-flex shrink-0 items-center gap-0.5 whitespace-nowrap rounded-sm px-1 py-0.5 text-[11px] font-medium text-muted transition-colors hover:bg-surface-alt hover:text-base-content"aria-expanded={membersExpanded(row)}aria-label={`${membersExpanded(row) ? 'Hide' : 'Show'} ${formatCount(row.members.length, row.ownerType === 'vmware' ? 'host' : 'node')} for ${row.name}`}onClick={() => toggleMembers(row)}@@ -1028,7 +1028,7 @@ export const InfrastructureSourceManager: Component<InfrastructureSourceManagerP</div></TableCell>- <TableCell class="px-3 py-1.5 align-middle">+ <TableCell class="px-3 py-1 align-middle"><Showwhen={row.coverageLabels.length > 0}fallback={@@ -1051,7 +1051,7 @@ export const InfrastructureSourceManager: Component<InfrastructureSourceManagerP</Show></TableCell>- <TableCell class="px-3 py-1.5 align-middle">+ <TableCell class="px-3 py-1 align-middle"><div class="flex items-center gap-1.5 overflow-hidden whitespace-nowrap"><spanclass={`inline-flex items-center rounded-full px-2 py-0.5 text-[11px] font-medium whitespace-nowrap ${row.statusClassName}`}@@ -1102,14 +1102,14 @@ export const InfrastructureSourceManager: Component<InfrastructureSourceManagerP</TableCell><Show when={actionColumnVisible()}>- <TableCell class="px-3 py-1.5 align-middle text-right">+ <TableCell class="px-3 py-1 align-middle text-right"><Showwhen={rowInteractive(row)}fallback={<span class="text-xs text-muted">Read only</span>}>- <div class="flex items-center justify-end gap-1.5">+ <div class="-my-0.5 flex items-center justify-end gap-1.5"><Showwhen={rowNeedsAgentCoverage(row) &&@@ -1199,7 +1199,7 @@ export const InfrastructureSourceManager: Component<InfrastructureSourceManagerPreturn (<><TableRow class="border-b border-border-subtle">- <TableCell class="py-1.5 pl-3 pr-3 align-middle">+ <TableCell class="py-1 pl-3 pr-3 align-middle"><div class="min-w-0 pl-4"><div class="flex min-w-0 items-center gap-1.5"><span class="h-1.5 w-1.5 shrink-0 rounded-full bg-border" />@@ -1231,7 +1231,7 @@ export const InfrastructureSourceManager: Component<InfrastructureSourceManagerP</div></TableCell>- <TableCell class="px-3 py-1.5 align-middle">+ <TableCell class="px-3 py-1 align-middle"><Showwhen={member.coverageLabels.length > 0}fallback={@@ -1252,7 +1252,7 @@ export const InfrastructureSourceManager: Component<InfrastructureSourceManagerP</Show></TableCell>- <TableCell class="px-3 py-1.5 align-middle">+ <TableCell class="px-3 py-1 align-middle"><div class="flex items-center gap-1.5 overflow-hidden whitespace-nowrap"><spanclass={`inline-flex items-center rounded-full px-2 py-0.5 text-[11px] font-medium whitespace-nowrap ${member.statusClassName}`}@@ -1266,7 +1266,7 @@ export const InfrastructureSourceManager: Component<InfrastructureSourceManagerP</TableCell><Show when={actionColumnVisible()}>- <TableCell class="px-3 py-1.5 align-middle text-right">+ <TableCell class="px-3 py-1 align-middle text-right"><Showwhen={row.ownerType === 'pve' &&@@ -1344,7 +1344,7 @@ export const InfrastructureSourceManager: Component<InfrastructureSourceManagerP{(server) => {return (<TableRow class={discoveryRowClass}>- <TableCell class="py-1.5 pl-3 pr-3 align-middle">+ <TableCell class="py-1 pl-3 pr-3 align-middle"><div class="min-w-0"><div class="flex items-center gap-1.5"><div@@ -1369,7 +1369,7 @@ export const InfrastructureSourceManager: Component<InfrastructureSourceManagerP</div></TableCell>- <TableCell class="px-3 py-1.5 align-middle">+ <TableCell class="px-3 py-1 align-middle"><divclass="whitespace-normal text-[12px] leading-4 text-muted"title={discoveredCoverageText(server)}@@ -1378,7 +1378,7 @@ export const InfrastructureSourceManager: Component<InfrastructureSourceManagerP</div></TableCell>- <TableCell class="px-3 py-1.5 align-middle">+ <TableCell class="px-3 py-1 align-middle"><div class="flex items-center gap-1.5 overflow-hidden whitespace-nowrap"><span class="inline-flex items-center rounded-full bg-blue-100 px-2 py-0.5 text-[11px] font-medium whitespace-nowrap text-blue-800 dark:bg-blue-950/40 dark:text-blue-200">Discovered@@ -1390,7 +1390,7 @@ export const InfrastructureSourceManager: Component<InfrastructureSourceManagerP</TableCell><Show when={actionColumnVisible()}>- <TableCell class="px-3 py-1.5 align-middle text-right">+ <TableCell class="px-3 py-1 align-middle text-right"><Showwhen={props.onReviewDiscoveredSource}fallback={diff --git a/frontend-modern/src/components/Settings/__tests__/InfrastructureSourceManager.test.tsx b/frontend-modern/src/components/Settings/__tests__/InfrastructureSourceManager.test.tsxindex 25e7b2278a..d9602f1031 100644--- a/frontend-modern/src/components/Settings/__tests__/InfrastructureSourceManager.test.tsx+++ b/frontend-modern/src/components/Settings/__tests__/InfrastructureSourceManager.test.tsx@@ -227,6 +227,19 @@ describe('InfrastructureSourceManager setup summary', () => {expect(infrastructureSourceManagerSource).toContain('class="min-h-11 min-w-18 shrink-0 lg:min-h-0"',);+ // Desktop rows stay one 33px line like the platform tables: 4px cell+ // padding, a system line that never wraps its badges, and actions that+ // overhang the row.+ expect(infrastructureSourceManagerSource).toContain(+ '<TableCell class="py-1 pl-3 pr-3 align-middle">',+ );+ expect(infrastructureSourceManagerSource).not.toMatch(/<TableCell class="[^"]*py-1\.5/);+ expect(infrastructureSourceManagerSource).not.toContain(+ 'flex min-w-0 flex-wrap items-center gap-1.5',+ );+ expect(infrastructureSourceManagerSource).toContain(+ '-my-0.5 flex items-center justify-end gap-1.5',+ );});it.each([1440, 390])('keeps visible Add and update labels in scoped names at %ipx', (width) => {diff --git a/frontend-modern/src/features/standalone/AgentsMachinesTable.tsx b/frontend-modern/src/features/standalone/AgentsMachinesTable.tsxindex db26cbb8f6..ec355ed9df 100644--- a/frontend-modern/src/features/standalone/AgentsMachinesTable.tsx+++ b/frontend-modern/src/features/standalone/AgentsMachinesTable.tsx@@ -840,7 +840,7 @@ const AgentMachineActionsCell: Component<{label={`Machine actions for ${props.name}`}tone="muted"size="sm"- class="-my-2 min-h-11 min-w-11 sm:my-0 sm:min-h-0 sm:min-w-0"+ class="-my-2 min-h-11 min-w-11 sm:-my-0.5 sm:min-h-0 sm:min-w-0"aria-haspopup="menu"aria-expanded={props.menuOpen ? 'true' : 'false'}onClick={(event) => {diff --git a/frontend-modern/src/features/standalone/__tests__/AgentsMachinesTable.test.tsx b/frontend-modern/src/features/standalone/__tests__/AgentsMachinesTable.test.tsxindex bbdd702c14..6fbf0669d7 100644--- a/frontend-modern/src/features/standalone/__tests__/AgentsMachinesTable.test.tsx+++ b/frontend-modern/src/features/standalone/__tests__/AgentsMachinesTable.test.tsx@@ -931,6 +931,11 @@ describe('AgentsMachinesTable', () => {/>));+ // The 28px desktop actions button overhangs the row instead of setting+ // 37px rows; phones keep the 44px target.+ expect(+ screen.getByRole('button', { name: 'Machine actions for Removable Machine' }),+ ).toHaveClass('-my-2', 'min-h-11', 'sm:-my-0.5', 'sm:min-h-0');await fireEvent.click(screen.getByRole('button', { name: 'Machine actions for Removable Machine' }),);