Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Keep selected PBS datastore evidence readable without hover

pulse-triage[bot]ba771be06e2c
diff --git a/docs/release-control/v6/internal/subsystems/frontend-primitives.md b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
index 27a8bcc734..ee01e5a974 100644
--- a/docs/release-control/v6/internal/subsystems/frontend-primitives.md
+++ b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
@@ -20,6 +20,32 @@
## Purpose
+### Selected PBS datastore remains inspectable without hover
+
+The existing PBS row disclosure is named by backup reader and datastore, rather
+than giving every store on one server the same control label. Single-line scan
+cells and responsive widths are unchanged. Its open detail presents the full,
+wrapping reader/store identities and admitted capacity bytes/percentage and
+inventory count, including when those columns are hidden or truncated. The
+shared platform detail row accepts optional row context inside the same native
+inline shell; this does not replace the canonical resource or its History target.
+
+Loading and unavailable inventory remain nonnumeric; accepted empty inventory
+is zero. Unavailable/unknown capacity never becomes zero, even with a Healthy
+connection. A server without datastore data has neither a made-up store nor a
+count. Counts describe loaded entries, including in-progress/unverified entries,
+not backup protection. These independent evidence meanings, correlation, read
+cadence, retry, API, auth and protection policy are unchanged.
+
+Normal-suite `backupServerDatastoreAccess.test.tsx` exercises long namesakes,
+responsive projections, parsed inventory loading/failure/retry/polling, capacity
+admission, no-store data, live reordering and retained detail/focus. The registered
+`ProxmoxBackupsTable.test.tsx` verifies the selected consumer; shared detail-row
+and platform-layout tests preserve the separate context/host owners. Browser
+proof exercises actual keyboard/touch disclosure, open-record refresh and
+complete wrapping identifiers at desktop/narrow widths with pixel inspection.
+This is safer evidence inspection, not original guest or installed recovery.
+
### Backup-server read states remain legible at intermediate widths
The existing PBS server table reserves enough count-column width for the full
diff --git a/docs/release-control/v6/internal/subsystems/storage-recovery.md b/docs/release-control/v6/internal/subsystems/storage-recovery.md
index 84d6fd037b..5a872d63cb 100644
--- a/docs/release-control/v6/internal/subsystems/storage-recovery.md
+++ b/docs/release-control/v6/internal/subsystems/storage-recovery.md
@@ -21,6 +21,32 @@
## Purpose
+### Selected PBS datastore remains inspectable without hover
+
+The existing PBS row disclosure is named by backup reader and datastore, rather
+than giving every store on one server the same control label. Single-line scan
+cells and responsive widths are unchanged. Its open detail presents the full,
+wrapping reader/store identities and admitted capacity bytes/percentage and
+inventory count, including when those columns are hidden or truncated. The
+shared platform detail row accepts optional row context inside the same native
+inline shell; this does not replace the canonical resource or its History target.
+
+Loading and unavailable inventory remain nonnumeric; accepted empty inventory
+is zero. Unavailable/unknown capacity never becomes zero, even with a Healthy
+connection. A server without datastore data has neither a made-up store nor a
+count. Counts describe loaded entries, including in-progress/unverified entries,
+not backup protection. These independent evidence meanings, correlation, read
+cadence, retry, API, auth and protection policy are unchanged.
+
+Normal-suite `backupServerDatastoreAccess.test.tsx` exercises long namesakes,
+responsive projections, parsed inventory loading/failure/retry/polling, capacity
+admission, no-store data, live reordering and retained detail/focus. The registered
+`ProxmoxBackupsTable.test.tsx` verifies the selected consumer; shared detail-row
+and platform-layout tests preserve the separate context/host owners. Browser
+proof exercises actual keyboard/touch disclosure, open-record refresh and
+complete wrapping identifiers at desktop/narrow widths with pixel inspection.
+This is safer evidence inspection, not original guest or installed recovery.
+
### Backup-server read states remain legible at intermediate widths
The existing PBS server table reserves enough count-column width for the full
diff --git a/docs/release-control/v6/internal/subsystems/unified-resources.md b/docs/release-control/v6/internal/subsystems/unified-resources.md
index cff99d07d2..bf2992cef9 100644
--- a/docs/release-control/v6/internal/subsystems/unified-resources.md
+++ b/docs/release-control/v6/internal/subsystems/unified-resources.md
@@ -23,6 +23,32 @@ and sort the complete canonical change table while startup and ingestion wait.
## Purpose
+### Selected PBS datastore remains inspectable without hover
+
+The existing PBS row disclosure is named by backup reader and datastore, rather
+than giving every store on one server the same control label. Single-line scan
+cells and responsive widths are unchanged. Its open detail presents the full,
+wrapping reader/store identities and admitted capacity bytes/percentage and
+inventory count, including when those columns are hidden or truncated. The
+shared platform detail row accepts optional row context inside the same native
+inline shell; this does not replace the canonical resource or its History target.
+
+Loading and unavailable inventory remain nonnumeric; accepted empty inventory
+is zero. Unavailable/unknown capacity never becomes zero, even with a Healthy
+connection. A server without datastore data has neither a made-up store nor a
+count. Counts describe loaded entries, including in-progress/unverified entries,
+not backup protection. These independent evidence meanings, correlation, read
+cadence, retry, API, auth and protection policy are unchanged.
+
+Normal-suite `backupServerDatastoreAccess.test.tsx` exercises long namesakes,
+responsive projections, parsed inventory loading/failure/retry/polling, capacity
+admission, no-store data, live reordering and retained detail/focus. The registered
+`ProxmoxBackupsTable.test.tsx` verifies the selected consumer; shared detail-row
+and platform-layout tests preserve the separate context/host owners. Browser
+proof exercises actual keyboard/touch disclosure, open-record refresh and
+complete wrapping identifiers at desktop/narrow widths with pixel inspection.
+This is safer evidence inspection, not original guest or installed recovery.
+
### Backup-server read states remain legible at intermediate widths
The existing PBS server table reserves enough count-column width for the full
diff --git a/frontend-modern/src/features/platformPage/PlatformResourceDetailTableRow.tsx b/frontend-modern/src/features/platformPage/PlatformResourceDetailTableRow.tsx
index 1fb2760f36..f90dc960f5 100644
--- a/frontend-modern/src/features/platformPage/PlatformResourceDetailTableRow.tsx
+++ b/frontend-modern/src/features/platformPage/PlatformResourceDetailTableRow.tsx
@@ -121,6 +121,8 @@ export const PlatformResourceDetailTableRow: Component<{
resolveResourceLabel?: (resourceId: string) => string | null | undefined;
initialShowAccessContext?: boolean;
initialShowHostDetails?: boolean;
+ /** Row-specific evidence, separate from the canonical host/resource inspector. */
+ context?: JSX.Element;
onResourceActionSettled?: () => void | Promise<void>;
onClose?: () => void;
}> = (props) => {
@@ -132,6 +134,7 @@ export const PlatformResourceDetailTableRow: Component<{
data-inline-detail-for={props.resource.id}
data-inline-platform-resource-detail-for={props.resource.id}
>
+ {props.context}
<ResourceDetailDrawer
resource={props.resource}
statusIndicator={props.statusIndicator}
diff --git a/frontend-modern/src/features/platformPage/__tests__/PlatformResourceDetailTableRow.test.tsx b/frontend-modern/src/features/platformPage/__tests__/PlatformResourceDetailTableRow.test.tsx
index 5ab3a28d62..6f19a9df77 100644
--- a/frontend-modern/src/features/platformPage/__tests__/PlatformResourceDetailTableRow.test.tsx
+++ b/frontend-modern/src/features/platformPage/__tests__/PlatformResourceDetailTableRow.test.tsx
@@ -1,15 +1,72 @@
import { cleanup, fireEvent, render, screen } from '@solidjs/testing-library';
import { afterEach, describe, expect, it, vi } from 'vitest';
+import { createSignal } from 'solid-js';
+import type { Resource } from '@/types/resource';
import { TableCell, TableRow } from '@/components/shared/Table';
import {
PlatformResourceDetailToggleButton,
+ PlatformResourceDetailTableRow,
createPlatformResourceDetailState,
getPlatformResourceDetailRowClass,
getPlatformResourceDetailRowInteractionProps,
} from '../PlatformResourceDetailTableRow';
+vi.mock('@/components/Infrastructure/ResourceDetailDrawer', () => ({
+ ResourceDetailDrawer: (props: { resource: Resource }) => (
+ <div data-testid="canonical-resource-inspector">{props.resource.id}</div>
+ ),
+}));
+
afterEach(cleanup);
+describe('platform resource row context', () => {
+ it('mounts row-specific context only inside an open detail without changing the canonical resource', () => {
+ const [open, setOpen] = createSignal(false);
+ render(() => (
+ <table>
+ <tbody>
+ <PlatformResourceDetailTableRow
+ resource={{ id: 'canonical-host' } as Resource}
+ open={open()}
+ detailRowId="selected-row"
+ colSpan={4}
+ context={
+ <section aria-label="Selected row">Selected datastore, not a host identity</section>
+ }
+ />
+ </tbody>
+ </table>
+ ));
+ expect(screen.queryByRole('region')).toBeNull();
+ expect(screen.queryByTestId('canonical-resource-inspector')).toBeNull();
+ setOpen(true);
+ expect(screen.getByRole('region', { name: 'Selected row' })).toHaveTextContent(
+ 'Selected datastore',
+ );
+ expect(document.getElementById('selected-row')).toContainElement(screen.getByRole('region'));
+ expect(screen.getByTestId('canonical-resource-inspector')).toHaveTextContent('canonical-host');
+ setOpen(false);
+ expect(screen.queryByRole('region')).toBeNull();
+ });
+
+ it('leaves context-free inspectors unchanged', () => {
+ render(() => (
+ <table>
+ <tbody>
+ <PlatformResourceDetailTableRow
+ resource={{ id: 'ordinary-host' } as Resource}
+ open
+ detailRowId="ordinary-row"
+ colSpan={4}
+ />
+ </tbody>
+ </table>
+ ));
+ expect(screen.queryByRole('region')).toBeNull();
+ expect(screen.getByTestId('canonical-resource-inspector')).toHaveTextContent('ordinary-host');
+ });
+});
+
describe('getPlatformResourceDetailRowInteractionProps', () => {
const renderRow = (onToggle = vi.fn()) => {
render(() => (
diff --git a/frontend-modern/src/features/platformPage/__tests__/platformOverviewLayout.guardrails.test.ts b/frontend-modern/src/features/platformPage/__tests__/platformOverviewLayout.guardrails.test.ts
index d70c81d078..7c304ce3af 100644
--- a/frontend-modern/src/features/platformPage/__tests__/platformOverviewLayout.guardrails.test.ts
+++ b/frontend-modern/src/features/platformPage/__tests__/platformOverviewLayout.guardrails.test.ts
@@ -39,6 +39,7 @@ import kubernetesStorageTableSource from '@/features/kubernetes/KubernetesStorag
// current table owners.
import proxmoxBackupsTableSource from '@/features/proxmox/ProxmoxBackupsTable.tsx?raw';
import proxmoxBackupServersTableSource from '@/features/proxmox/ProxmoxBackupServersTable.tsx?raw';
+import platformResourceDetailRowSource from '@/features/platformPage/PlatformResourceDetailTableRow.tsx?raw';
import proxmoxCoverageTableSource from '@/features/proxmox/ProxmoxCoverageTable.tsx?raw';
import proxmoxRecoverableTableSource from '@/features/proxmox/ProxmoxRecoverableTable.tsx?raw';
import proxmoxCephClusterDrawerSource from '@/features/proxmox/ProxmoxCephClusterDrawer.tsx?raw';
@@ -256,6 +257,23 @@ function enclosingTab(tag: ts.Node): string | undefined {
}
describe('platform overview layout guardrails', () => {
+ it('keeps selected datastore context outside the canonical host inspector', () => {
+ const resourceRow = proxmoxBackupServersTableSource.match(
+ /<PlatformResourceDetailTableRow\b[\s\S]*?\n\s*\/>/,
+ )?.[0];
+ expect(resourceRow).toContain('resource={row.resource}');
+ expect(resourceRow).toContain('<BackupServerDatastoreContext');
+ expect(resourceRow).not.toMatch(/resource=\{\{[\s\S]*?datastore/);
+ const contextAt = platformResourceDetailRowSource.indexOf('{props.context}');
+ const inspectorAt = platformResourceDetailRowSource.indexOf('<ResourceDetailDrawer');
+ expect(contextAt).toBeGreaterThan(-1);
+ expect(inspectorAt).toBeGreaterThan(contextAt);
+ // A store is row evidence, never another canonical resource/History target.
+ expect(platformResourceDetailRowSource.slice(inspectorAt)).not.toContain('props.context');
+ expect(platformResourceDetailRowSource.slice(inspectorAt)).toContain(
+ 'resource={props.resource}',
+ );
+ });
it('keeps attention summaries canonical without a competing estate panel', () => {
for (const source of [truenasProtectionTableSource, vsphereAlertsTableSource]) {
expect(source).toContain('withPlatformStatusCounts');
diff --git a/frontend-modern/src/features/proxmox/ProxmoxBackupServersTable.tsx b/frontend-modern/src/features/proxmox/ProxmoxBackupServersTable.tsx
index 6b4a4c027e..1e4788fe7a 100644
--- a/frontend-modern/src/features/proxmox/ProxmoxBackupServersTable.tsx
+++ b/frontend-modern/src/features/proxmox/ProxmoxBackupServersTable.tsx
@@ -4,6 +4,7 @@ import { unwrap } from 'solid-js/store';
import { StatusDot } from '@/components/shared/StatusDot';
import { ResourceNameWithWebInterfaceLink } from '@/components/shared/WebInterfaceLink';
import { TableCell, TableHead, TableRow } from '@/components/shared/Table';
+import { DetailSectionTable, type DetailValueTone } from '@/components/shared/DetailSectionTable';
import {
formatPlatformTableBytesValue,
formatPlatformTableIntegerValue,
@@ -151,6 +152,74 @@ function usageToneClass(pct: number | undefined): string {
return 'text-base-content';
}
+// A server can have several identically prefixed datastore names. The compact
+// scan keeps its single-line cells, but hover titles are not an inspection path
+// on a phone. Keep the selected store's full identity and admitted readings in
+// its existing disclosure, without changing the host inspector's identity.
+function BackupServerDatastoreContext(props: {
+ row: BackupServerRow;
+ inventoryState?: 'available' | 'loading' | 'unavailable';
+}) {
+ const capacity = () => datastoreCapacity(props.row.datastore, props.row.online);
+ const capacityText = () => {
+ const datastore = props.row.datastore;
+ if (!datastore) return 'No datastore data';
+ const reading = capacity();
+ if (reading.state !== 'available') {
+ return `${reading.state === 'unavailable' ? 'Unavailable' : 'Unknown'}. This does not mean the datastore is empty.`;
+ }
+ return `${formatPlatformTablePercentValue(reading.percent)} used · ${formatPlatformTableBytesValue(datastore.used, '0 B')} / ${formatPlatformTableBytesValue(datastore.total)}`;
+ };
+ const inventoryText = () => {
+ if (!props.row.datastore) return 'Not reported';
+ if (props.inventoryState === 'loading') return 'Loading';
+ if (props.inventoryState === 'unavailable') return 'Unavailable';
+ return formatPlatformTableIntegerValue(props.row.backupCount);
+ };
+ const capacityTone = (): DetailValueTone | undefined => {
+ const reading = capacity();
+ if (reading.state === 'unavailable' || reading.state === 'unknown') return 'warning';
+ if (reading.percent !== undefined && reading.percent >= 90) return 'danger';
+ if (reading.percent !== undefined && reading.percent >= 75) return 'warning';
+ return undefined;
+ };
+
+ return (
+ <section class="mb-3" aria-label="Selected PBS datastore">
+ <DetailSectionTable
+ wrapValues
+ sections={[
+ {
+ label: 'Selected datastore',
+ rows: [
+ { label: 'Backup reader', value: props.row.serverName, layout: 'stacked' },
+ {
+ label: 'Datastore',
+ value: props.row.datastore?.name ?? 'Not reported',
+ layout: 'stacked',
+ },
+ {
+ label: 'Capacity',
+ value: capacityText(),
+ layout: 'stacked',
+ tone: capacityTone(),
+ },
+ { label: 'Backup entries', value: inventoryText(), layout: 'stacked' },
+ ],
+ footerContent: (
+ <p class="text-[11px] leading-snug text-muted">
+ Counts describe the loaded inventory, which can include in-progress and unverified
+ entries. They do not establish backup protection. Connection health and datastore
+ capacity are separate readings.
+ </p>
+ ),
+ },
+ ]}
+ />
+ </section>
+ );
+}
+
// Only the hostname PBS reports about itself can corroborate a host without
// a backend link. Connection labels, instance IDs, canonical presentation
// fields and configured endpoints are not machine identity. In particular,
@@ -582,7 +651,11 @@ export function ProxmoxBackupServersTable(props: {
<div class="flex min-w-0 items-center gap-1">
<PlatformResourceDetailToggleButton
expanded={isExpanded()}
- resourceLabel={row.serverName}
+ resourceLabel={
+ row.datastore
+ ? `${row.serverName} · datastore ${row.datastore.name}`
+ : row.serverName
+ }
controlsId={detailRowId()}
onToggle={() => detail.toggle(rowIdentity)}
/>
@@ -815,6 +888,12 @@ export function ProxmoxBackupServersTable(props: {
open={isExpanded()}
detailRowId={detailRowId()}
colSpan={visibleColumns().length}
+ context={
+ <BackupServerDatastoreContext
+ row={row}
+ inventoryState={props.backupInventoryState}
+ />
+ }
initialShowHostDetails
onClose={() => detail.close(rowIdentity)}
/>
diff --git a/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx b/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx
index 6258f808ad..ddc3ad8f93 100644
--- a/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx
+++ b/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx
@@ -400,6 +400,19 @@ describe('ProxmoxBackupsTable', () => {
expect(cellText(0, 'datastore')).toBe('main');
expect(cellText(1, 'datastore')).toBe('offsite');
expect(cellText(1, 'used')).toContain('25');
+ const offsite = within(table).getByRole('button', {
+ name: 'Expand details for pbs-main · datastore offsite',
+ });
+ expect(
+ within(table).getByRole('button', {
+ name: 'Expand details for pbs-main · datastore main',
+ }),
+ ).not.toBe(offsite);
+ fireEvent.click(offsite);
+ const selected = screen.getByRole('region', { name: 'Selected PBS datastore' });
+ expect(within(selected).getByText('Datastore').closest('tr')).toHaveTextContent('offsite');
+ expect(within(selected).getByText('Backup reader').closest('tr')).toHaveTextContent('pbs-main');
+ expect(within(selected).getByText('Capacity').closest('tr')).toHaveTextContent('25.0%');
});
it('uses a corroborated PBS host link for Backups History despite a PVE-only name collision', () => {
diff --git a/frontend-modern/src/features/proxmox/__tests__/backupServerDatastoreAccess.test.tsx b/frontend-modern/src/features/proxmox/__tests__/backupServerDatastoreAccess.test.tsx
new file mode 100644
index 0000000000..b8727468e9
--- /dev/null
+++ b/frontend-modern/src/features/proxmox/__tests__/backupServerDatastoreAccess.test.tsx
@@ -0,0 +1,205 @@
+import { cleanup, fireEvent, render, screen, waitFor, within } from '@solidjs/testing-library';
+import { Route, Router } from '@solidjs/router';
+import { createSignal, type JSX } from 'solid-js';
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
+import { ProxmoxBackupServersTable } from '../ProxmoxBackupServersTable';
+import { ProxmoxBackupsTable } from '../ProxmoxBackupsTable';
+import type { Resource, ResourcePBSDatastore } from '@/types/resource';
+import { resetCreateNonSuspendingQueryCacheForTest } from '@/hooks/createNonSuspendingQuery';
+import { protectionPolicy } from '@/utils/__fixtures__/protectionPosture';
+
+const api = vi.hoisted(() => ({ fetch: vi.fn(), json: vi.fn() }));
+vi.mock('@/utils/apiClient', () => ({ apiFetch: api.fetch, apiFetchJSON: api.json }));
+
+const reader = 'backup-reader-with-a-long-shared-prefix-east';
+const store = 'production-archives-with-a-long-shared-prefix-east';
+const otherStore = 'production-archives-with-a-long-shared-prefix-west';
+const datastore: ResourcePBSDatastore = {
+ name: store,
+ total: 1000,
+ used: 980,
+ available: 20,
+ status: 'available',
+};
+const server = (datastores: ResourcePBSDatastore[] = [datastore]): Resource => ({
+ id: 'pbs-east',
+ name: reader,
+ displayName: reader,
+ type: 'pbs',
+ status: 'online',
+ sourceType: 'api',
+ platformType: 'proxmox-pbs',
+ platformId: 'pbs-east',
+ lastSeen: Date.parse('2026-10-30T19:00:00Z'),
+ pbs: { instanceId: 'service-pbs-east', connectionHealth: 'healthy', datastores },
+});
+const mount = (component: () => JSX.Element) =>
+ render(() => (
+ <Router>
+ <Route path="/*" component={component} />
+ </Router>
+ ));
+const selected = () => screen.getByRole('region', { name: 'Selected PBS datastore' });
+const field = (name: string) => within(selected()).getByText(name).closest('tr')!;
+const disclosure = (name = store) =>
+ screen.getByRole('button', {
+ name: `Expand details for ${reader} · datastore ${name}`,
+ });
+const json = (data: unknown, status = 200) =>
+ new Response(JSON.stringify(data), {
+ status,
+ headers: { 'Content-Type': 'application/json' },
+ });
+
+beforeEach(() => {
+ resetCreateNonSuspendingQueryCacheForTest();
+ window.history.replaceState({}, '', '/proxmox/backups/date');
+ api.json.mockResolvedValue({ data: [], policy: protectionPolicy });
+ api.fetch.mockImplementation(async () => json({}));
+});
+afterEach(() => {
+ cleanup();
+ resetCreateNonSuspendingQueryCacheForTest();
+ vi.useRealTimers();
+ vi.resetAllMocks();
+});
+
+describe('selected PBS datastore inspection', () => {
+ it.each([320, 600, 1440])(
+ 'exposes the selected datastore without relying on hover at %ipx',
+ async (width) => {
+ mount(() => (
+ <ProxmoxBackupServersTable
+ servers={[server([datastore, { ...datastore, name: otherStore, used: 0 }])]}
+ layoutWidth={() => width}
+ />
+ ));
+ const east = await screen.findByRole('button', {
+ name: `Expand details for ${reader} · datastore ${store}`,
+ });
+ expect(east).not.toBe(disclosure(otherStore));
+ fireEvent.click(east);
+ expect(field('Backup reader')).toHaveTextContent(reader);
+ expect(field('Datastore')).toHaveTextContent(store);
+ expect(field('Datastore')).not.toHaveTextContent(otherStore);
+ expect(field('Capacity')).toHaveTextContent('98.0% used · 980 B / 1000 B');
+ expect(field('Backup entries')).toHaveTextContent('0');
+ expect(selected()).toHaveTextContent('They do not establish backup protection.');
+ expect(document.getElementById(east.getAttribute('aria-controls')!)).toContainElement(
+ selected(),
+ );
+ fireEvent.click(disclosure(otherStore));
+ expect(screen.getAllByRole('region', { name: 'Selected PBS datastore' })).toHaveLength(1);
+ expect(field('Datastore')).toHaveTextContent(otherStore);
+ expect(field('Capacity')).toHaveTextContent('0.0% used · 0 B / 1000 B');
+ },
+ );
+
+ it.each([
+ ['unavailable', { ...datastore, used: 0, total: 0, status: 'unavailable' }, 'Unavailable'],
+ ['unrecognised', { ...datastore, used: 0, status: 'unknown' }, 'Unknown'],
+ ['invalid', { ...datastore, total: 0 }, 'Unknown'],
+ ] as const)(
+ 'keeps %s capacity independent from a healthy connection and a genuine zero count',
+ async (_name, data, label) => {
+ mount(() => <ProxmoxBackupServersTable servers={[server([data])]} layoutWidth={() => 320} />);
+ fireEvent.click(await screen.findByRole('button', { name: /Expand details for/ }));
+ expect(field('Capacity')).toHaveTextContent(
+ `${label}. This does not mean the datastore is empty.`,
+ );
+ expect(field('Capacity')).not.toHaveTextContent('0.0%');
+ expect(field('Capacity')).not.toHaveTextContent('0 B');
+ expect(field('Backup entries')).toHaveTextContent('0');
+ expect(screen.getAllByText('Healthy').length).toBeGreaterThan(0);
+ },
+ );
+
+ it('does not invent a selected store or count when no datastore was reported', async () => {
+ mount(() => <ProxmoxBackupServersTable servers={[server([])]} layoutWidth={() => 320} />);
+ fireEvent.click(await screen.findByRole('button', { name: `Expand details for ${reader}` }));
+ expect(field('Datastore')).toHaveTextContent('Not reported');
+ expect(field('Capacity')).toHaveTextContent('No datastore data');
+ expect(field('Backup entries')).toHaveTextContent('Not reported');
+ });
+
+ it('keeps the open datastore and its DOM while live stores reorder and its capacity becomes unavailable', async () => {
+ const [servers, setServers] = createSignal([
+ server([datastore, { ...datastore, name: otherStore }]),
+ ]);
+ mount(() => <ProxmoxBackupServersTable servers={servers()} layoutWidth={() => 320} />);
+ const toggle = await screen.findByRole('button', { name: /Expand details.*datastore.*east$/ });
+ fireEvent.click(toggle);
+ toggle.focus();
+ const context = selected();
+ setServers([
+ server([
+ { ...datastore, name: 'a-new-store' },
+ { ...datastore, name: otherStore },
+ { ...datastore, used: 0, total: 0, status: 'unavailable' },
+ ]),
+ ]);
+ await waitFor(() => expect(field('Capacity')).toHaveTextContent('Unavailable.'));
+ expect(selected()).toBe(context);
+ expect(field('Datastore')).toHaveTextContent(store);
+ expect(toggle).toHaveFocus();
+ const detail = document.getElementById(toggle.getAttribute('aria-controls')!)!;
+ const close = within(detail).getByRole('button', { name: /Collapse .* details/ });
+ close.focus();
+ fireEvent.click(close);
+ await waitFor(() => expect(toggle).toHaveFocus());
+ expect(screen.queryByRole('region', { name: 'Selected PBS datastore' })).toBeNull();
+ });
+
+ it('consumes real inventory read states, retries and poll counts inside the same open datastore', async () => {
+ vi.useFakeTimers({ toFake: ['setInterval', 'clearInterval'] });
+ let resolvePBS!: (response: Response) => void;
+ let pbs = new Promise<Response>((resolve) => {
+ resolvePBS = resolve;
+ });
+ api.fetch.mockImplementation(async (url: string) =>
+ url.endsWith('/pbs')
+ ? pbs
+ : json({ data: { backupTasks: [], storageBackups: [], guestSnapshots: [] } }),
+ );
+ const mounted = mount(() => <ProxmoxBackupsTable emptyIcon={<span />} servers={[server()]} />);
+ fireEvent.click(await screen.findByRole('button', { name: /Expand details.*datastore/ }));
+ const context = selected();
+ expect(field('Backup entries')).toHaveTextContent('Loading');
+ expect(field('Capacity')).toHaveTextContent('98.0%');
+ resolvePBS(json({}, 403));
+ await waitFor(() => expect(field('Backup entries')).toHaveTextContent('Unavailable'));
+ pbs = Promise.resolve(json({ data: { backups: [] } }));
+ fireEvent.click(screen.getByRole('button', { name: 'Retry PBS inventory' }));
+ await waitFor(() => expect(field('Backup entries')).toHaveTextContent('0'));
+ const entry = {
+ id: 'east-1',
+ instance: reader,
+ datastore: store,
+ vmid: '101',
+ backupType: 'vm',
+ backupTime: '2026-10-30T18:00:00Z',
+ verified: false,
+ inProgress: true,
+ };
+ pbs = Promise.resolve(
+ json({
+ data: {
+ backups: [
+ entry,
+ { ...entry, id: 'east-2', inProgress: false },
+ { ...entry, id: 'west-1', datastore: otherStore },
+ ],
+ },
+ }),
+ );
+ await vi.advanceTimersByTimeAsync(30_000);
+ await waitFor(() => expect(field('Backup entries')).toHaveTextContent('2'));
+ expect(selected()).toBe(context);
+ expect(field('Datastore')).toHaveTextContent(store);
+ expect(api.fetch.mock.calls.filter(([url]) => url === '/api/backups/pbs')).toHaveLength(3);
+ const calls = api.fetch.mock.calls.length;
+ mounted.unmount();
+ await vi.advanceTimersByTimeAsync(60_000);
+ expect(api.fetch).toHaveBeenCalledTimes(calls);
+ });
+});