Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Keep Settings actions visible and browser fixtures isolated

pulse-triage[bot]bb903ef7d679
diff --git a/frontend-modern/src/components/shared/SettingsPanel.tsx b/frontend-modern/src/components/shared/SettingsPanel.tsx
index d1edba2b90..8eb3969c64 100644
--- a/frontend-modern/src/components/shared/SettingsPanel.tsx
+++ b/frontend-modern/src/components/shared/SettingsPanel.tsx
@@ -36,8 +36,8 @@ export function SettingsPanel(props: SettingsPanelProps) {
{...rest}
>
<div class="border-b border-border bg-surface-alt px-2.5 py-2 sm:px-6 sm:py-4">
- <div class="flex items-start gap-2 sm:items-center sm:gap-3">
- <div class="flex min-w-0 flex-1 flex-col gap-0.5 sm:gap-1">
+ <div class="flex flex-wrap items-start gap-2 sm:items-center sm:gap-3">
+ <div class="flex min-w-0 flex-1 basis-40 flex-col gap-0.5 sm:gap-1">
<h2
id={local.titleId}
class="text-[11px] font-semibold uppercase tracking-wide text-base-content dark:text-slate-100 sm:text-base sm:normal-case sm:tracking-tight"
@@ -51,7 +51,7 @@ export function SettingsPanel(props: SettingsPanelProps) {
</Show>
</div>
<Show when={local.action}>
- <div class="w-auto shrink-0">{local.action}</div>
+ <div class="w-auto min-w-0 max-w-full shrink-0">{local.action}</div>
</Show>
</div>
</div>
diff --git a/tests/integration/tests/05-settings-mobile-audit.spec.ts b/tests/integration/tests/05-settings-mobile-audit.spec.ts
index 3bbad9d056..4adc5f996d 100644
--- a/tests/integration/tests/05-settings-mobile-audit.spec.ts
+++ b/tests/integration/tests/05-settings-mobile-audit.spec.ts
@@ -249,6 +249,31 @@ test.describe("Settings mobile optimization audit", () => {
}
await expect(page.locator("[data-settings-content]")).toBeVisible();
+ if (route === "/settings/security-audit") {
+ const panel = page.locator("[data-settings-panel]").filter({
+ has: page.getByRole("heading", { name: "Audit Log", exact: true }),
+ });
+ await expect(panel).toBeVisible();
+ // Root scrollWidth misses content clipped by overflow-hidden.
+ // Check the actual title and every toolbar control before scroll.
+ const clippedOrOverlapping = await panel.evaluate((element) => {
+ const header = element.firstElementChild!;
+ const bounds = header.getBoundingClientRect();
+ const title = header.querySelector("h2")!;
+ const titleBounds = title.getBoundingClientRect();
+ return [title, ...header.querySelectorAll("button")].flatMap((item) => {
+ const rect = item.getBoundingClientRect();
+ const clipped = rect.width < 1 || rect.left < bounds.left - 1 ||
+ rect.right > bounds.right + 1 || rect.top < bounds.top - 1 ||
+ rect.bottom > bounds.bottom + 1;
+ const overlapsTitle = item !== title && rect.left < titleBounds.right &&
+ rect.right > titleBounds.left && rect.top < titleBounds.bottom &&
+ rect.bottom > titleBounds.top;
+ return clipped || overlapsTitle ? [item.textContent?.trim()] : [];
+ });
+ });
+ expect(clippedOrOverlapping, `Audit header at ${viewport.width}px`).toEqual([]);
+ }
await scrollSettingsToBottom(page);
const position = await settingsScrollPosition(page);
const atBottom = position.scrollTop >= position.maxScrollTop - 3;
diff --git a/tests/integration/tests/11-first-session.spec.ts b/tests/integration/tests/11-first-session.spec.ts
index 89c1b0b7c1..429530b8ac 100644
--- a/tests/integration/tests/11-first-session.spec.ts
+++ b/tests/integration/tests/11-first-session.spec.ts
@@ -1,6 +1,7 @@
import { test, expect } from "@playwright/test";
import {
ensureAuthenticated,
+ ensureSessionAuthenticated,
ensureFirstRunExperience,
navigateToSettings,
apiRequest,
@@ -161,7 +162,10 @@ test.describe.serial("First-session experience", () => {
"Desktop-only first-session coverage",
);
- await ensureAuthenticated(page);
+ // Settings bootstrap includes session-preferred organisation reads. Use
+ // the actual browser session, not the token-only helper's intentional
+ // unauthenticated probe followed by a token retry.
+ await ensureSessionAuthenticated(page);
await page.waitForLoadState("domcontentloaded");
await page.waitForTimeout(750);
@@ -190,6 +194,11 @@ test.describe.serial("First-session experience", () => {
try {
for (const route of keyRoutes) {
+ // Retire the previous document before measuring this route. A
+ // departing infrastructure row may still start its anomaly read;
+ // that is not a Settings bootstrap request. Do not exempt anomalies
+ // from the assertion or miss this document's early requests.
+ await page.goto("about:blank");
consoleErrors.length = 0;
aiRequests.clear();
@@ -211,7 +220,14 @@ test.describe.serial("First-session experience", () => {
`Route ${route} did not render any panel content`,
).toBeVisible({ timeout: 10_000 });
- await page.waitForTimeout(500);
+ // The outer page heading is present even while General remains on
+ // "Loading configuration...". Require the consuming panel, not just
+ // the Settings shell, before judging requests and console output.
+ await expect(
+ page.locator("[data-settings-content] [data-settings-panel]").first(),
+ `Route ${route} did not finish loading a settings panel`,
+ ).toBeVisible({ timeout: 10_000 });
+ await expect(page.getByText("Loading configuration...", { exact: true })).toHaveCount(0);
const unexpectedAIRequests = aiRequests
.urls()
diff --git a/tests/integration/tests/91-operational-trust-attention-workbench.spec.ts b/tests/integration/tests/91-operational-trust-attention-workbench.spec.ts
index 18258dba88..6e56057f03 100644
--- a/tests/integration/tests/91-operational-trust-attention-workbench.spec.ts
+++ b/tests/integration/tests/91-operational-trust-attention-workbench.spec.ts
@@ -367,7 +367,10 @@ async function mockAttention(
await page.route("**/api/resources**", async (route) => {
const url = new URL(route.request().url());
if (url.pathname !== "/api/resources") {
- await route.continue();
+ // Resource detail reads belong to this isolated fixture too. Continue
+ // skips the earlier API fallback and leaks the synthetic token to the
+ // real backend, whose correct 401 response then sends the UI to login.
+ await route.fallback();
return;
}
await route.fulfill({