Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Keep per-disk bars on wide host rows

rcourtmanc2f83fe31dd0
diff --git a/docs/release-control/v6/internal/subsystems/performance-and-scalability.md b/docs/release-control/v6/internal/subsystems/performance-and-scalability.md
index 86ffe5911e..3ea1994e45 100644
--- a/docs/release-control/v6/internal/subsystems/performance-and-scalability.md
+++ b/docs/release-control/v6/internal/subsystems/performance-and-scalability.md
@@ -3423,15 +3423,16 @@ resize-observer plus tooltip lifecycle live in
`frontend-modern/src/components/Workloads/useStackedDiskBarState.ts`.
Future disk-bar runtime changes must extend through those owners instead of
reintroducing mixed resize state and presentation branching into the shell.
-Proxmox nodes, Machines, and Docker hosts with more than one agent-reported
-disk render the `aggregate` mode with `summaryStrategy="max"`: the same
-horizontal bar a single-disk host gets, sized and coloured by the fullest
-disk and labelled with its percentage plus `max`, so every row in a host
-Disk column reads in one shape and compares down the column. The label names
-no disk in the row; the mount and the per-disk breakdown stay in the title
-and tooltip. The `vertical-bars` mode (one equal-weight micro-bar per disk,
-labelled with the fullest disk's percentage) is no longer used by those
-tables; mixing it with single-disk bars gave one column three shapes.
+The multi-disk `vertical-bars` mode (Proxmox nodes, Machines, and Docker
+hosts with more than one agent-reported disk) draws one equal-weight micro-bar
+per disk and labels the cell with the fullest disk's usage percentage, derived
+in the model from the existing max-disk summary, so a multi-disk host answers
+"how close is this host to running out of space?" at a glance in Bars mode
+instead of only on hover or in Trends mode. The label names no disk in the
+row; the mount and the per-disk breakdown stay in the title and tooltip.
+A compact Proxmox node cell has no room for the micro-bars and draws the
+`aggregate` bar with `summaryStrategy="max"`, sized and coloured by the
+fullest measured disk, so a nearly full disk is not averaged away on a phone.
The dashboard stacked memory bar now follows that same pattern: the shell
stays in `frontend-modern/src/components/Workloads/StackedMemoryBar.tsx`,
while memory-capacity math, balloon/swap tooltip derivation, anomaly label
diff --git a/docs/release-control/v6/internal/subsystems/unified-resources.md b/docs/release-control/v6/internal/subsystems/unified-resources.md
index 6320124007..d33fba0929 100644
--- a/docs/release-control/v6/internal/subsystems/unified-resources.md
+++ b/docs/release-control/v6/internal/subsystems/unified-resources.md
@@ -23,21 +23,20 @@ and sort the complete canonical change table while startup and ingestion wait.
## Purpose
-### Host Disk columns draw one bar shape (2 November 2026)
-
-Proxmox node, Docker host and Machines tables render a host with more than one
-agent-reported disk through `StackedDiskBar` `mode="aggregate"` with
-`summaryStrategy="max"`: the single horizontal bar a one-disk host gets, sized
-and coloured by the fullest measured disk and labelled `NN% max` when the cell
-is wide enough, so a Disk column reads in one shape down its rows. The
-`vertical-bars` micro-bars are no longer used by these tables. The max summary
-holds while any reported disk is unmeasured, so a full disk is not hidden
-behind a low aggregate. The Proxmox node row's alert accent reads the node's
-own alerts through `getUnifiedResourceAlertStyles`, like the other host
-tables, and no longer tints for a guest's alert. `DockerHostsTable.test.tsx`,
-`AgentsMachinesTable.test.tsx` and `ProxmoxNodesTable.test.tsx` cover the
-rendered shape and the accent. No resource identity, projection or metric
-change.
+### Compact Proxmox node Disk cells show the fullest disk (2 November 2026)
+
+A compact Proxmox node row (phone width or compact metrics) has no room for
+the per-disk `vertical-bars` micro-bars, so a node with more than one
+agent-reported disk draws the `StackedDiskBar` `aggregate` bar. It used the
+average across disks, which hid a nearly full disk behind a half-empty one;
+it now passes `summaryStrategy="max"` and is sized and coloured by the
+fullest measured disk, and the max summary holds while any reported disk is
+unmeasured. Wide rows keep one micro-bar per disk, and Machines and Docker
+host tables are unchanged. The Proxmox node row's alert accent reads the
+node's own alerts through `getUnifiedResourceAlertStyles`, like the other
+host tables, and no longer tints for a guest's alert. `StackedDiskBar.test.tsx`
+covers the compact summary and `ProxmoxNodesTable.test.tsx` the accent. No
+resource identity, projection or metric change.
### Backup views share bounded owned-focus restoration
diff --git a/frontend-modern/browser-verification/b7208e3832e59726.json b/frontend-modern/browser-verification/b7208e3832e59726.json
new file mode 100644
index 0000000000..2df25f3027
--- /dev/null
+++ b/frontend-modern/browser-verification/b7208e3832e59726.json
@@ -0,0 +1,44 @@
+{
+ "version": 1,
+ "base_sha": "d07461dbbf5bd7f4306ece1dd6f760d3576f1683",
+ "verified_at": "2026-11-02T10:14:06Z",
+ "result": "passed",
+ "changed_paths": [
+ "frontend-modern/src/features/docker/DockerHostsTable.tsx",
+ "frontend-modern/src/features/proxmox/ProxmoxNodesTable.tsx",
+ "frontend-modern/src/features/standalone/AgentsMachinesTable.tsx"
+ ],
+ "content_sha256": {
+ "frontend-modern/src/features/docker/DockerHostsTable.tsx": "e6b82c648c0a9dc4154d58fdd2fe99e43f033e7c163c62557d855a33428d16dc",
+ "frontend-modern/src/features/proxmox/ProxmoxNodesTable.tsx": "5c60e8e33037546475f2faa4b529627f39251aa26acf29c8e56bd33caad19cf6",
+ "frontend-modern/src/features/standalone/AgentsMachinesTable.tsx": "c75ba11cbb2c665b6d2fafa618bd3fc53cce71b3d241a4d7af1dd2d580073d8f"
+ },
+ "routes": [
+ "/proxmox/overview",
+ "/standalone/machines",
+ "/docker/overview"
+ ],
+ "viewports": [
+ {
+ "width": 1440,
+ "height": 1000
+ },
+ {
+ "width": 390,
+ "height": 844
+ }
+ ],
+ "states": [
+ "production vite build of this change served by vite preview on pulse-dev against a mock backend built from origin/main (4 Proxmox nodes, 3 machines, 2 Docker hosts, dark theme)",
+ "multi-disk Proxmox nodes and machines, single-disk Proxmox node and Docker hosts",
+ "View preferences open with Grouped, Bars, History, Guest and Show selected",
+ "Mac in-app preview (dark and light themes) for the toggle colours before the pulse-dev pass"
+ ],
+ "interactions": [
+ "read every host Disk cell at 1440 and 390: one horizontal bar per row, no vertical micro-bars, multi-disk rows labelled 'NN% max' on desktop and 'NN%' on phone, single-disk rows keep used/total on desktop",
+ "measured disk labels for clipping (scrollWidth vs clientWidth): none clipped at either width; row heights 33px desktop, 32px phone; no horizontal page overflow",
+ "hovered a multi-disk machine's disk bar: the Disk Breakdown tooltip lists each mount with its percentage and capacity",
+ "opened View preferences: selected toggles render blue text with a blue ring, unselected stay muted; Layout and Metrics icons sit on the label's line (button height 28px)",
+ "no page errors in any route at either width"
+ ]
+}
diff --git a/frontend-modern/src/components/Workloads/__tests__/StackedDiskBar.test.tsx b/frontend-modern/src/components/Workloads/__tests__/StackedDiskBar.test.tsx
index a69379ee8d..ef7157785f 100644
--- a/frontend-modern/src/components/Workloads/__tests__/StackedDiskBar.test.tsx
+++ b/frontend-modern/src/components/Workloads/__tests__/StackedDiskBar.test.tsx
@@ -620,7 +620,7 @@ describe('StackedDiskBar', () => {
expect(bar?.getAttribute('fill')).toContain('239, 68, 68');
});
- it('draws a multi-disk host as one bar of its fullest disk, as host tables do', () => {
+ it('summarises a compact multi-disk cell by its fullest disk, not the average', () => {
const { container } = render(() => (
<StackedDiskBar
mode="aggregate"
@@ -634,7 +634,7 @@ describe('StackedDiskBar', () => {
/>
));
- // Same shape as a single-disk row: one fill, no per-disk micro-bars.
+ // One fill, sized and coloured by /data rather than the 20% aggregate.
expect(container.querySelectorAll('[data-stacked-disk-fill="single"]')).toHaveLength(1);
expect(container.querySelectorAll('[data-stacked-disk-fill="vertical"]')).toHaveLength(0);
expect(getSingleBarFill(container)?.getAttribute('fill')).toContain('239, 68, 68');
diff --git a/frontend-modern/src/features/docker/DockerHostsTable.tsx b/frontend-modern/src/features/docker/DockerHostsTable.tsx
index 273dcb7dc9..eb19a93a1d 100644
--- a/frontend-modern/src/features/docker/DockerHostsTable.tsx
+++ b/frontend-modern/src/features/docker/DockerHostsTable.tsx
@@ -526,8 +526,7 @@ export const DockerHostsTable: Component<{
fallback={<PlatformTableMetricFallback />}
>
<StackedDiskBar
- mode={(disks()?.length ?? 0) > 1 ? 'aggregate' : undefined}
- summaryStrategy="max"
+ mode={(disks()?.length ?? 0) > 1 ? 'vertical-bars' : undefined}
disks={disks()}
aggregateDisk={aggregateDisk()}
thresholds={diskThresholds()}
diff --git a/frontend-modern/src/features/docker/__tests__/DockerHostsTable.test.tsx b/frontend-modern/src/features/docker/__tests__/DockerHostsTable.test.tsx
index 8f646fe15c..89f84ea97a 100644
--- a/frontend-modern/src/features/docker/__tests__/DockerHostsTable.test.tsx
+++ b/frontend-modern/src/features/docker/__tests__/DockerHostsTable.test.tsx
@@ -82,13 +82,11 @@ vi.mock('@/components/Workloads/StackedDiskBar', () => ({
disks?: Disk[];
aggregateDisk?: Disk;
mode?: string;
- summaryStrategy?: string;
thresholds?: MetricDisplayThresholds | null;
}) => (
<div
data-testid="stacked-disk-bar"
data-mode={props.mode ?? ''}
- data-summary-strategy={props.summaryStrategy ?? ''}
data-disks={String(props.disks?.length ?? 0)}
data-aggregate-usage={String(props.aggregateDisk?.usage ?? '')}
data-thresholds={formatThresholds(props.thresholds)}
@@ -189,9 +187,7 @@ describe('DockerHostsTable', () => {
expect(screen.getByTestId('responsive-cpu-metric')).toHaveAttribute('data-running', 'true');
expect(screen.getByTestId('stacked-memory-bar')).toHaveAttribute('data-used', '3200');
expect(screen.getByTestId('stacked-memory-bar')).toHaveAttribute('data-total', '8000');
- // One bar shape for every host: a multi-disk host reads its fullest disk.
- expect(screen.getByTestId('stacked-disk-bar')).toHaveAttribute('data-mode', 'aggregate');
- expect(screen.getByTestId('stacked-disk-bar')).toHaveAttribute('data-summary-strategy', 'max');
+ expect(screen.getByTestId('stacked-disk-bar')).toHaveAttribute('data-mode', 'vertical-bars');
expect(screen.getByTestId('stacked-disk-bar')).toHaveAttribute('data-disks', '2');
});
diff --git a/frontend-modern/src/features/proxmox/ProxmoxNodesTable.tsx b/frontend-modern/src/features/proxmox/ProxmoxNodesTable.tsx
index 9a917e899b..a79010e120 100644
--- a/frontend-modern/src/features/proxmox/ProxmoxNodesTable.tsx
+++ b/frontend-modern/src/features/proxmox/ProxmoxNodesTable.tsx
@@ -708,10 +708,14 @@ export const ProxmoxNodesTable: Component<{
fallback={
<StackedDiskBar
mode={
- usesCompactMetrics() || (node.agent?.disks?.length ?? 0) > 1
+ usesCompactMetrics()
? 'aggregate'
- : undefined
+ : (node.agent?.disks?.length ?? 0) > 1
+ ? 'vertical-bars'
+ : undefined
}
+ // A compact cell has no room for per-disk bars; summarise it
+ // by the fullest disk so a full one is not averaged away.
summaryStrategy="max"
disks={normalizeDiskArray(node.agent?.disks)}
aggregateDisk={aggregateDisk()}
diff --git a/frontend-modern/src/features/standalone/AgentsMachinesTable.tsx b/frontend-modern/src/features/standalone/AgentsMachinesTable.tsx
index 8c0e3b42e1..ec355ed9df 100644
--- a/frontend-modern/src/features/standalone/AgentsMachinesTable.tsx
+++ b/frontend-modern/src/features/standalone/AgentsMachinesTable.tsx
@@ -1833,8 +1833,7 @@ export const AgentsMachinesTable: Component<{
fallback={telemetryFallbackMarker()}
>
<StackedDiskBar
- mode={(disks()?.length ?? 0) > 1 ? 'aggregate' : undefined}
- summaryStrategy="max"
+ mode={(disks()?.length ?? 0) > 1 ? 'vertical-bars' : undefined}
disks={disks()}
aggregateDisk={aggregateDisk()}
thresholds={diskThresholds()}
diff --git a/frontend-modern/src/features/standalone/__tests__/AgentsMachinesTable.test.tsx b/frontend-modern/src/features/standalone/__tests__/AgentsMachinesTable.test.tsx
index 4d93caaf6e..6fbf0669d7 100644
--- a/frontend-modern/src/features/standalone/__tests__/AgentsMachinesTable.test.tsx
+++ b/frontend-modern/src/features/standalone/__tests__/AgentsMachinesTable.test.tsx
@@ -720,7 +720,7 @@ describe('AgentsMachinesTable', () => {
expect(screen.getByTitle(/Agent has stopped reporting/)).toBeInTheDocument();
});
- it('renders multi-disk machine usage as one bar for the fullest disk', () => {
+ it('renders multi-disk machine usage as vertical mini-bars', () => {
const { container } = render(() => (
<AgentsMachinesTable
resources={[
@@ -757,11 +757,9 @@ describe('AgentsMachinesTable', () => {
/>
));
- // Same bar shape as a single-disk machine, sized and coloured by /data.
- expect(container.querySelectorAll('[data-stacked-disk-fill="vertical"]')).toHaveLength(0);
- expect(container.querySelectorAll('[data-stacked-disk-fill="single"]')).toHaveLength(1);
- expect(screen.getByText('91%')).toBeInTheDocument();
- expect(screen.getByText('max')).toBeInTheDocument();
+ expect(container.querySelectorAll('[data-stacked-disk-fill="vertical"]')).toHaveLength(2);
+ expect(screen.queryByText('max')).not.toBeInTheDocument();
+ expect(screen.queryByText('2 disks')).not.toBeInTheDocument();
});
it('searches machine-native fields and exposes host-style search affordances', async () => {