Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Keep the global alert pause contract in snapshot regression

pulse-triage[bot]c3a6b04fb6e6
diff --git a/docs/release-control/v6/internal/subsystems/alerts.md b/docs/release-control/v6/internal/subsystems/alerts.md
index 58cb0b0b2b..de838fdf0e 100644
--- a/docs/release-control/v6/internal/subsystems/alerts.md
+++ b/docs/release-control/v6/internal/subsystems/alerts.md
@@ -24,6 +24,7 @@ only that snapshot's existing canonical occurrence, including its trusted
age/size evidence, acknowledgement and observation time. It neither creates a
new occurrence nor refreshes old evidence. A trustworthy dated observation,
authoritative removal, exclusion or disablement still follows normal recovery.
+The global alerting switch remains an evaluation pause, not evidence of recovery.
This is deliberately conservative for both age and size warnings: an incomplete
snapshot observation does not independently update either metric. It introduces
diff --git a/internal/alerts/snapshot_date_observation_test.go b/internal/alerts/snapshot_date_observation_test.go
index 28d6cdc08e..79b2a1b3bc 100644
--- a/internal/alerts/snapshot_date_observation_test.go
+++ b/internal/alerts/snapshot_date_observation_test.go
@@ -103,6 +103,7 @@ func TestSnapshotDateObservations(t *testing.T) {
if len(m.GetActiveAlerts()) != 1 {
t.Fatal("control must establish an incident")
}
+ before := snapshotDateJSON(t, m.GetActiveAlerts())
s.Time = time.Time{}
snapshots := []models.GuestSnapshot{s}
cfg := m.GetConfig()
@@ -126,6 +127,14 @@ func TestSnapshotDateObservations(t *testing.T) {
}
m.UpdateConfig(cfg)
m.CheckSnapshotsForInstance("east", snapshots, guests)
+ if policy == "global-disabled" {
+ // The global switch pauses evaluation; it is not snapshot
+ // recovery or per-resource disablement. Preserve that contract.
+ if !bytes.Equal(before, snapshotDateJSON(t, m.GetActiveAlerts())) {
+ t.Fatal("global evaluation pause changed the trusted occurrence")
+ }
+ return
+ }
if len(m.GetActiveAlerts()) != 0 {
t.Fatal("unknown date overrode explicit policy or authoritative removal")
}