Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Compose backup age guidance without losing guest safety evidence

pulse-triage[bot]c76e16705c9b
diff --cc frontend-modern/src/components/Workloads/GuestRowCells.tsx
index 306b71c3b7,1c9df06d2a..1cebc3ed3f
--- a/frontend-modern/src/components/Workloads/GuestRowCells.tsx
+++ b/frontend-modern/src/components/Workloads/GuestRowCells.tsx
@@@ -1,25 -1,17 +1,30 @@@
import { createMemo, createSignal, For, Show } from 'solid-js';
import { Dialog } from '@/components/shared/Dialog';
+import { getShippedDocUrl } from '@/utils/docsLinks';
+import {
+ GUEST_DRAWER_BACKUP_PRECAUTION,
+ getGuestDrawerGuestReadPrecaution,
+ getGuestDrawerGuestReadPresentation,
+ type GuestDrawerGuestReadEvidence,
+} from './guestDrawerModel';
+ import {
+ EXTERNAL_TEXT_LINK_BASE_CLASS,
+ EXTERNAL_TEXT_LINK_VARIANT_CLASSES,
+ } from '@/components/shared/ExternalTextLink';
import { TooltipPortal } from '@/components/shared/TooltipPortal';
import { useTooltip } from '@/hooks/useTooltip';
import { useAlertsActivation } from '@/stores/alertsActivation';
import type { GuestNetworkInterface } from '@/types/api';
-import { formatBytes, formatRelativeTime, getBackupInfo, type BackupInfo } from '@/utils/format';
+import {
+ formatBackupCompletionTime,
+ formatBytes,
+ formatRelativeTime,
+ getBackupInfo,
+ type BackupInfo,
+} from '@/utils/format';
+ import { ALERT_BACKUP_THRESHOLDS_PATH } from '@/routing/resourceLinks';
import { useRelativeTimeNow } from '@/utils/relativeTimeClock';
import type { AvailabilityProbePresentation } from '@/utils/availabilityProbePresentation';
import {
@@@ -353,10 -343,9 +359,13 @@@ function BackupStatusCell(props:
: getBackupAgeBadgeLabel(props.lastBackup, info(), now()),
);
const hasCompletedBackup = createMemo(() => info().ageMs !== null);
+ // Parse/format only when the evidence is disclosed, not for every closed
+ // table row on each shared-clock tick. Unknown/future evidence has no time.
+ const completionTime = () =>
+ hasCompletedBackup() ? formatBackupCompletionTime(props.lastBackup!) : null;
+ const ageRule = createMemo(() =>
+ getWorkloadsGuestBackupAgeRule(info().status, alertsActivation.getBackupThresholds()),
+ );
const ariaLabel = createMemo(() => {
const currentInfo = info();
if (props.indicator) {
@@@ -381,14 -370,7 +390,14 @@@
// Both entry points reveal the same retained completion evidence. Hover
// stays a shortcut on a fine pointer; the native button opens a read-only
// dialog for keyboard/touch without stealing the enclosing row action.
- const Evidence = (evidenceProps: { ruleLink?: boolean }) => (
+ // Backup completion and current guest-read state are separate evidence.
+ // Reuse the drawer's allowlisted interpretation; never infer thaw from a
+ // fresh timestamp, retained metadata or a reporting Pulse Agent.
+ const guestReadPresentation = () =>
+ props.guestReadEvidence ? getGuestDrawerGuestReadPresentation(props.guestReadEvidence) : null;
+ const guestReadPrecaution = () =>
+ props.guestReadEvidence ? getGuestDrawerGuestReadPrecaution(props.guestReadEvidence) : null;
- const Evidence = (evidenceProps: { dialog?: boolean }) => (
++ const Evidence = (evidenceProps: { dialog?: boolean; ruleLink?: boolean }) => (
<div class="space-y-2 text-xs">
<Show when={props.guestName}>
<p class="font-medium text-base-content wrap-break-word">{props.guestName}</p>
@@@ -396,19 -378,40 +405,35 @@@
<Show when={props.backupRunning}>
<p class="text-blue-600 dark:text-blue-400">Backup running now…</p>
</Show>
- <Show when={hasCompletedBackup()}>
- <div class="space-y-1">
- <div class="text-muted">Last completed backup</div>
- <time
- class="block font-medium text-base-content"
- dateTime={new Date(props.lastBackup!).toISOString()}
- >
- {new Date(props.lastBackup!).toLocaleDateString(undefined, {
- weekday: 'short',
- year: 'numeric',
- month: 'short',
- day: 'numeric',
- })}
- {' · '}
- {new Date(props.lastBackup!).toLocaleTimeString()}
- </time>
- <div class="text-base-content">{info().ageFormatted}</div>
+ <Show when={completionTime()}>
+ {(completion) => (
+ <div class="space-y-1">
+ <div class="text-muted">Last completed backup</div>
+ <time
+ class="block whitespace-normal wrap-break-word font-medium text-base-content"
+ dateTime={completion().completedAt}
+ >
+ {completion().dateLabel}
+ </time>
+ <div class="text-base-content">{info().ageFormatted}</div>
+ <Show when={ageRule()}>
+ {(rule) => (
+ <p class="text-muted" data-backup-age-rule>
+ {rule()}
+ </p>
+ )}
+ </Show>
+ <Show when={evidenceProps.ruleLink && ageRule()}>
+ <a
+ href={ALERT_BACKUP_THRESHOLDS_PATH}
+ class={`${EXTERNAL_TEXT_LINK_BASE_CLASS} ${EXTERNAL_TEXT_LINK_VARIANT_CLASSES.compactAction} -mx-1`}
+ onClick={() => setDetailsOpen(false)}
+ >
+ Change when backups count as old
+ </a>
+ </Show>
- </div>
+ </div>
+ )}
</Show>
<Show when={info().status === 'unknown'}>
<p class="text-amber-700 dark:text-amber-300">{info().ageFormatted}</p>
@@@ -519,7 -489,7 +544,7 @@@
</button>
</div>
<div class="overflow-y-auto p-4">
- <Evidence dialog />
- <Evidence ruleLink />
++ <Evidence dialog ruleLink />
</div>
</Dialog>
</Show>