Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Use readable theme colours in guest network tooltips

pulse-triage[bot]c7a0e8dea45f
diff --git a/docs/release-control/v6/internal/HIGH_RISK_RELEASE_VERIFICATION_MATRIX.md b/docs/release-control/v6/internal/HIGH_RISK_RELEASE_VERIFICATION_MATRIX.md
index d26860c606..934e2aeb59 100644
--- a/docs/release-control/v6/internal/HIGH_RISK_RELEASE_VERIFICATION_MATRIX.md
+++ b/docs/release-control/v6/internal/HIGH_RISK_RELEASE_VERIFICATION_MATRIX.md
@@ -19,6 +19,9 @@ interface names. Live and silent linked-agent lists retain precedence, and
explicitly empty lists are not replaced by the other source. Change producers
on the same mounted guest: only selected agent interfaces inherit agent-stale
copy/tone, while the agent's other last-known readings remain last known.
+Check the tooltip's labels, addresses and supporting text against its actual
+surface in light and dark themes: normal-sized text needs at least 4.5:1
+contrast. Inspect the actual pixels as well as computed colours.
Synthetic browser fixtures are not installed Proxmox routing or reporter
acceptance. No guest query, networking change, agent installation or native
diff --git a/docs/release-control/v6/internal/subsystems/performance-and-scalability.md b/docs/release-control/v6/internal/subsystems/performance-and-scalability.md
index e2f3be1802..5aa49e7e60 100644
--- a/docs/release-control/v6/internal/subsystems/performance-and-scalability.md
+++ b/docs/release-control/v6/internal/subsystems/performance-and-scalability.md
@@ -25,6 +25,8 @@ on the same canonical row updates only its owning last-known presentation.
`useWorkloads.test.ts` checks VM/LXC transitions, unchanged ordered IPs and
identities, eight normal REST reads versus zero Workloads requests for the
owning-snapshot path. This is consumer proof, not native collection recovery.
+Network tooltip text follows the existing semantic palette; this changes no
+geometry, source selection, polling, hover ownership or portal mechanism.
### Guest filesystem guidance remains reachable by touch and keyboard (13 October 2026)
diff --git a/docs/release-control/v6/internal/subsystems/unified-resources.md b/docs/release-control/v6/internal/subsystems/unified-resources.md
index 220c2bbe8b..a3a4ddad0b 100644
--- a/docs/release-control/v6/internal/subsystems/unified-resources.md
+++ b/docs/release-control/v6/internal/subsystems/unified-resources.md
@@ -44,6 +44,9 @@ agent precedence, empty/absent lists, IP order and stable canonical identity;
`GuestDrawer.test.tsx` checks reactive source-specific last-known presentation
without clearing agent RAID/filesystem warnings. Desktop and narrow browser
proof must consume producing JSON, not manually populated WorkloadGuest rows.
+The row's existing Network tooltip uses semantic foreground/muted tokens for
+names, addresses, MACs, traffic and the address-only fallback. Fixed dark-palette
+text must not make the newly retained names unreadable on a light surface.
### Independently known PBS remains available in Backups (13 October 2026)
diff --git a/frontend-modern/src/components/Workloads/GuestRowCells.tsx b/frontend-modern/src/components/Workloads/GuestRowCells.tsx
index f6cfbaca44..306b71c3b7 100644
--- a/frontend-modern/src/components/Workloads/GuestRowCells.tsx
+++ b/frontend-modern/src/components/Workloads/GuestRowCells.tsx
@@ -167,7 +167,7 @@ function NetworkInfoCell(props: {
y={tip.pos().y}
>
<div class="min-w-[180px] max-w-[280px]">
- <div class="font-medium mb-1 text-slate-300 border-b border-border pb-1">
+ <div class="font-medium mb-1 text-base-content border-b border-border pb-1">
Network Interfaces
</div>
@@ -175,26 +175,26 @@ function NetworkInfoCell(props: {
<For each={props.networkInterfaces}>
{(iface, idx) => (
<div class="py-1" classList={{ 'border-t border-border': idx() > 0 }}>
- <div class="flex items-center gap-2 text-blue-400 font-medium">
+ <div class="flex items-center gap-2 text-base-content font-medium">
<span>{iface.name || 'eth' + idx()}</span>
<Show when={iface.mac}>
- <span class="text-[9px] text-slate-500 font-normal">{iface.mac}</span>
+ <span class="text-[9px] text-muted font-normal">{iface.mac}</span>
</Show>
</div>
<Show when={iface.addresses && iface.addresses.length > 0}>
<div class="mt-0.5 flex flex-wrap gap-1">
<For each={iface.addresses}>
- {(ip) => <span class="text-slate-300 font-mono">{ip}</span>}
+ {(ip) => <span class="text-base-content font-mono">{ip}</span>}
</For>
</div>
</Show>
<Show when={!iface.addresses || iface.addresses.length === 0}>
- <span class="text-slate-500 text-[9px]">
+ <span class="text-muted text-[9px]">
{getWorkloadsGuestNetworkEmptyState()}
</span>
</Show>
<Show when={(iface.rxBytes || 0) > 0 || (iface.txBytes || 0) > 0}>
- <div class="mt-0.5 text-[9px] text-slate-500">
+ <div class="mt-0.5 text-[9px] text-muted">
RX: {formatBytes(iface.rxBytes || 0)} / TX: {formatBytes(iface.txBytes || 0)}
</div>
</Show>
@@ -205,13 +205,13 @@ function NetworkInfoCell(props: {
<Show when={!hasInterfaces() && props.ipAddresses.length > 0}>
<div class="py-1">
- <div class="flex items-center gap-2 text-blue-400 font-medium">
+ <div class="flex items-center gap-2 text-base-content font-medium">
<span>IP Addresses</span>
- <span class="text-[9px] text-slate-500 font-normal">No agent data</span>
+ <span class="text-[9px] text-muted font-normal">No agent data</span>
</div>
<div class="mt-0.5 flex flex-wrap gap-1">
<For each={props.ipAddresses}>
- {(ip) => <span class="text-slate-300 font-mono">{ip}</span>}
+ {(ip) => <span class="text-base-content font-mono">{ip}</span>}
</For>
</div>
</div>
diff --git a/frontend-modern/src/components/Workloads/__tests__/GuestRowCells.network.test.tsx b/frontend-modern/src/components/Workloads/__tests__/GuestRowCells.network.test.tsx
new file mode 100644
index 0000000000..82e1ffdb92
--- /dev/null
+++ b/frontend-modern/src/components/Workloads/__tests__/GuestRowCells.network.test.tsx
@@ -0,0 +1,53 @@
+import { afterEach, describe, expect, it, vi } from 'vitest';
+import { cleanup, render, screen, within } from '@solidjs/testing-library';
+import { NetworkInfoCell } from '../GuestRowCells';
+import { getWorkloadsGuestNetworkEmptyState } from '@/utils/workloadGuestPresentation';
+
+vi.mock('@/hooks/useTooltip', () => ({
+ useTooltip: () => ({
+ show: () => true,
+ pos: () => ({ x: 100, y: 100 }),
+ onMouseEnter: () => {},
+ onMouseLeave: () => {},
+ }),
+}));
+vi.mock('@/components/shared/hoverCapability', () => ({ supportsHoverTooltips: () => true }));
+afterEach(cleanup);
+
+describe('guest network tooltip palette', () => {
+ it('keeps names, addresses and supporting readings on the semantic palette', () => {
+ render(() => (
+ <NetworkInfoCell
+ ipAddresses={['192.0.2.80']}
+ networkInterfaces={[
+ {
+ name: 'eth0',
+ addresses: ['192.0.2.80'],
+ mac: '02:00:00:00:00:80',
+ rxBytes: 1024,
+ txBytes: 2048,
+ },
+ { name: 'eth1', addresses: [] },
+ ]}
+ />
+ ));
+ const header = screen.getByText('Network Interfaces');
+ const tip = within(header.closest('[data-tooltip-portal]') as HTMLElement);
+ expect(header).toHaveClass('text-base-content');
+ expect(tip.getByText('eth0').parentElement).toHaveClass('text-base-content');
+ expect(tip.getByText('192.0.2.80')).toHaveClass('text-base-content');
+ expect(tip.getByText('02:00:00:00:00:80')).toHaveClass('text-muted');
+ expect(tip.getByText(getWorkloadsGuestNetworkEmptyState())).toHaveClass('text-muted');
+ expect(tip.getByText(/RX: 1.00 KB/)).toHaveClass('text-muted');
+ });
+
+ it('keeps the address-only fallback readable without changing its values', () => {
+ render(() => (
+ <NetworkInfoCell ipAddresses={['192.0.2.80', '10.88.0.1']} networkInterfaces={[]} />
+ ));
+ expect(screen.getByText('IP Addresses').parentElement).toHaveClass('text-base-content');
+ expect(screen.getByText('No agent data')).toHaveClass('text-muted');
+ for (const ip of ['192.0.2.80', '10.88.0.1'])
+ expect(screen.getByText(ip)).toHaveClass('text-base-content');
+ });
+});