Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.
Go aialertsdashboarddockerdocker-monitoringgohomelabinfrastructure-monitoringkubernetesmonitoringmspproxmoxproxmox-backup-serverproxmox-mail-gatewayproxmox-veself-hostedtruenastypescriptvspherewebhooks
Repair helper guidance link and recipe coverage
pulse-triage[bot]c7cda13f4686
diff --git a/internal/agentupdate/helper_lifecycle_test.go b/internal/agentupdate/helper_lifecycle_test.goindex 62457fb72f..153e3111da 100644--- a/internal/agentupdate/helper_lifecycle_test.go+++ b/internal/agentupdate/helper_lifecycle_test.go@@ -56,7 +56,7 @@ func TestRunLoopExplainsSeparateHelperLifecycleWithoutChangingHealth(t *testing.notes++message, _ := event["message"].(string)if event["level"] != "info" || !strings.Contains(message, "agent installer --update") ||- event["helper_update_guide"] != "https://github.com/rcourtman/Pulse/blob/main/docs/UNIFIED_AGENT.md#updating-the-typed-helper" {+ event["helper_update_guide"] != "https://github.com/rcourtman/Pulse/blob/b87c182407ef54a0503c19c06a1157a49e20b65e/docs/UNIFIED_AGENT.md#updating-the-typed-helper" {t.Fatalf("missing actionable helper lifecycle: %+v", event)}}diff --git a/internal/agentupdate/update.go b/internal/agentupdate/update.goindex e8bc025702..865d4be975 100644--- a/internal/agentupdate/update.go+++ b/internal/agentupdate/update.go@@ -321,7 +321,7 @@ func (u *Updater) RunLoop(ctx context.Context) {// without treating an unmeasured helper version as a health failure.u.logger.Info().Str("update_scope", "collector-only").- Str("helper_update_guide", "https://github.com/rcourtman/Pulse/blob/main/docs/UNIFIED_AGENT.md#updating-the-typed-helper").+ Str("helper_update_guide", "https://github.com/rcourtman/Pulse/blob/b87c182407ef54a0503c19c06a1157a49e20b65e/docs/UNIFIED_AGENT.md#updating-the-typed-helper").Msg("Automatic updates replace pulse-agent only, not the typed privilege helper; use the agent installer --update for a separate helper update")}diff --git a/scripts/tests/test_agent_docs.py b/scripts/tests/test_agent_docs.pyindex 47fd870a8e..60fad5d758 100644--- a/scripts/tests/test_agent_docs.py+++ b/scripts/tests/test_agent_docs.py@@ -81,9 +81,9 @@ class AgentDocsTest(unittest.TestCase):with self.subTest(name=name, command=block):subprocess.run(["bash", "-n", "-c", block], check=True, capture_output=True)count += 1- # Include the separate runner-only removal command, not just the- # collector uninstall and the existing setup/cleanup recipes.- self.assertEqual(count, 17)+ # Include runner-only removal and both saved-state helper maintenance+ # commands (preflight, then update), as well as setup/cleanup recipes.+ self.assertEqual(count, 19)def test_private_file_preparation_preserves_existing_token(self):command = recipe(NAMES[0], 'credential_file="$config_dir/agent-token"')diff --git a/scripts/tests/test_agent_helper_update_docs.py b/scripts/tests/test_agent_helper_update_docs.pyindex 884bc638b5..018b3bfbeb 100644--- a/scripts/tests/test_agent_helper_update_docs.py+++ b/scripts/tests/test_agent_helper_update_docs.py@@ -82,6 +82,17 @@ class AgentHelperUpdateDocsTest(unittest.TestCase):self.assertIn('verify_download_signature "$TMP_HELPER_BIN" "$helper_signature"', installer)self.assertIn('provision_typed_privileged_helper', installer)+ def test_runtime_guide_links_to_the_immutable_documented_procedure(self):+ source = (ROOT / "internal/agentupdate/update.go").read_text()+ link = re.search(r'Str\("helper_update_guide", "([^"]+)"\)', source)+ self.assertIsNotNone(link)+ # This ancestor contains the guide itself. Runtime help must not drift+ # to a different main-branch procedure after the agent was installed.+ self.assertEqual(link.group(1),+ "https://github.com/rcourtman/Pulse/blob/"+ "b87c182407ef54a0503c19c06a1157a49e20b65e/"+ "docs/UNIFIED_AGENT.md#updating-the-typed-helper")+if __name__ == "__main__":unittest.main()