Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Keep record drawer headings whole on phones

[email protected]cd514df7f924
diff --git a/docs/release-control/v6/internal/subsystems/unified-resources.md b/docs/release-control/v6/internal/subsystems/unified-resources.md
index d90ab9d9b8..58b871ff04 100644
--- a/docs/release-control/v6/internal/subsystems/unified-resources.md
+++ b/docs/release-control/v6/internal/subsystems/unified-resources.md
@@ -8628,6 +8628,13 @@ Secret's key names and values are never shown. Namespaces keep the object
drawer because they carry alerts. No resource identity, status or alert rule
changes.
+A record drawer's owner link (`RecordOwnerLink`) reads "Open" alone below the
+`sm` breakpoint and "Open <name>" above it, with the full label kept as its
+accessible name and tooltip. The drawer heading beside it already names the
+object; on a phone the repeated name took about half the header and broke a
+long heading (a Kubernetes pod's) mid-word across four lines. Where it links
+and when it appears are unchanged.
+
The remaining bespoke object drawers follow the guest drawer. The Proxmox Mail
Gateway row opens the shared resource drawer (row status, Overview, Manage)
with mail flow as its headless Mail tab, so a PMG has one drawer instead of
diff --git a/frontend-modern/browser-verification/f1128388392e914e.json b/frontend-modern/browser-verification/f1128388392e914e.json
new file mode 100644
index 0000000000..7014fd5a37
--- /dev/null
+++ b/frontend-modern/browser-verification/f1128388392e914e.json
@@ -0,0 +1,42 @@
+{
+ "version": 1,
+ "base_sha": "86ff402d118f3fc1010acfe04a4d8fcc9cbe5d9e",
+ "verified_at": "2026-10-22T23:20:03Z",
+ "result": "passed",
+ "changed_paths": [
+ "frontend-modern/src/features/platformPage/RecordOwnerLink.tsx"
+ ],
+ "content_sha256": {
+ "frontend-modern/src/features/platformPage/RecordOwnerLink.tsx": "40ab34adea57d54c1f62d2d93f79295ad3e1e23265e7b31d93516a9bd1e330d6"
+ },
+ "routes": [
+ "/kubernetes/events",
+ "/truenas/overview"
+ ],
+ "viewports": [
+ {
+ "width": 1440,
+ "height": 900
+ },
+ {
+ "width": 390,
+ "height": 844
+ }
+ ],
+ "states": [
+ "Embedded production build of this change on the full mock estate, signed in through the real login, compared with a build of main",
+ "390px Kubernetes event drawer for Pod/payments-worker-58484d44f7-f6gzh: the owner link reads \"Open\" (70px, was 192px) with accessible name and title \"Open payments-worker-58484d44f7-f6gzh\"; the heading widens from 98px to 220px and wraps once at a hyphen instead of breaking mid-word across four lines",
+ "390px TrueNAS alert drawer for disk sdc: the owner link reads \"Open\" with accessible name \"Open sdc\"",
+ "1440px: both drawers keep the full \"Open <name>\" label, unchanged from main",
+ "No console or page errors at either width"
+ ],
+ "interactions": [
+ "Tapping or clicking a record row opens its drawer with the owner link in the header"
+ ],
+ "browser": {
+ "client": "playwright 1.62.1",
+ "engine": "Chromium",
+ "version": "chromium-1234 headless"
+ },
+ "scope": "Full authenticated application on a mock estate; mock data, not live provider connections."
+}
diff --git a/frontend-modern/src/features/platformPage/RecordOwnerLink.tsx b/frontend-modern/src/features/platformPage/RecordOwnerLink.tsx
index 4bcde98f9a..c16f0f2742 100644
--- a/frontend-modern/src/features/platformPage/RecordOwnerLink.tsx
+++ b/frontend-modern/src/features/platformPage/RecordOwnerLink.tsx
@@ -52,7 +52,11 @@ export const RecordOwnerLink: Component<{
name?: string;
}> = (props) => {
const href = () => buildRecordOwnerPath(props.subject);
- const label = () => `Open ${props.name?.trim() || props.subject?.name?.trim() || 'resource'}`;
+ const name = () => props.name?.trim() || props.subject?.name?.trim() || 'resource';
+ const label = () => `Open ${name()}`;
+ // The drawer heading already names the object. On a phone, repeating it here
+ // took half the header and broke the heading mid-word, so the button reads
+ // "Open" there and keeps the full label for screen readers and the tooltip.
return (
<Show when={href()}>
{(path) => (
@@ -60,10 +64,13 @@ export const RecordOwnerLink: Component<{
href={path()}
class={getDrawerHeaderActionButtonClass('max-w-48 sm:max-w-64')}
title={label()}
+ aria-label={label()}
data-record-owner-link
>
<ArrowUpRightIcon class="h-3.5 w-3.5 shrink-0" aria-hidden="true" />
- <span class="truncate">{label()}</span>
+ <span class="truncate">
+ Open<span class="hidden sm:inline">{` ${name()}`}</span>
+ </span>
</A>
)}
</Show>
diff --git a/frontend-modern/src/features/platformPage/__tests__/RecordOwnerLink.test.tsx b/frontend-modern/src/features/platformPage/__tests__/RecordOwnerLink.test.tsx
index db02c876d5..086cf9e852 100644
--- a/frontend-modern/src/features/platformPage/__tests__/RecordOwnerLink.test.tsx
+++ b/frontend-modern/src/features/platformPage/__tests__/RecordOwnerLink.test.tsx
@@ -58,6 +58,11 @@ describe('RecordOwnerLink', () => {
const link = screen.getByRole('link', { name: 'Open payments' });
expect(link).toHaveAttribute('data-record-owner-link');
+ expect(link).toHaveAttribute('title', 'Open payments');
+ // Phones show "Open" alone; the heading beside it already names the object.
+ expect(screen.getByText('payments', { exact: false, selector: 'span.hidden' })).toHaveClass(
+ 'sm:inline',
+ );
await fireEvent.click(link);
await waitFor(() => expect(window.location.pathname).toBe('/kubernetes/workloads'));
expect(window.location.search).toBe('?q=payments');