Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Reconcile native installer smoke checks with bounded test groups

pulse-triage[bot]cea29beecaa6
diff --git a/scripts/tests/test_native_installer_contract_runner.py b/scripts/tests/test_native_installer_contract_runner.py
index 8d440513a1..7e748c959c 100644
--- a/scripts/tests/test_native_installer_contract_runner.py
+++ b/scripts/tests/test_native_installer_contract_runner.py
@@ -3,6 +3,7 @@
import importlib.util
from pathlib import Path
+import re
import subprocess
import unittest
from unittest import mock
@@ -17,15 +18,32 @@ spec.loader.exec_module(runner)
class NativeInstallerRunnerTest(unittest.TestCase):
inventory = "TestInstaller\nTestRootInstallResetSafety\nExample\nFuzzInput\nTestFuture\nTestRootInstallResetFuture\nok\tpackage\n"
+ expected_groups = (
+ ["Example", "TestFuture"],
+ ["FuzzInput", "TestInstaller"],
+ ["TestRootInstallResetFuture", "TestRootInstallResetSafety"],
+ )
def test_every_discovered_check_runs_once_in_one_group(self):
- general, reset = runner.partition(self.inventory)
- self.assertEqual(general, ["TestInstaller", "Example", "FuzzInput", "TestFuture"])
- self.assertEqual(reset, ["TestRootInstallResetSafety", "TestRootInstallResetFuture"])
- self.assertEqual(len(set(general + reset)), 6)
+ groups = runner.partition(self.inventory)
+ self.assertEqual(runner.GROUPS, ("general-0", "general-1", "reset"))
+ self.assertEqual(groups, self.expected_groups)
+ selected = [name for group in groups for name in group]
+ self.assertEqual(len(selected), 6)
+ self.assertEqual(len(set(selected)), 6)
+
+ def test_partition_order_and_odd_inventory_are_exhaustive(self):
+ reversed_inventory = "\n".join(reversed(self.inventory.splitlines()))
+ self.assertEqual(runner.partition(reversed_inventory), self.expected_groups)
+ self.assertEqual(runner.partition(self.inventory + "TestZ\n"), (
+ ["Example", "TestFuture", "TestZ"],
+ self.expected_groups[1],
+ self.expected_groups[2],
+ ))
def test_missing_inventory_is_not_a_passing_empty_run(self):
- for inventory in ("", "ok\tpackage\n", "TestInstaller\n", "TestRootInstallResetSafety\n"):
+ for inventory in ("", "ok\tpackage\n", "TestInstaller\n", "TestRootInstallResetSafety\n",
+ "TestInstaller\nTestRootInstallResetSafety\n"):
with self.subTest(inventory=inventory), self.assertRaises(ValueError):
runner.partition(inventory)
@@ -35,8 +53,8 @@ class NativeInstallerRunnerTest(unittest.TestCase):
runner.partition(self.inventory + name + "\n")
def test_unicode_go_identifiers_remain_included(self):
- general, _ = runner.partition(self.inventory + "TestΣ\n")
- self.assertIn("TestΣ", general)
+ groups = runner.partition(self.inventory + "TestΣ\n")
+ self.assertIn("TestΣ", [name for group in groups[:2] for name in group])
def run_main(self, fault=None):
calls = []
@@ -59,22 +77,39 @@ class NativeInstallerRunnerTest(unittest.TestCase):
def test_actual_commands_preserve_deadlines_count_and_complete_selection(self):
calls = self.run_main()
self.assertEqual(calls[0][0], ["go", "test", "-list", ".", runner.PACKAGE])
- general, reset = runner.partition(self.inventory)
- for (command, kwargs), names in zip(calls[1:], (general, reset)):
+ self.assertTrue(calls[0][1]["capture_output"])
+ self.assertTrue(calls[0][1]["text"])
+ # Check the count before zip: a missing final reset invocation must not
+ # silently truncate the comparison and become a passing control.
+ self.assertEqual(len(calls), 4)
+ for (command, kwargs), names in zip(calls[1:], self.expected_groups):
self.assertEqual(command, ["go", "test", "-count=1", "-timeout", "10m", "-run", "^(" + "|".join(names) + ")$", runner.PACKAGE])
self.assertTrue(kwargs["check"])
self.assertEqual(kwargs["cwd"], ROOT)
- self.assertEqual(len(calls), 3)
+
+ def test_command_selectors_do_not_broaden_the_inventory(self):
+ calls = self.run_main()
+ self.assertEqual(len(calls), 4)
+ patterns = [re.compile(command[6]) for command, _ in calls[1:]]
+ for name in (name for group in self.expected_groups for name in group):
+ with self.subTest(name=name):
+ self.assertEqual(sum(bool(pattern.fullmatch(name)) for pattern in patterns), 1)
+ for name in ("TestInstaller/child", "TestInstallerExtra", "TestInjected", "BenchmarkIgnored"):
+ with self.subTest(name=name):
+ self.assertFalse(any(pattern.fullmatch(name) for pattern in patterns))
def test_inventory_failure_does_not_run_any_group(self):
self.assertEqual(len(self.run_main(1)), 1)
- def test_first_failure_cannot_be_hidden_by_second_group(self):
+ def test_first_general_failure_cannot_be_hidden_by_later_groups(self):
self.assertEqual(len(self.run_main(2)), 2)
- def test_second_group_failure_remains_terminal(self):
+ def test_second_general_failure_remains_terminal(self):
self.assertEqual(len(self.run_main(3)), 3)
+ def test_reset_failure_remains_terminal(self):
+ self.assertEqual(len(self.run_main(4)), 4)
+
if __name__ == "__main__":
unittest.main()