Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Keep notification report evidence passive and distinct

pulse-triage[bot]d0a4f48bb238
diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml
index f88b12f02a..7154f3de42 100644
--- a/.github/ISSUE_TEMPLATE/bug_report.yml
+++ b/.github/ISSUE_TEMPLATE/bug_report.yml
@@ -135,6 +135,9 @@ body:
Add relevant redacted logs or a reviewed GitHub diagnostics export for connection and data failures; for visual failures, a screenshot or exact error may be enough. Prefer existing evidence when new collection is unsafe.
Review files and screenshots locally; remove secrets and identifying details, including those echoed in errors, before attaching them here.
+ For notification reports, distinguish an already-observed **Test** result from ordinary alert delivery: single, grouped/digest or resolved. Give the destination type (such as email or Telegram), built-in or custom template, original time and redacted error or missing host/resource context where known. A successful Test does not establish ordinary delivery or correct identity.
+ Use existing messages and queue details only; blank or "unknown" is valid. Do not send a Test, trigger an alert, retry/replay a queued message, clear the queue or change notification settings just to complete this report. Keep destination addresses, webhook URLs, chat IDs, tokens and full notification settings or payloads private.
+
For CPU, memory or disk-write reports, use existing readings or safe, passive observations. Say whether the reading covers the Pulse process, its container or the whole host, and give its units, measurement window and uptime. Include allocated CPUs or memory limit, fleet size, polling interval and open dashboards where relevant and known. A process-start CPU average is not a recent sampling window; database size is not a write rate.
Existing screenshots are useful; write "unavailable" when safe collection is not possible. Do not restart, create load or change polling or retention just to measure. Do not attach raw profiles, heap dumps, databases or full process command lines; summarise only relevant counters after local review.
validations:
diff --git a/.github/ISSUE_TEMPLATE/v6_rc_feedback.yml b/.github/ISSUE_TEMPLATE/v6_rc_feedback.yml
index 631a8730c7..183feb8575 100644
--- a/.github/ISSUE_TEMPLATE/v6_rc_feedback.yml
+++ b/.github/ISSUE_TEMPLATE/v6_rc_feedback.yml
@@ -177,6 +177,9 @@ body:
Attach screenshots or paste relevant redacted logs if useful. For connection or data failures, a reviewed GitHub diagnostics export can help; prefer existing evidence when new collection is unsafe.
Review files and screenshots locally; remove secrets and identifying details, including those echoed in errors, before attaching them here.
+ For notification reports, distinguish an already-observed **Test** result from ordinary alert delivery: single, grouped/digest or resolved. Give the destination type (such as email or Telegram), built-in or custom template, original time and redacted error or missing host/resource context where known. A successful Test does not establish ordinary delivery or correct identity.
+ Use existing messages and queue details only; blank or "unknown" is valid. Do not send a Test, trigger an alert, retry/replay a queued message, clear the queue or change notification settings just to complete this report. Keep destination addresses, webhook URLs, chat IDs, tokens and full notification settings or payloads private.
+
For CPU, memory or disk-write reports, use existing readings or safe, passive observations. Say whether the reading covers the Pulse process, its container or the whole host, and give its units, measurement window and uptime. Include allocated CPUs or memory limit, fleet size, polling interval and open dashboards where relevant and known. A process-start CPU average is not a recent sampling window; database size is not a write rate.
Existing screenshots are useful; write "unavailable" when safe collection is not possible. Do not restart, create load or change polling or retention just to measure. Do not attach raw profiles, heap dumps, databases or full process command lines; summarise only relevant counters after local review.
diff --git a/docs/ISSUE_TRIAGE.md b/docs/ISSUE_TRIAGE.md
index d513b690e9..049c9f4362 100644
--- a/docs/ISSUE_TRIAGE.md
+++ b/docs/ISSUE_TRIAGE.md
@@ -102,6 +102,26 @@ profiles, heap dumps, databases or full process command lines in a public
thread; use locally reviewed counter summaries, without restarting, creating
load or changing polling or retention just to measure.
+For notification reports, distinguish an already-observed **Test** result from
+ordinary alert delivery: single, grouped/digest or resolved. A successful Test
+does not establish ordinary delivery or correct identity. Retain the destination
+type, built-in or custom template, original time and redacted error or missing
+host/resource context where already known; consistent private aliases preserve
+which hosts or resources repeat. Keep an alert appearing in Pulse, its queued
+attempt and the recipient's actual message as separate observations. Delivery
+can succeed while the subject or body still identifies the wrong resource.
+
+Use existing messages and queue details, including earlier comments, rather
+than asking for the same facts again. Queued messages can retain older settings;
+a current configuration screenshot does not establish the settings of an older
+attempt. Unknown evidence stays unknown, and existing reports need no refile.
+Do not request another Test, induced alert, queue retry/replay, queue clearing or
+notification-setting changes just to complete a report. Keep destination
+addresses, webhook URLs, chat IDs, tokens and full notification settings or
+payloads private, even when an error or screenshot contains them. A missing
+notification alone does not prove that alert evaluation failed; retain both
+symptoms when the thread supplies evidence for each.
+
## Required disposition
Before removing `needs-decomposition` or declaring a mixed report triaged:
diff --git a/frontend-modern/public/docs/ISSUE_TRIAGE.md b/frontend-modern/public/docs/ISSUE_TRIAGE.md
index d513b690e9..049c9f4362 100644
--- a/frontend-modern/public/docs/ISSUE_TRIAGE.md
+++ b/frontend-modern/public/docs/ISSUE_TRIAGE.md
@@ -102,6 +102,26 @@ profiles, heap dumps, databases or full process command lines in a public
thread; use locally reviewed counter summaries, without restarting, creating
load or changing polling or retention just to measure.
+For notification reports, distinguish an already-observed **Test** result from
+ordinary alert delivery: single, grouped/digest or resolved. A successful Test
+does not establish ordinary delivery or correct identity. Retain the destination
+type, built-in or custom template, original time and redacted error or missing
+host/resource context where already known; consistent private aliases preserve
+which hosts or resources repeat. Keep an alert appearing in Pulse, its queued
+attempt and the recipient's actual message as separate observations. Delivery
+can succeed while the subject or body still identifies the wrong resource.
+
+Use existing messages and queue details, including earlier comments, rather
+than asking for the same facts again. Queued messages can retain older settings;
+a current configuration screenshot does not establish the settings of an older
+attempt. Unknown evidence stays unknown, and existing reports need no refile.
+Do not request another Test, induced alert, queue retry/replay, queue clearing or
+notification-setting changes just to complete a report. Keep destination
+addresses, webhook URLs, chat IDs, tokens and full notification settings or
+payloads private, even when an error or screenshot contains them. A missing
+notification alone does not prove that alert evaluation failed; retain both
+symptoms when the thread supplies evidence for each.
+
## Required disposition
Before removing `needs-decomposition` or declaring a mixed report triaged:
diff --git a/scripts/release_control/release_promotion_policy_test.py b/scripts/release_control/release_promotion_policy_test.py
index 897bb45948..c5335f2e9e 100644
--- a/scripts/release_control/release_promotion_policy_test.py
+++ b/scripts/release_control/release_promotion_policy_test.py
@@ -1867,6 +1867,61 @@ class ReleasePromotionPolicyTest(unittest.TestCase):
self.assertEqual(evidence["attributes"]["label"], "Logs, screenshots, or diagnostics")
self.assertFalse(evidence.get("validations", {}).get("required", False))
+ def test_notification_report_context_is_optional_and_passive(self) -> None:
+ for name, evidence_id in (("bug_report.yml", "logs"), ("v6_rc_feedback.yml", "evidence")):
+ with self.subTest(form=name):
+ form = yaml.load(read(f".github/ISSUE_TEMPLATE/{name}"), Loader=UniqueKeyLoader)
+ fields = {field["id"]: field for field in form["body"] if "id" in field}
+ self.assertEqual(len(fields), sum("id" in field for field in form["body"]))
+ evidence = fields[evidence_id]
+ self.assertEqual(evidence["type"], "textarea")
+ self.assertFalse(evidence.get("validations", {}).get("required", False))
+ self.assertNotIn("render", evidence["attributes"])
+ # Keep the distinctions at the optional attachment point, not
+ # hidden in an introduction, link or new required field.
+ description = evidence["attributes"]["description"]
+ context = normalize_ws(description.split("For notification reports,", 1)[1]
+ .split("For CPU, memory or disk-write reports", 1)[0])
+ for distinction in (
+ "already-observed **Test** result", "ordinary alert delivery",
+ "single, grouped/digest or resolved", "destination type",
+ "built-in or custom template", "original time", "redacted error",
+ "missing host/resource context where known",
+ "successful Test does not establish ordinary delivery or correct identity",
+ "Use existing messages and queue details only", 'blank or "unknown" is valid',
+ "Do not send a Test, trigger an alert, retry/replay a queued message",
+ "clear the queue or change notification settings just to complete this report",
+ "Keep destination addresses, webhook URLs, chat IDs, tokens",
+ "full notification settings or payloads private",
+ ):
+ self.assertIn(distinction, context)
+ self.assertTrue(fields["pulse_version"]["validations"]["required"])
+
+ def test_notification_triage_separates_evaluation_delivery_and_identity(self) -> None:
+ documents = ("docs/ISSUE_TRIAGE.md", "frontend-modern/public/docs/ISSUE_TRIAGE.md")
+ self.assertEqual(read(documents[0]), read(documents[1]))
+ for document in documents:
+ with self.subTest(document=document):
+ context = normalize_ws(read(document).split("For notification reports,", 1)[1]
+ .split("## Required disposition", 1)[0])
+ for distinction in (
+ "successful Test does not establish ordinary delivery or correct identity",
+ "consistent private aliases", "alert appearing in Pulse",
+ "queued attempt", "recipient's actual message as separate observations",
+ "subject or body still identifies the wrong resource",
+ "including earlier comments", "rather than asking for the same facts again",
+ "Queued messages can retain older settings",
+ "current configuration screenshot does not establish",
+ "Unknown evidence stays unknown", "existing reports need no refile",
+ "Do not request another Test, induced alert, queue retry/replay",
+ "queue clearing or notification-setting changes",
+ "Keep destination addresses, webhook URLs, chat IDs, tokens",
+ "full notification settings or payloads private",
+ "missing notification alone does not prove that alert evaluation failed",
+ "retain both symptoms",
+ ):
+ self.assertIn(distinction, context)
+
def test_report_intake_distinguishes_server_install_from_affected_target(self) -> None:
for name, summary_id, install_id in (
("bug_report.yml", "bug_description", "install_type"),