Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Pin materialized copy ownership and cold registry read costs

pulse-triage[bot]d211cc82cdd0
diff --git a/internal/unifiedresources/clone_test.go b/internal/unifiedresources/clone_test.go
index 113205f28f..1ad90ad974 100644
--- a/internal/unifiedresources/clone_test.go
+++ b/internal/unifiedresources/clone_test.go
@@ -981,3 +981,28 @@ func TestCloneResource_PreservesActionReadinessDetail(t *testing.T) {
t.Fatalf("clone dropped action readiness diagnostics: %#v", cloned.ActionReadiness)
}
}
+
+func TestCloneMaterializedResourceDetachesCanonicalPolicy(t *testing.T) {
+ original := &Resource{ID: "agent:synthetic", Type: ResourceTypeAgent, Name: "synthetic", Sources: []DataSource{SourceAgent}, Tags: []string{"customer-data"}, Agent: &AgentData{AgentID: "synthetic", Hostname: "synthetic.example.test"}, Identity: ResourceIdentity{IPAddresses: []string{"192.0.2.1"}}, SupersededCanonicalIDs: []string{"agent:old-synthetic"}}
+ RefreshCanonicalMetadata(original)
+ copied := cloneMaterializedResource(original)
+ if !reflect.DeepEqual(copied, cloneResource(original)) {
+ t.Fatal("materialized copy differs from arbitrary-input refreshed clone")
+ }
+ copied.Canonical.Aliases[0] = "changed"
+ copied.Canonical.SupersededIDs[0] = "changed"
+ copied.Policy.Routing.Redact[0] = "changed"
+ copied.Policy.Sensitivity = ResourceSensitivityPublic
+ copied.PlatformScopes[0] = "changed"
+ if original.Canonical.Aliases[0] == "changed" || original.Canonical.SupersededIDs[0] == "changed" || original.Policy.Routing.Redact[0] == "changed" || original.Policy.Sensitivity != ResourceSensitivityRestricted || original.PlatformScopes[0] == "changed" {
+ t.Fatal("bulk resource copy aliases canonical identity or policy")
+ }
+ original.Tags = []string{"public"}
+ refreshed := cloneResource(original)
+ if refreshed.Policy.Sensitivity != ResourceSensitivityPublic {
+ t.Fatal("arbitrary clone trusted stale materialized policy")
+ }
+ if cloneMaterializedResource(nil).ID != "" || cloneMaterializedResourcePtr(nil) != nil {
+ t.Fatal("nil materialized clone changed absence")
+ }
+}
diff --git a/internal/unifiedresources/registry_materialization_test.go b/internal/unifiedresources/registry_materialization_test.go
index 96c046e921..90954a7e03 100644
--- a/internal/unifiedresources/registry_materialization_test.go
+++ b/internal/unifiedresources/registry_materialization_test.go
@@ -244,3 +244,166 @@ func TestRegistryMaterializedMetadataListKeepsViewsLazy(t *testing.T) {
t.Fatal("clean bulk read discarded detached typed views")
}
}
+
+// Exact assigned-base typed-view builder, retained as an independent paired
+// cost reference. It deliberately refreshes each resource copy.
+func (rr *ResourceRegistry) rebuildFreshMetadataViewsForTest() {
+ rr.cachedVMs = nil
+ rr.cachedLXC = nil
+ rr.cachedNodes = nil
+ rr.cachedHosts = nil
+ rr.cachedDocker = nil
+ rr.cachedDockerContainers = nil
+ rr.cachedStorage = nil
+ rr.cachedPhysicalDisks = nil
+ rr.cachedPBS = nil
+ rr.cachedPMG = nil
+ rr.cachedK8s = nil
+ rr.cachedK8sNodes = nil
+ rr.cachedPods = nil
+ rr.cachedK8sDeployments = nil
+ rr.cachedWorkload = nil
+ rr.cachedInfra = nil
+
+ // One O(mappings) pass instead of a per-resource scan over every
+ // mapping: at thousands of resources the difference is seconds of
+ // write-lock hold time per rebuild.
+ sourceTargetsIndex := rr.buildSourceTargetsIndexLocked()
+ rr.cachedSourceTargets = sourceTargetsIndex
+
+ for _, r := range rr.resources {
+ viewResource := cloneResourcePtr(r)
+ viewResource.MetricsTarget = rr.metricsTargetFromSourceTargets(r, sourceTargetsIndex[r.ID])
+ switch r.Type {
+ case ResourceTypeVM:
+ v := NewVMView(viewResource)
+ rr.cachedVMs = append(rr.cachedVMs, &v)
+ w := NewWorkloadView(viewResource)
+ rr.cachedWorkload = append(rr.cachedWorkload, &w)
+ case ResourceTypeSystemContainer:
+ v := NewContainerView(viewResource)
+ rr.cachedLXC = append(rr.cachedLXC, &v)
+ w := NewWorkloadView(viewResource)
+ rr.cachedWorkload = append(rr.cachedWorkload, &w)
+ case ResourceTypeAppContainer:
+ v := NewDockerContainerView(viewResource)
+ rr.cachedDockerContainers = append(rr.cachedDockerContainers, &v)
+ w := NewWorkloadView(viewResource)
+ rr.cachedWorkload = append(rr.cachedWorkload, &w)
+ case ResourceTypeAgent:
+ inf := NewInfrastructureView(viewResource)
+ rr.cachedInfra = append(rr.cachedInfra, &inf)
+ if r.Proxmox != nil {
+ v := NewNodeView(viewResource)
+ rr.cachedNodes = append(rr.cachedNodes, &v)
+ }
+ if r.Agent != nil || r.VMware != nil {
+ v := NewHostView(viewResource)
+ rr.cachedHosts = append(rr.cachedHosts, &v)
+ }
+ if r.Docker != nil {
+ v := NewDockerHostView(viewResource)
+ rr.cachedDocker = append(rr.cachedDocker, &v)
+ }
+ case ResourceTypeStorage:
+ v := NewStoragePoolView(viewResource)
+ rr.cachedStorage = append(rr.cachedStorage, &v)
+ case ResourceTypePhysicalDisk:
+ v := NewPhysicalDiskView(viewResource)
+ rr.cachedPhysicalDisks = append(rr.cachedPhysicalDisks, &v)
+ case ResourceTypePBS:
+ v := NewPBSInstanceView(viewResource)
+ rr.cachedPBS = append(rr.cachedPBS, &v)
+ case ResourceTypePMG:
+ v := NewPMGInstanceView(viewResource)
+ rr.cachedPMG = append(rr.cachedPMG, &v)
+ case ResourceTypeK8sCluster:
+ v := NewK8sClusterView(viewResource)
+ rr.cachedK8s = append(rr.cachedK8s, &v)
+ case ResourceTypeK8sNode:
+ v := NewK8sNodeView(viewResource)
+ rr.cachedK8sNodes = append(rr.cachedK8sNodes, &v)
+ case ResourceTypePod:
+ v := NewPodView(viewResource)
+ rr.cachedPods = append(rr.cachedPods, &v)
+ case ResourceTypeK8sDeployment:
+ v := NewK8sDeploymentView(viewResource)
+ rr.cachedK8sDeployments = append(rr.cachedK8sDeployments, &v)
+ }
+ }
+
+ sortNamedResourceViewsByName(rr.cachedVMs)
+ sortNamedResourceViewsByName(rr.cachedLXC)
+ sortNamedResourceViewsByName(rr.cachedNodes)
+ sortNamedResourceViewsByName(rr.cachedHosts)
+ sortNamedResourceViewsByName(rr.cachedDocker)
+ sortNamedResourceViewsByName(rr.cachedDockerContainers)
+ sortNamedResourceViewsByName(rr.cachedStorage)
+ sortNamedResourceViewsByName(rr.cachedPhysicalDisks)
+ sortNamedResourceViewsByName(rr.cachedPBS)
+ sortNamedResourceViewsByName(rr.cachedPMG)
+ sortNamedResourceViewsByName(rr.cachedK8s)
+ sortNamedResourceViewsByName(rr.cachedK8sNodes)
+ sortNamedResourceViewsByName(rr.cachedPods)
+ sortNamedResourceViewsByName(rr.cachedK8sDeployments)
+ sortNamedResourceViewsByName(rr.cachedWorkload)
+ sortNamedResourceViewsByName(rr.cachedInfra)
+
+ rr.viewsDirty = false
+}
+
+func BenchmarkRegistryMetadataDirtyReads(b *testing.B) {
+ for _, count := range []int{1, 1000} {
+ for _, withViews := range []bool{false, true} {
+ mode := "list-only"
+ if withViews {
+ mode = "list-and-views"
+ }
+ for _, fresh := range []bool{true, false} {
+ name := "materialized"
+ if fresh {
+ name = "fresh-clone"
+ }
+ b.Run(fmt.Sprintf("resources-%d/%s/%s", count, mode, name), func(b *testing.B) {
+ rr := NewRegistry(nil)
+ rr.IngestSnapshot(benchmarkVMState(count))
+ rr.List()
+ rr.VMs()
+ rr.mu.RLock()
+ var updated *Resource
+ for _, r := range rr.resources {
+ updated = r
+ break
+ }
+ rr.mu.RUnlock()
+ b.ReportAllocs()
+ b.ResetTimer()
+ for i := 0; i < b.N; i++ {
+ rr.mu.Lock()
+ if i%2 == 0 {
+ updated.Status = StatusOnline
+ } else {
+ updated.Status = StatusOffline
+ }
+ rr.invalidateViewsLocked()
+ rr.mu.Unlock()
+ if fresh {
+ materializedMetadataAllocationSink = freshRegistryListForMetadataTest(rr)
+ } else {
+ materializedMetadataAllocationSink = rr.List()
+ }
+ if withViews {
+ if fresh {
+ rr.mu.Lock()
+ rr.rebuildFreshMetadataViewsForTest()
+ rr.mu.Unlock()
+ } else {
+ rr.VMs()
+ }
+ }
+ }
+ })
+ }
+ }
+ }
+}
diff --git a/internal/unifiedresources/registry_test.go b/internal/unifiedresources/registry_test.go
index 9203721d56..608e291880 100644
--- a/internal/unifiedresources/registry_test.go
+++ b/internal/unifiedresources/registry_test.go
@@ -6907,3 +6907,24 @@ func TestAgentNodeScanIndexTracksAgentsIngestedWhileLive(t *testing.T) {
t.Fatalf("index bucket for an agent ingested while live = %+v, want its registry entry", candidates)
}
}
+
+func TestRegistryBulkMetadataInvalidatesAtRecordBoundary(t *testing.T) {
+ rr := NewRegistry(nil)
+ rr.IngestRecords(SourceAgent, []IngestRecord{{SourceID: "host", Resource: Resource{Type: ResourceTypeAgent, Name: "before", Status: StatusOnline, LastSeen: time.Now().UTC(), Agent: &AgentData{AgentID: "host", Hostname: "before.example.test"}}}})
+ rr.List()
+ previous := rr.Hosts()[0]
+ id := rr.ingestRecord(SourceAgent, "host", Resource{Type: ResourceTypeAgent, Name: "after", Status: StatusOnline, LastSeen: time.Now().UTC(), Agent: &AgentData{AgentID: "host", Hostname: "after.example.test"}}, ResourceIdentity{}, false)
+ // This is the real record boundary, before parent/rollup batch finalization.
+ actual := assertRegistryMetadataOracle(t, rr)
+ if actual[0].Canonical.Hostname != "after.example.test" || rr.Hosts()[0].Name() != "after" {
+ t.Fatal("record mutation reused pre-batch metadata or views")
+ }
+ if previous.Name() != "before" {
+ t.Fatal("record mutation rewrote an already returned view")
+ }
+ rr.retainSupersededCanonicalIDs(id, []string{"agent:prior-era"})
+ actual = assertRegistryMetadataOracle(t, rr)
+ if len(actual[0].Canonical.SupersededIDs) != 1 || actual[0].Canonical.SupersededIDs[0] != "agent:prior-era" {
+ t.Fatal("superseded identity retention failed to invalidate bulk metadata")
+ }
+}