Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Align native seed-image pin checks with same-run E2E bundles

pulse-triage[bot]db9743a84e91
diff --git a/docs/release-control/v6/internal/subsystems/deployment-installability.md b/docs/release-control/v6/internal/subsystems/deployment-installability.md
index 97f95ddf4d..67b5120c1b 100644
--- a/docs/release-control/v6/internal/subsystems/deployment-installability.md
+++ b/docs/release-control/v6/internal/subsystems/deployment-installability.md
@@ -44,6 +44,13 @@ real Docker execution, hosted artifact transfer or a completed user journey.
Containing hosted production, load/start and all journey verdicts remain the
operational acceptance result. These images are not release artifacts.
+The native immutable-base check recognises both a literal full Alpine pin and
+the exact `${PULSE_E2E_SEED_IMAGE:-<full-pin>}` compose default used by that
+same-run bundle. Its pin-form controls reject arbitrary variables/operators,
+missing, mutable or malformed defaults and partial digests. This reconciles
+the native source check with the existing compose expression; it changes no
+image, Docker admission, installer behaviour, deadline or required CI gate.
+
### Existing auto-update timers are discovered without changing consent
Server installer timer discovery is a bounded, exact-unit `systemctl` inventory.
diff --git a/scripts/installtests/integration_container_test.go b/scripts/installtests/integration_container_test.go
index f51a8285c9..094f01dcd1 100644
--- a/scripts/installtests/integration_container_test.go
+++ b/scripts/installtests/integration_container_test.go
@@ -30,6 +30,47 @@ func TestIntegrationContainersUseGovernedImmutableBases(t *testing.T) {
}
func regexpDigestPinnedImage(image string, content string) bool {
- pattern := regexp.MustCompile(`(?m)^\s*image:\s*` + regexp.QuoteMeta(image) + `@sha256:[0-9a-f]{64}\s*$`)
+ pin := regexp.QuoteMeta(image) + `@sha256:[0-9a-f]{64}`
+ // The same-run CI bundle uses this fixed override; the local default must
+ // still be a complete governed pin. Do not admit arbitrary interpolation.
+ pattern := regexp.MustCompile(`(?m)^[ \t]*image:[ \t]*(?:` + pin + `|\$\{PULSE_E2E_SEED_IMAGE:-` + pin + `\})[ \t]*\r?$`)
return pattern.MatchString(content)
}
+
+func TestIntegrationContainerImagePinForms(t *testing.T) {
+ pin := "alpine:3.24@sha256:" + strings.Repeat("a", 64)
+ for _, tc := range []struct {
+ name string
+ value string
+ want bool
+ }{
+ {"literal", "image: " + pin + "\n", true},
+ {"indented-literal", " image: " + pin + "\n", true},
+ {"same-run-override", " image: ${PULSE_E2E_SEED_IMAGE:-" + pin + "}\n", true},
+ {"crlf-override", "\timage:\t${PULSE_E2E_SEED_IMAGE:-" + pin + "} \r\n", true},
+ {"unpinned-literal", "image: alpine:3.24\n", false},
+ {"unpinned-default", "image: ${PULSE_E2E_SEED_IMAGE:-alpine:3.24}\n", false},
+ {"missing-default", "image: ${PULSE_E2E_SEED_IMAGE}\n", false},
+ {"retired-line", "image: ${PULSE_E2E_SEED_IMAGE:-" + strings.Replace(pin, "3.24", "3.20", 1) + "}\n", false},
+ {"mutable-line", "image: ${PULSE_E2E_SEED_IMAGE:-" + strings.Replace(pin, "3.24", "latest", 1) + "}\n", false},
+ {"other-variable", "image: ${OTHER_IMAGE:-" + pin + "}\n", false},
+ {"unset-only-default", "image: ${PULSE_E2E_SEED_IMAGE-" + pin + "}\n", false},
+ {"alternate-operator", "image: ${PULSE_E2E_SEED_IMAGE:+" + pin + "}\n", false},
+ {"short-literal-digest", "image: " + pin[:len(pin)-1] + "\n", false},
+ {"short-default-digest", "image: ${PULSE_E2E_SEED_IMAGE:-" + pin[:len(pin)-1] + "}\n", false},
+ {"long-default-digest", "image: ${PULSE_E2E_SEED_IMAGE:-" + pin + "a}\n", false},
+ {"invalid-default-digest", "image: ${PULSE_E2E_SEED_IMAGE:-" + strings.Replace(pin, "sha256:a", "sha256:g", 1) + "}\n", false},
+ {"missing-close", "image: ${PULSE_E2E_SEED_IMAGE:-" + pin + "\n", false},
+ {"default-suffix", "image: ${PULSE_E2E_SEED_IMAGE:-" + pin + ":other}\n", false},
+ {"override-suffix", "image: ${PULSE_E2E_SEED_IMAGE:-" + pin + "}/other\n", false},
+ {"multiline-value", "image:\n" + pin + "\n", false},
+ {"multiline-default", "image: ${PULSE_E2E_SEED_IMAGE:-\n" + pin + "}\n", false},
+ {"commented-pin", "# image: " + pin + "\nimage: alpine:latest\n", false},
+ } {
+ t.Run(tc.name, func(t *testing.T) {
+ if got := regexpDigestPinnedImage("alpine:3.24", tc.value); got != tc.want {
+ t.Fatalf("governed seed image admission = %t, want %t", got, tc.want)
+ }
+ })
+ }
+}