Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Correct alert reader recovery test fixtures

pulse-triage[bot]df23be07e867
diff --git a/frontend-modern/src/features/alerts/__tests__/DestinationsTab.recoveryediting.test.tsx b/frontend-modern/src/features/alerts/__tests__/DestinationsTab.recoveryediting.test.tsx
index adb41fbeb8..6cca0c3438 100644
--- a/frontend-modern/src/features/alerts/__tests__/DestinationsTab.recoveryediting.test.tsx
+++ b/frontend-modern/src/features/alerts/__tests__/DestinationsTab.recoveryediting.test.tsx
@@ -135,7 +135,7 @@ describe('DestinationsTab recovery while editing SMTP', () => {
setLoading(false);
expect(screen.queryByRole('textbox', { name: 'SMTP server' })).not.toBeInTheDocument();
expect(screen.queryByRole('button', { name: /Test/ })).not.toBeInTheDocument();
- fireEvent.click(screen.getByRole('button', { name: 'Retry', exact: true }));
+ fireEvent.click(screen.getByRole('button', { name: /^Retry$/ }));
expect(retry).toHaveBeenCalledOnce();
expect(screen.getByText(/Destination details and controls stay hidden/)).toBeInTheDocument();
setEmailConfig({ ...emailConfig(), server: 'smtp.current.example.test' });
diff --git a/frontend-modern/src/features/alerts/__tests__/useAlertDestinationsTabState.test.tsx b/frontend-modern/src/features/alerts/__tests__/useAlertDestinationsTabState.test.tsx
index a775693201..c698c5af0e 100644
--- a/frontend-modern/src/features/alerts/__tests__/useAlertDestinationsTabState.test.tsx
+++ b/frontend-modern/src/features/alerts/__tests__/useAlertDestinationsTabState.test.tsx
@@ -3,7 +3,7 @@ import { createSignal } from 'solid-js';
import { beforeEach, describe, expect, it, vi } from 'vitest';
import { AlertsAPI } from '@/api/alerts';
-import { NotificationsAPI } from '@/api/notifications';
+import { NotificationsAPI, type NotificationTestResult } from '@/api/notifications';
import { notificationStore } from '@/stores/notifications';
import { showErrorWithDetail } from '@/utils/toast';
@@ -87,9 +87,9 @@ describe('useAlertDestinationsTabState', () => {
vi.mocked(NotificationsAPI.getDeliveryLog).mockResolvedValue({ entries: [] } as never);
vi.mocked(AlertsAPI.getEvents).mockResolvedValue([]);
const [appriseConfig, setAppriseConfig] = createSignal(buildAppriseConfig());
- let accept!: (value: { success: boolean }) => void;
+ let accept!: (value: NotificationTestResult) => void;
vi.mocked(NotificationsAPI.testNotification).mockReturnValueOnce(
- new Promise((resolve) => {
+ new Promise<NotificationTestResult>((resolve) => {
accept = resolve;
}),
);
@@ -111,7 +111,7 @@ describe('useAlertDestinationsTabState', () => {
vi.mocked(notificationStore.success).mockClear();
vi.mocked(notificationStore.warning).mockClear();
vi.mocked(showErrorWithDetail).mockClear();
- accept({ success: true });
+ accept({ status: 'success', message: 'Test notification sent', deliveryPaused: false });
await pending;
expect(notificationStore.success).not.toHaveBeenCalled();
expect(notificationStore.warning).not.toHaveBeenCalled();