Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

List disk heat beside TrueNAS alert text

rcourtmane3e743b076db
diff --git a/docs/release-control/v6/internal/subsystems/unified-resources.md b/docs/release-control/v6/internal/subsystems/unified-resources.md
index 6a00c0a3c0..c9fb0f7d27 100644
--- a/docs/release-control/v6/internal/subsystems/unified-resources.md
+++ b/docs/release-control/v6/internal/subsystems/unified-resources.md
@@ -1118,7 +1118,9 @@ threshold.". The trigger comes from the alerts store's
`getDiskTemperatureThresholds`, which the table passes to the row build,
filter, counts, sort and issue. `isPhysicalDiskRunningHot` in
`features/storageBackups/diskTemperaturePresentation.ts` makes the same call
-for the Physical Disks verdict. The status dot keeps the source's own state.
+for the Physical Disks verdict. The heat reason follows any native TrueNAS
+alert text, and a hot disk's status dot turns warning though its source state
+stays `online`, because phones show only the dot.
`truenasPageModel.test.ts` and `TrueNASStorageTopologyTable.test.tsx` pin it.
The vSphere Datastores and Networks tables follow the same exception-first
Health column. `getVmwareDatastoreIssue` and `getVmwareNetworkIssue` return
diff --git a/frontend-modern/browser-verification/e3956fd0c9818451.json b/frontend-modern/browser-verification/e3956fd0c9818451.json
new file mode 100644
index 0000000000..4e012c9ea7
--- /dev/null
+++ b/frontend-modern/browser-verification/e3956fd0c9818451.json
@@ -0,0 +1,30 @@
+{
+ "version": 1,
+ "base_sha": "396bb5d517f14466795a2ccd2ff438fdba0ab077",
+ "verified_at": "2026-10-06T23:21:38Z",
+ "result": "passed",
+ "changed_paths": ["frontend-modern/src/features/truenas/truenasPageModel.ts"],
+ "content_sha256": {
+ "frontend-modern/src/features/truenas/truenasPageModel.ts": "91d7afa5bfb5b47692def18ae0a6e773ca47194d41faf0b57fa5c5c82d57d278"
+ },
+ "routes": ["/truenas/storage"],
+ "viewports": [
+ {
+ "width": 1440,
+ "height": 900
+ },
+ {
+ "width": 390,
+ "height": 844
+ }
+ ],
+ "states": [
+ "Private mock stack built from this exact content, with a local-only overlay (never committed) pinning TrueNAS mock disks: sdc (SAS, carries the native incident 'Device /dev/sdc has SMART test failures.') at 67C and sda (SATA, no incident) at 57C, factory disk temperature thresholds (SAS 65C, SATA 55C)",
+ "1440: sdc's Health cell reads 'Device /dev/sdc has SMART test failures.' with '+1', and its title lists that reason then 'Disk temperature is 67\u00b0C, at or above its 65\u00b0C alert threshold.'; before this change the heat reason was dropped whenever an incident had text. sda still reads 'Disk temperature is 57\u00b0C, at or above its 55\u00b0C alert threshold.'",
+ "390: the Health column stays phone-hidden; sda's status dot reads Warning and the cool sdd reads Online; no horizontal overflow (scrollWidth 390)"
+ ],
+ "interactions": [
+ "Loaded TrueNAS Storage at 1440x900 and 390x844 and read the sdc and sda Health cells, their titles and visible reason text, and the status dot titles",
+ "Moved sdc's pinned reading from 57C (under its SAS trigger: incident only, no heat) to 67C and reloaded to confirm the heat reason joins the incident text"
+ ]
+}
diff --git a/frontend-modern/src/features/truenas/__tests__/truenasPageModel.test.ts b/frontend-modern/src/features/truenas/__tests__/truenasPageModel.test.ts
index 1d29985b7c..3a88ea9308 100644
--- a/frontend-modern/src/features/truenas/__tests__/truenasPageModel.test.ts
+++ b/frontend-modern/src/features/truenas/__tests__/truenasPageModel.test.ts
@@ -676,6 +676,16 @@ describe('truenasPageModel', () => {
filterTrueNASStorageTopologyRows(rows, '', 'healthy', resolveFactory).map((row) => row.id),
).toEqual(['disk:disk-cool']);
+ // Native TrueNAS alert text leads, and the heat reason stays listed.
+ const hotWithIncident = makeResource({
+ ...hotDisk,
+ incidents: [{ code: 'truenas_smart', severity: 'info', summary: 'SMART test scheduled' }],
+ });
+ expect(getTrueNASStorageIssue(hotWithIncident, resolveFactory)?.reasons).toEqual([
+ 'SMART test scheduled',
+ 'Disk temperature is 56°C, at or above its 55°C alert threshold.',
+ ]);
+
// An NVMe at 63C is under its 70C trigger.
const warmNVMe = makeResource({
...hotDisk,
diff --git a/frontend-modern/src/features/truenas/truenasPageModel.ts b/frontend-modern/src/features/truenas/truenasPageModel.ts
index ceca216eae..75c13bcf0b 100644
--- a/frontend-modern/src/features/truenas/truenasPageModel.ts
+++ b/frontend-modern/src/features/truenas/truenasPageModel.ts
@@ -844,8 +844,10 @@ export function getTrueNASStorageIssue(
if (reasons.length === leading) {
for (const reason of resource.storage?.risk?.reasons ?? []) push(reason.summary);
for (const reason of resource.physicalDisk?.risk?.reasons ?? []) push(reason.summary);
- push(getTrueNASDiskHeatSummary(resource, resolveDiskTemperatureThresholds));
}
+ // Heat is Pulse's own judgement, not a restatement of TrueNAS state, so it
+ // stays listed beside any native alert text.
+ push(getTrueNASDiskHeatSummary(resource, resolveDiskTemperatureThresholds));
// A read-only dataset raises no incident, so its state tag is the only
// reason the provider gives. The drawer reads the same shared mapping.
if (reasons.length === leading && resource.storage?.topology === 'dataset') {