Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Keep backup evidence disclosure visible on phones

pulse-triage[bot]e695247131d7
diff --git a/docs/release-control/v6/internal/subsystems/storage-recovery.md b/docs/release-control/v6/internal/subsystems/storage-recovery.md
index ed397455bc..7adf39f1af 100644
--- a/docs/release-control/v6/internal/subsystems/storage-recovery.md
+++ b/docs/release-control/v6/internal/subsystems/storage-recovery.md
@@ -21,6 +21,21 @@
## Purpose
+### Coverage keeps its evidence disclosure visible on phones
+
+The existing Coverage chevron remains visible at phone widths, with the shared
+36px native target reserved beside the wrapped workload identity. Whole-row
+tapping remains a convenience, not the only visible route to evidence. The
+button retains its scoped accessible name, expanded state and controlled panel;
+its action must not also toggle the row. Keyboard activation, same-key polling,
+owner links and full workload/connection identity remain unchanged.
+
+Normal-suite `ProxmoxCoverageTable.test.tsx` checks the visible-control opt-out,
+single activation, keyboard/row paths and refresh continuity. Actual-App browser
+proof must inspect desktop and 320px pixels, ordinary disclosure clicks/taps,
+namesake isolation, task refresh/withdrawal and close-focus return. No shared
+primitive, read cadence, protection policy, backup or guest operation changes.
+
### Backup-server memory does not invent empty or current readings
The Backup servers table keeps a valid selected memory percentage when a partial
diff --git a/frontend-modern/src/features/proxmox/ProxmoxCoverageTable.tsx b/frontend-modern/src/features/proxmox/ProxmoxCoverageTable.tsx
index f2e53a317a..4dc734b793 100644
--- a/frontend-modern/src/features/proxmox/ProxmoxCoverageTable.tsx
+++ b/frontend-modern/src/features/proxmox/ProxmoxCoverageTable.tsx
@@ -644,6 +644,7 @@ export function ProxmoxCoverageTable(props: {
expanded={isExpanded()}
resourceLabel={getBackupWorkloadDisclosureLabel(row.workload)}
controlsId={detailRowId()}
+ hideWhenRowTappableOnMobile={false}
onToggle={() => props.onToggleExpand(row.key)}
/>
<div class="min-w-0 flex-1">
diff --git a/frontend-modern/src/features/proxmox/__tests__/ProxmoxCoverageTable.test.tsx b/frontend-modern/src/features/proxmox/__tests__/ProxmoxCoverageTable.test.tsx
index 1532d65cfb..289f2c8eba 100644
--- a/frontend-modern/src/features/proxmox/__tests__/ProxmoxCoverageTable.test.tsx
+++ b/frontend-modern/src/features/proxmox/__tests__/ProxmoxCoverageTable.test.tsx
@@ -70,6 +70,54 @@ const headerTexts = () =>
afterEach(cleanup);
describe('ProxmoxCoverageTable column visibility', () => {
+ it('keeps a visible native phone disclosure through row activation and refresh [visible-coverage-disclosure]', () => {
+ const [rows, setRows] = createSignal([row]);
+ const [expanded, setExpanded] = createSignal<string | null>(null);
+ renderInRouter(() => (
+ <ProxmoxCoverageTable
+ rows={rows()}
+ hasAnyRows
+ emptyIcon={<span />}
+ emptyTitle=""
+ emptyDescription=""
+ sortKey={() => 'posture'}
+ sortDirection={() => 'asc'}
+ onSort={() => {}}
+ expandedKey={expanded()}
+ onToggleExpand={(key) => setExpanded(expanded() === key ? null : key)}
+ layoutWidth={() => 320}
+ showTaskColumn
+ />
+ ));
+
+ const toggle = screen.getByRole('button', { name: /Expand details for web/ });
+ const summary = toggle.closest('tr')!;
+ // CSS hit testing is covered by the actual-App browser proof. Keep the
+ // Coverage opt-out explicit: row tapping must not hide its native control.
+ expect(toggle).not.toHaveClass('sr-only');
+ expect(toggle).toHaveClass('h-9', 'w-9');
+ fireEvent.click(toggle);
+ expect(expanded()).toBe(row.key);
+ expect(toggle).toHaveAttribute('aria-expanded', 'true');
+ expect(document.getElementById(toggle.getAttribute('aria-controls')!)).toBeInTheDocument();
+
+ toggle.focus();
+ const panel = screen.getByTestId('proxmox-coverage-detail');
+ setRows([{ ...row, pbsCount: 2 }]);
+ expect(screen.getByTestId('proxmox-coverage-detail')).toBe(panel);
+ expect(toggle).toHaveFocus();
+ fireEvent.keyDown(toggle, { key: ' ' });
+ expect(expanded()).toBeNull();
+ fireEvent.keyDown(toggle, { key: 'Enter' });
+ expect(expanded()).toBe(row.key);
+
+ fireEvent.click(within(summary).getByText('web', { exact: true }));
+ expect(expanded()).toBeNull();
+ fireEvent.click(within(summary).getByText('web', { exact: true }));
+ expect(expanded()).toBe(row.key);
+ expect(screen.getAllByTestId('proxmox-coverage-detail')).toHaveLength(1);
+ });
+
it('resets a deliberate task preview when another workload is opened, not on a refresh', () => {
const tasks = Array.from({ length: 24 }, (_, index) =>
identityTask({ id: `candidate-${index}`, startTime: 'invalid' }),