Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.
Go aialertsdashboarddockerdocker-monitoringgohomelabinfrastructure-monitoringkubernetesmonitoringmspproxmoxproxmox-backup-serverproxmox-mail-gatewayproxmox-veself-hostedtruenastypescriptvspherewebhooks
Keep access editor actions visible on short screens
pulse-triage[bot]e8cc0e83504e
diff --git a/frontend-modern/browser-verification/05dc790fc719f9b8.json b/frontend-modern/browser-verification/05dc790fc719f9b8.jsonnew file mode 100644index 0000000000..67c890b308--- /dev/null+++ b/frontend-modern/browser-verification/05dc790fc719f9b8.json@@ -0,0 +1,48 @@+{+ "version": 1,+ "base_sha": "749a884113103684f65567cf2fc192f56e9647ea",+ "verified_at": "2026-11-03T16:56:59Z",+ "result": "passed",+ "changed_paths": [+ "frontend-modern/src/components/Settings/RolesEditorDialog.tsx",+ "frontend-modern/src/components/Settings/UserAssignmentsDialog.tsx"+ ],+ "content_sha256": {+ "frontend-modern/src/components/Settings/RolesEditorDialog.tsx": "f2c74e0bc441d3570a7b925e70c61c749bd8f0edd9ea391e4605ab05fcce090f",+ "frontend-modern/src/components/Settings/UserAssignmentsDialog.tsx": "a3cd5c04cf0a398cb7ac51c5ddbf5272ec23610de7018205d6e0f7dbaedd5d28"+ },+ "routes": [+ "/settings/security-users",+ "/settings/security-roles"+ ],+ "viewports": [+ {+ "width": 1440,+ "height": 900+ },+ {+ "width": 390,+ "height": 640+ },+ {+ "width": 320,+ "height": 568+ },+ {+ "width": 844,+ "height": 390+ }+ ],+ "states": [+ "Both existing access editors with six synthetic roles, saved assignments, twelve saved permission pairs and six editable permission rows; top and bottom scroll positions.",+ "Save, Cancel and Close remain entirely in the viewport and hit-testable at desktop, phone and dark landscape sizes. All last form content remains reachable.",+ "Synthetic HTTP save failures retain drafts/selected roles and leave both dismissal paths available; capability withdrawal removes the current reader's dialog and inventory."+ ],+ "interactions": [+ "Open the correct saved user/role from the real Settings panel using Enter; scroll the real dialog body to its end.",+ "Edit a role name and submit through the production state/API client to a synthetic refusing HTTP producer. Verify draft retention; Cancel via pointer in the final source.",+ "Escape and current-reader capability withdrawal dismiss the real editors without successful access mutations."+ ],+ "browser": "Chromium 141.0.7390.37; Playwright 1.56.1 (matches integration lock)",+ "notes": "Comparable parent/final SettingsPageShell, panels, state hooks, API client, dialogs and production CSS with identical synthetic fixtures and viewports. 74 baseline and 142 final checks; 12 comparable capture pairs all opened with the native image tool. Evidence-only page entry supplies an admitted synthetic reader, not full authenticated App/IdP/native account recovery. One initial role-fieldset layout failed browser scroll validation and was corrected before this final pass. No full App build or VM suite is claimed."+}diff --git a/frontend-modern/src/components/Settings/RolesEditorDialog.tsx b/frontend-modern/src/components/Settings/RolesEditorDialog.tsxindex dff2b340cd..46a88b3394 100644--- a/frontend-modern/src/components/Settings/RolesEditorDialog.tsx+++ b/frontend-modern/src/components/Settings/RolesEditorDialog.tsx@@ -36,8 +36,8 @@ export const RolesEditorDialog: Component<RolesEditorDialogProps> = (props) => (closeOnBackdrop={false}ariaLabel={props.editingRole ? 'Edit role' : 'New role'}>- <div class="w-full max-h-[92vh] overflow-hidden">- <div class="flex items-start justify-between gap-3 px-4 sm:px-6 py-4 border-b border-border">+ <div class="flex min-h-0 w-full flex-col">+ <div class="flex shrink-0 items-start justify-between gap-3 px-4 sm:px-6 py-4 border-b border-border"><h3 class="text-lg font-semibold text-base-content">{props.editingRole ? 'Edit Role' : 'New Role'}</h3>@@ -53,140 +53,139 @@ export const RolesEditorDialog: Component<RolesEditorDialogProps> = (props) => (</button></div>- <fieldset- disabled={props.saving}- class="px-4 sm:px-6 py-4 space-y-4 max-h-[70vh] overflow-y-auto"- >- <div class="grid grid-cols-1 sm:grid-cols-2 gap-4">- <div class="space-y-1">- <label for="role-editor-id" class="block text-sm font-medium text-base-content">- Role ID- </label>- <input- id="role-editor-id"- type="text"- value={props.formId}- onInput={(event) => props.onFormIdInput(event.currentTarget.value)}- placeholder="e.g., custom-auditor"- disabled={!!props.editingRole}- class="w-full rounded-md border border-border bg-surface px-3 py-2 text-sm shadow-xs focus:border-blue-500 focus:outline-hidden focus:ring-2 focus:ring-blue-200 dark:focus:border-blue-400 dark:focus:ring-blue-900/25 disabled:opacity-50"- />+ <div class="min-h-0 overflow-y-auto">+ <fieldset disabled={props.saving} class="px-4 sm:px-6 py-4 space-y-4">+ <div class="grid grid-cols-1 sm:grid-cols-2 gap-4">+ <div class="space-y-1">+ <label for="role-editor-id" class="block text-sm font-medium text-base-content">+ Role ID+ </label>+ <input+ id="role-editor-id"+ type="text"+ value={props.formId}+ onInput={(event) => props.onFormIdInput(event.currentTarget.value)}+ placeholder="e.g., custom-auditor"+ disabled={!!props.editingRole}+ class="w-full rounded-md border border-border bg-surface px-3 py-2 text-sm shadow-xs focus:border-blue-500 focus:outline-hidden focus:ring-2 focus:ring-blue-200 dark:focus:border-blue-400 dark:focus:ring-blue-900/25 disabled:opacity-50"+ />+ </div>+ <div class="space-y-1">+ <label for="role-editor-name" class="block text-sm font-medium text-base-content">+ Role Name+ </label>+ <input+ id="role-editor-name"+ type="text"+ value={props.formName}+ onInput={(event) => props.onFormNameInput(event.currentTarget.value)}+ placeholder="e.g., Custom Auditor"+ class="w-full rounded-md border border-border bg-surface px-3 py-2 text-sm shadow-xs focus:border-blue-500 focus:outline-hidden focus:ring-2 focus:ring-blue-200 dark:focus:border-blue-400 dark:focus:ring-blue-900/25"+ />+ </div></div><div class="space-y-1">- <label for="role-editor-name" class="block text-sm font-medium text-base-content">- Role Name+ <label+ for="role-editor-description"+ class="block text-sm font-medium text-base-content"+ >+ Description</label><input- id="role-editor-name"+ id="role-editor-description"type="text"- value={props.formName}- onInput={(event) => props.onFormNameInput(event.currentTarget.value)}- placeholder="e.g., Custom Auditor"- class="w-full rounded-md border border-border bg-surface px-3 py-2 text-sm shadow-xs focus:border-blue-500 focus:outline-hidden focus:ring-2 focus:ring-blue-200 dark:focus:border-blue-400 dark:focus:ring-blue-900/25"+ value={props.formDescription}+ onInput={(event) => props.onFormDescriptionInput(event.currentTarget.value)}+ placeholder="Brief description of this role's purpose"+ class="w-full rounded-md border border-border bg-surface px-3 py-2 text-sm text-base-content shadow-xs focus:border-blue-500 focus:outline-hidden focus:ring-2 focus:ring-blue-200 dark:focus:border-blue-400 dark:focus:ring-blue-900/25"/></div>- </div>- <div class="space-y-1">- <label- for="role-editor-description"- class="block text-sm font-medium text-base-content"- >- Description- </label>- <input- id="role-editor-description"- type="text"- value={props.formDescription}- onInput={(event) => props.onFormDescriptionInput(event.currentTarget.value)}- placeholder="Brief description of this role's purpose"- class="w-full rounded-md border border-border bg-surface px-3 py-2 text-sm text-base-content shadow-xs focus:border-blue-500 focus:outline-hidden focus:ring-2 focus:ring-blue-200 dark:focus:border-blue-400 dark:focus:ring-blue-900/25"- />- </div>- <div class="space-y-3 pt-2">- <div class="flex flex-col items-start gap-2 sm:flex-row sm:items-center sm:justify-between">- <span class="block text-sm font-medium text-base-content">Permissions</span>- <button- type="button"- onClick={props.onAddPermission}- class="text-xs font-medium text-blue-600 hover:text-blue-700 dark:text-blue-300 flex items-center gap-1"- >- <Plus class="w-3 h-3" /> Add Permission- </button>- </div>+ <div class="space-y-3 pt-2">+ <div class="flex flex-col items-start gap-2 sm:flex-row sm:items-center sm:justify-between">+ <span class="block text-sm font-medium text-base-content">Permissions</span>+ <button+ type="button"+ onClick={props.onAddPermission}+ class="text-xs font-medium text-blue-600 hover:text-blue-700 dark:text-blue-300 flex items-center gap-1"+ >+ <Plus class="w-3 h-3" /> Add Permission+ </button>+ </div>- <div class="space-y-2">- <For each={props.formPermissions}>- {(permission, index) => (- <div class="flex flex-col sm:flex-row sm:items-center gap-2">- <FormSelect- label={`Permission ${index() + 1} action`}- labelClass="sr-only"- fieldBaseClass="contents"- value={permission.action}- onChange={(event) =>- props.onUpdatePermission(index(), 'action', event.currentTarget.value)- }- selectBaseClass="w-full sm:flex-1 rounded-md border border-border bg-surface px-2 py-1.5 text-sm text-base-content"- >- <Show- when={- !RBAC_PERMISSION_ACTIONS.some((action) => action === permission.action)+ <div class="space-y-2">+ <For each={props.formPermissions}>+ {(permission, index) => (+ <div class="flex flex-col sm:flex-row sm:items-center gap-2">+ <FormSelect+ label={`Permission ${index() + 1} action`}+ labelClass="sr-only"+ fieldBaseClass="contents"+ value={permission.action}+ onChange={(event) =>+ props.onUpdatePermission(index(), 'action', event.currentTarget.value)}+ selectBaseClass="w-full sm:flex-1 rounded-md border border-border bg-surface px-2 py-1.5 text-sm text-base-content">- <option value={permission.action}>{permission.action}</option>- </Show>- <For each={RBAC_PERMISSION_ACTIONS}>- {(action) => <option value={action}>{action}</option>}- </For>- </FormSelect>- <span class="hidden sm:inline text-slate-400 text-sm">:</span>- <FormSelect- label={`Permission ${index() + 1} resource`}- labelClass="sr-only"- fieldBaseClass="contents"- value={permission.resource}- onChange={(event) =>- props.onUpdatePermission(index(), 'resource', event.currentTarget.value)- }- selectBaseClass="w-full sm:flex-1 rounded-md border bg-surface px-2 py-1.5 text-sm text-base-content"- >- <Show- when={- !RBAC_PERMISSION_RESOURCES.some(- (resource) => resource === permission.resource,- )+ <Show+ when={+ !RBAC_PERMISSION_ACTIONS.some((action) => action === permission.action)+ }+ >+ <option value={permission.action}>{permission.action}</option>+ </Show>+ <For each={RBAC_PERMISSION_ACTIONS}>+ {(action) => <option value={action}>{action}</option>}+ </For>+ </FormSelect>+ <span class="hidden sm:inline text-slate-400 text-sm">:</span>+ <FormSelect+ label={`Permission ${index() + 1} resource`}+ labelClass="sr-only"+ fieldBaseClass="contents"+ value={permission.resource}+ onChange={(event) =>+ props.onUpdatePermission(index(), 'resource', event.currentTarget.value)}+ selectBaseClass="w-full sm:flex-1 rounded-md border bg-surface px-2 py-1.5 text-sm text-base-content">- <option value={permission.resource}>{permission.resource}</option>- </Show>- <For each={RBAC_PERMISSION_RESOURCES}>- {(resource) => <option value={resource}>{resource}</option>}- </For>- </FormSelect>- <button- type="button"- onClick={() => props.onRemovePermission(index())}- disabled={props.formPermissions.length <= 1}- aria-label="Remove permission"- title="Remove permission"- class="self-end sm:self-auto p-1.5 text-slate-400 hover:text-red-500 disabled:opacity-30"- >- <Trash2 class="w-4 h-4" />- </button>- </div>- )}- </For>+ <Show+ when={+ !RBAC_PERMISSION_RESOURCES.some(+ (resource) => resource === permission.resource,+ )+ }+ >+ <option value={permission.resource}>{permission.resource}</option>+ </Show>+ <For each={RBAC_PERMISSION_RESOURCES}>+ {(resource) => <option value={resource}>{resource}</option>}+ </For>+ </FormSelect>+ <button+ type="button"+ onClick={() => props.onRemovePermission(index())}+ disabled={props.formPermissions.length <= 1}+ aria-label="Remove permission"+ title="Remove permission"+ class="self-end sm:self-auto p-1.5 text-slate-400 hover:text-red-500 disabled:opacity-30"+ >+ <Trash2 class="w-4 h-4" />+ </button>+ </div>+ )}+ </For>+ </div></div>- </div>- </fieldset>- <Show when={props.actionError}>- <InlineNotice tone="danger" role="alert" aria-live="polite">- {props.actionError}- </InlineNotice>- </Show>+ </fieldset>+ <Show when={props.actionError}>+ <InlineNotice tone="danger" role="alert" aria-live="polite">+ {props.actionError}+ </InlineNotice>+ </Show>+ </div>- <div class="grid grid-cols-1 sm:flex sm:items-center sm:justify-end gap-3 px-4 sm:px-6 py-4 border-t border-border">+ <div class="grid shrink-0 grid-cols-1 sm:flex sm:items-center sm:justify-end gap-3 px-4 sm:px-6 py-4 border-t border-border"><buttontype="button"onClick={props.onClose}diff --git a/frontend-modern/src/components/Settings/UserAssignmentsDialog.tsx b/frontend-modern/src/components/Settings/UserAssignmentsDialog.tsxindex 036fd5a72b..cf17dc9eec 100644--- a/frontend-modern/src/components/Settings/UserAssignmentsDialog.tsx+++ b/frontend-modern/src/components/Settings/UserAssignmentsDialog.tsx@@ -33,8 +33,8 @@ export const UserAssignmentsDialog: Component<UserAssignmentsDialogProps> = (procloseOnBackdrop={false}ariaLabel={`Manage access: ${props.editingUser ? getUserIdentityDisplayName(props.editingUser) : 'user'}`}>- <div class="w-full max-h-[92vh] overflow-hidden">- <div class="flex items-start justify-between gap-3 px-4 sm:px-6 py-4 border-b border-border">+ <div class="flex min-h-0 w-full flex-col">+ <div class="flex shrink-0 items-start justify-between gap-3 px-4 sm:px-6 py-4 border-b border-border"><div><h3 class="text-lg font-semibold text-base-content">Manage Access:{' '}@@ -63,7 +63,7 @@ export const UserAssignmentsDialog: Component<UserAssignmentsDialogProps> = (pro</button></div>- <div class="px-4 sm:px-6 py-6 space-y-8 max-h-[70vh] overflow-y-auto">+ <div class="min-h-0 overflow-y-auto px-4 sm:px-6 py-6 space-y-8"><Show when={props.actionError}>{(message) => (<InlineNotice tone="danger" role="alert" aria-live="polite">@@ -164,7 +164,7 @@ export const UserAssignmentsDialog: Component<UserAssignmentsDialogProps> = (pro</div></div>- <div class="grid grid-cols-1 sm:flex sm:items-center sm:justify-end gap-3 px-4 sm:px-6 py-5 border-t border-border bg-surface-alt rounded-b-xl">+ <div class="grid shrink-0 grid-cols-1 sm:flex sm:items-center sm:justify-end gap-3 px-4 sm:px-6 py-5 border-t border-border bg-surface-alt rounded-b-xl"><buttontype="button"onClick={props.onClose}