Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Lead Patrol rule removal help with the existing UI

pulse-triage[bot]e8fe8d4af159
diff --git a/docs/AI.md b/docs/AI.md
index f23b965ece..5ee09e222f 100644
--- a/docs/AI.md
+++ b/docs/AI.md
@@ -237,13 +237,39 @@ Dismissed and resolved findings persist across Pulse restarts.
#### Remove a rule created by mistake
-In v6.4.5, **Create rule** has no corresponding rule-list or delete control in
-the UI. **Reopen** undoes an individual finding's dismissal, not a separately
-created rule. The existing API can list rules and delete one by its exact ID.
-Deleting a created rule allows future matching findings to appear again; it
+**Reopen** undoes an individual finding's dismissal, not a separately created
+rule. Removing a created rule allows future matching findings to appear again; it
does not resolve a problem or automatically reopen previously dismissed
findings. It leaves the other rules and finding history intact.
+##### Use the rule controls when available
+
+1. Sign in as an authorised administrator and select the correct organisation.
+ Open **Patrol → Activity** and expand **Suppression rules**, or follow
+ **Manage suppression rules** from the finding's rule-creation control.
+2. Match the resource, category, reason and **Rule ID** before choosing
+ **Remove rule**. **All resources** or **All categories** means a broad rule,
+ not just the finding you were looking at.
+3. Review the exact scope in the confirmation and choose **Remove this rule**.
+ **Cancel** leaves the rules unchanged.
+4. Check that the selected row disappears and Pulse reports **Rule removed**.
+ If removal cannot be confirmed, choose **Reload rules** and check that exact
+ ID before trying again: a lost response does not prove deletion failed.
+
+After an organisation or access change, reload the rules in the intended
+organisation before making another change. If you cannot load or verify them,
+stop; do not bypass the failure with the console workaround. Other rules may
+still cover the same scope, so removal does not guarantee a new finding.
+To undo an individual dismissal, use **Reopen finding** in **Finding options
+and history** instead.
+
+##### Older builds without rule controls
+
+In v6.4.5, **Create rule** has no corresponding rule-list or delete control in
+the UI. If your build has no **Suppression rules** control, the existing API
+workaround below can remove one manual rule without an upgrade or restart.
+It is not a way around denied access or a failed removal in the UI.
+
For a rule made with **Create rule**, sign in normally to Pulse in an
authorised administrator's browser session, select the correct organisation,
and open that Pulse tab's developer console. Review the following snippet
diff --git a/frontend-modern/public/docs/AI.md b/frontend-modern/public/docs/AI.md
index f23b965ece..5ee09e222f 100644
--- a/frontend-modern/public/docs/AI.md
+++ b/frontend-modern/public/docs/AI.md
@@ -237,13 +237,39 @@ Dismissed and resolved findings persist across Pulse restarts.
#### Remove a rule created by mistake
-In v6.4.5, **Create rule** has no corresponding rule-list or delete control in
-the UI. **Reopen** undoes an individual finding's dismissal, not a separately
-created rule. The existing API can list rules and delete one by its exact ID.
-Deleting a created rule allows future matching findings to appear again; it
+**Reopen** undoes an individual finding's dismissal, not a separately created
+rule. Removing a created rule allows future matching findings to appear again; it
does not resolve a problem or automatically reopen previously dismissed
findings. It leaves the other rules and finding history intact.
+##### Use the rule controls when available
+
+1. Sign in as an authorised administrator and select the correct organisation.
+ Open **Patrol → Activity** and expand **Suppression rules**, or follow
+ **Manage suppression rules** from the finding's rule-creation control.
+2. Match the resource, category, reason and **Rule ID** before choosing
+ **Remove rule**. **All resources** or **All categories** means a broad rule,
+ not just the finding you were looking at.
+3. Review the exact scope in the confirmation and choose **Remove this rule**.
+ **Cancel** leaves the rules unchanged.
+4. Check that the selected row disappears and Pulse reports **Rule removed**.
+ If removal cannot be confirmed, choose **Reload rules** and check that exact
+ ID before trying again: a lost response does not prove deletion failed.
+
+After an organisation or access change, reload the rules in the intended
+organisation before making another change. If you cannot load or verify them,
+stop; do not bypass the failure with the console workaround. Other rules may
+still cover the same scope, so removal does not guarantee a new finding.
+To undo an individual dismissal, use **Reopen finding** in **Finding options
+and history** instead.
+
+##### Older builds without rule controls
+
+In v6.4.5, **Create rule** has no corresponding rule-list or delete control in
+the UI. If your build has no **Suppression rules** control, the existing API
+workaround below can remove one manual rule without an upgrade or restart.
+It is not a way around denied access or a failed removal in the UI.
+
For a rule made with **Create rule**, sign in normally to Pulse in an
authorised administrator's browser session, select the correct organisation,
and open that Pulse tab's developer console. Review the following snippet
diff --git a/scripts/tests/test_patrol_rule_help.py b/scripts/tests/test_patrol_rule_help.py
index 2db8927b59..9c53781603 100644
--- a/scripts/tests/test_patrol_rule_help.py
+++ b/scripts/tests/test_patrol_rule_help.py
@@ -74,6 +74,49 @@ class PatrolRuleHelpTests(unittest.TestCase):
def test_shipped_help_matches_source(self):
self.assertEqual(GUIDE.read_bytes(), SHIPPED_GUIDE.read_bytes())
+ def test_rule_controls_precede_the_older_console_workaround(self):
+ guide = GUIDE.read_text()
+ current, older = guide.split("##### Older builds without rule controls\n", 1)
+ self.assertIn("##### Use the rule controls when available", current)
+ self.assertIn("**Patrol → Activity**", current)
+ self.assertNotIn("```javascript", current)
+ self.assertIn("In v6.4.5", older)
+ self.assertIn("without an upgrade or restart", older)
+ self.assertIn("not a way around denied access", older)
+
+ def test_documented_controls_match_the_existing_production_flow(self):
+ guide = GUIDE.read_text().split("##### Older builds without rule controls\n", 1)[0]
+ ui = (ROOT / "frontend-modern/src/features/patrol/PatrolSuppressionRules.tsx").read_text()
+ for label in ["Suppression rules", "Remove rule", "Remove this rule", "Cancel",
+ "Reload rules", "Rule ID", "All resources", "All categories"]:
+ with self.subTest(label=label):
+ self.assertIn(f"**{label}**", guide)
+ self.assertIn(label, ui)
+ for path in ["components/AI/FindingsPanel.tsx",
+ "features/patrol/PatrolAttentionWorkbench.tsx"]:
+ creator = (ROOT / "frontend-modern/src" / path).read_text()
+ self.assertIn("Manage suppression rules", creator)
+ self.assertIn("**Manage suppression rules**", guide)
+ self.assertIn("/patrol/activity#patrol-suppression-rules", ui)
+
+ def test_uncertain_ui_results_require_readback_not_console_deletion(self):
+ guide = GUIDE.read_text().split("##### Older builds without rule controls\n", 1)[0]
+ self.assertIn("selected row disappears", guide)
+ self.assertIn("**Rule removed**", guide)
+ self.assertIn("check that exact\n ID before trying again", guide)
+ self.assertIn("lost response does not prove deletion failed", guide)
+ self.assertIn("do not bypass the failure with the console workaround", guide)
+ self.assertIn("organisation or access change", guide)
+ self.assertIn("Other rules may\nstill cover the same scope", guide)
+
+ def test_help_distinguishes_manual_rules_from_individual_dismissals(self):
+ guide = GUIDE.read_text().split("##### Older builds without rule controls\n", 1)[0]
+ self.assertIn("not a separately created\nrule", guide)
+ self.assertIn("automatically reopen previously dismissed", guide)
+ self.assertIn("other rules and finding history intact", guide)
+ self.assertIn("**Reopen finding**", guide)
+ self.assertIn("**Finding options\nand history**", guide)
+
def test_cancel_is_read_only_and_hides_finding_decisions(self):
result = self.run_snippet()
self.assert_no_delete(result)