Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Close TrueNAS fixture clients before their owning tests finish

pulse-triage[bot]e9072d0b0ff0
diff --git a/internal/truenas/client_test.go b/internal/truenas/client_test.go
index d2446ec2aa..724796cd04 100644
--- a/internal/truenas/client_test.go
+++ b/internal/truenas/client_test.go
@@ -1974,6 +1974,9 @@ func mustClientForServer(t *testing.T, serverURL string, config ClientConfig) *C
t.Fatalf("NewClient() error = %v", err)
}
client.allowInsecureRPC = true
+ // The fixture owns persistent sessions too. Stop and join their keepalive
+ // before later tests replace the package logger to inspect close records.
+ t.Cleanup(client.Close)
return client
}
@@ -2545,3 +2548,44 @@ func TestSystemTelemetryFailureCategoriesAreBounded(t *testing.T) {
}
}
}
+
+func TestClientFixtureOwnsRPCSessionLifetime(t *testing.T) {
+ var client *Client
+ var session *trueNASRPCClient
+ // Also clean up the adverse control when the old helper is restored.
+ t.Cleanup(func() {
+ if client != nil {
+ client.Close()
+ }
+ })
+ t.Run("fixture lifetime", func(t *testing.T) {
+ fixture := newProtocolFixture(t, func(_ int, request trueNASRPCRequest) protocolFixtureReply {
+ if request.Method == "auth.login_ex" {
+ return protocolFixtureReply{result: map[string]any{"response_type": "SUCCESS"}}
+ }
+ return protocolFixtureReply{result: []any{}}
+ }, nil)
+ client = mustClientForServer(t, fixture.server.URL, ClientConfig{APIKey: "fixture-key", InsecureSkipVerify: true})
+ if _, err := client.GetPools(context.Background()); err != nil {
+ t.Fatal(err)
+ }
+ session = client.rpc
+ if session == nil || session.keepaliveDone == nil {
+ t.Fatal("fixture did not open a maintained RPC session")
+ }
+ })
+ if client == nil || session == nil {
+ t.Fatal("fixture failed before opening its session")
+ }
+ client.rpcMu.Lock()
+ closed, retained := client.closed, client.rpc != nil
+ client.rpcMu.Unlock()
+ if !closed || retained {
+ t.Fatal("fixture cleanup left its authenticated RPC client open")
+ }
+ select {
+ case <-session.keepaliveDone:
+ default:
+ t.Fatal("fixture cleanup did not join its session keepalive")
+ }
+}