Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Keep Patrol rule scope readable with long reasons

pulse-triage[bot]e90b10f9f2a8
diff --git a/docs/release-control/v6/internal/subsystems/ai-runtime.md b/docs/release-control/v6/internal/subsystems/ai-runtime.md
index 271e66327f..60eb02d9c3 100644
--- a/docs/release-control/v6/internal/subsystems/ai-runtime.md
+++ b/docs/release-control/v6/internal/subsystems/ai-runtime.md
@@ -36,6 +36,8 @@ API/component controls plus authenticated handler/store controls verify these
boundaries; source/browser proof does not establish installed or reporter
acceptance.
+Manual-rule confirmation retains a readable scope and exact ID with a scrollable long reason and separate action footer. This is an existing-flow accessibility repair, not a change to deletion, finding history or server authority.
+
### Fully cached Patrol usage — issues #2118 / #2350
diff --git a/docs/release-control/v6/internal/subsystems/api-contracts.md b/docs/release-control/v6/internal/subsystems/api-contracts.md
index 29acf094e6..28dff957bb 100644
--- a/docs/release-control/v6/internal/subsystems/api-contracts.md
+++ b/docs/release-control/v6/internal/subsystems/api-contracts.md
@@ -22,6 +22,11 @@
### Confirmed Patrol rule operations preserve tenant context — issue #2528
+The manual-rule confirmation presents the returned exact ID and scope before a
+keyboard-scrollable reason; the readable header and Cancel/Remove footer remain
+separate from long data. This does not truncate the stored reason or change
+authorised pre-read, one DELETE, readback or uncertainty handling.
+
The frontend consumes the existing GET/DELETE suppression endpoints without a
wire or permission change. The optional client expectedOrgID pins the request
header and checks context before and after CSRF preparation; retry:false
diff --git a/docs/release-control/v6/internal/subsystems/frontend-primitives.md b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
index 13d0941b34..61b3fdc204 100644
--- a/docs/release-control/v6/internal/subsystems/frontend-primitives.md
+++ b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
@@ -28,6 +28,8 @@ dispatch, respects cancellation after asynchronous CSRF preparation and makes
no automatic auth/tenant/CSRF/rate-limit replay. Existing caller defaults are
unchanged. Tests exercise these safeguards with real request options.
+Patrol manual-rule confirmation keeps its title and safe Cancel/Remove controls outside a keyboard-focusable scrolling scope/reason region. Long multiline reasons cannot clip identifiers or the action footer on a narrow viewport. The region permits both keyboard and pointer review without changing confirmation state or sending a mutation.
+
All drawer History fallbacks must distinguish current observations from retained, unavailable or freshness-unknown guest readings, using original memory evidence and filesystem read reasons.
diff --git a/docs/release-control/v6/internal/subsystems/patrol-intelligence.md b/docs/release-control/v6/internal/subsystems/patrol-intelligence.md
index 4753a5c328..e54400ed0e 100644
--- a/docs/release-control/v6/internal/subsystems/patrol-intelligence.md
+++ b/docs/release-control/v6/internal/subsystems/patrol-intelligence.md
@@ -35,6 +35,8 @@ readback failure. Browser evidence must cover creation through removal and the
actual existing links on desktop and narrow viewports. Synthetic proof is not
publication or the reporter's own removal.
+Long rule reasons remain scrollable without hiding the confirmation heading or Cancel/Remove controls. Resource/category and exact rule ID precede the reason, so confirmation can be reviewed on narrow displays without clipping safety information.
+
### Canonical Patrol and Assistant continuation, 2026-09-07
diff --git a/frontend-modern/browser-tests/patrol-rule-removal-long-reason.cjs b/frontend-modern/browser-tests/patrol-rule-removal-long-reason.cjs
new file mode 100644
index 0000000000..83c5835014
--- /dev/null
+++ b/frontend-modern/browser-tests/patrol-rule-removal-long-reason.cjs
@@ -0,0 +1,29 @@
+// Measure a long existing reason without creating or deleting any rule.
+const fs = require('node:fs');
+const path = require('node:path');
+const {
+ journey,
+ report,
+ output,
+} = require('/workspace/frontend-modern/browser-tests/patrol-rule-removal.cjs');
+(async () => {
+ try {
+ await journey('/workspace/frontend-modern', 'webkit', 320, false, true, 'long');
+ report.result = 'passed';
+ } catch (error) {
+ report.result = 'failed';
+ report.failure = error.message;
+ throw error;
+ } finally {
+ report.cleanup = {
+ all_cases_closed: report.cases.every(
+ (c) => c.cleanup.browser_closed && c.cleanup.server_closed,
+ ),
+ };
+ fs.writeFileSync(path.join(output, 'long-result.json'), JSON.stringify(report, null, 2));
+ }
+ console.log(JSON.stringify({ result: report.result, cleanup: report.cleanup }));
+})().catch((error) => {
+ console.error(error.stack);
+ process.exitCode = 1;
+});
diff --git a/frontend-modern/browser-tests/patrol-rule-removal-visual.cjs b/frontend-modern/browser-tests/patrol-rule-removal-visual.cjs
new file mode 100644
index 0000000000..bda867d1cb
--- /dev/null
+++ b/frontend-modern/browser-tests/patrol-rule-removal-visual.cjs
@@ -0,0 +1,37 @@
+// Complete viewport-only visual inspection without replaying successful mutations.
+const fs = require('node:fs');
+const path = require('node:path');
+const {
+ journey,
+ report,
+ output,
+} = require('/workspace/frontend-modern/browser-tests/patrol-rule-removal.cjs');
+(async () => {
+ try {
+ await journey('/workspace/frontend-modern', 'chromium', 1365, false, true, true);
+ await journey('/workspace/frontend-modern', 'webkit', 320, false, true, true);
+ report.result = 'passed';
+ } catch (error) {
+ report.result = 'failed';
+ report.failure = error.message;
+ throw error;
+ } finally {
+ report.cleanup = {
+ all_cases_closed: report.cases.every(
+ (c) => c.cleanup.browser_closed && c.cleanup.server_closed,
+ ),
+ };
+ fs.writeFileSync(path.join(output, 'result.json'), JSON.stringify(report, null, 2));
+ }
+ console.log(
+ JSON.stringify({
+ result: report.result,
+ cases: report.cases.length,
+ captures: report.captures.length,
+ cleanup: report.cleanup,
+ }),
+ );
+})().catch((error) => {
+ console.error(error.stack);
+ process.exitCode = 1;
+});
diff --git a/frontend-modern/browser-tests/patrol-rule-removal.cjs b/frontend-modern/browser-tests/patrol-rule-removal.cjs
index bc3569bf3a..c343f2bbe8 100644
--- a/frontend-modern/browser-tests/patrol-rule-removal.cjs
+++ b/frontend-modern/browser-tests/patrol-rule-removal.cjs
@@ -13,7 +13,10 @@ const files = [
'src/features/patrol/PatrolAttentionWorkbench.tsx',
'src/features/patrol/PatrolSuppressionRules.tsx',
];
-const output = '/workspace/tmp/patrol-rule-proof/browser';
+const output =
+ require.main === module
+ ? '/workspace/tmp/patrol-rule-proof/browser'
+ : '/workspace/tmp/patrol-rule-proof/visual';
const report = {
playwright: require('playwright/package.json').version,
content_sha256: {},
@@ -31,7 +34,7 @@ assert.equal(
].version,
);
-async function journey(root, engine, width, parent = false) {
+async function journey(root, engine, width, parent = false, resume = false, visualOnly = false) {
process.chdir(root);
const { createServer } = await import(path.join(root, 'node_modules/vite/dist/node/index.js'));
const server = await createServer({
@@ -41,6 +44,7 @@ async function journey(root, engine, width, parent = false) {
server: { host: '127.0.0.1', port: 5297, strictPort: true, watch: null },
});
let browser;
+ let page;
const result = {
parent,
engine,
@@ -66,7 +70,10 @@ async function journey(root, engine, width, parent = false) {
resource_id: 'fixture-keep',
resource_name: 'Keep VM',
category: 'capacity',
- description: 'Keep this unrelated rule',
+ description:
+ visualOnly === 'long'
+ ? 'Intentional maintenance on this resource; keep the documented scope.\n'.repeat(30)
+ : 'Keep this unrelated rule',
created_from: 'manual',
created_at: now,
};
@@ -142,7 +149,7 @@ async function journey(root, engine, width, parent = false) {
? await webkit.launch({ headless: true })
: await chromium.launch({ headless: true, channel: 'chromium', args: ['--no-sandbox'] });
result.browser = browser.version();
- const page = await browser.newPage({
+ page = await browser.newPage({
viewport: { width, height: 900 },
colorScheme: width === 320 ? 'dark' : 'light',
isMobile: width === 320,
@@ -251,7 +258,58 @@ async function journey(root, engine, width, parent = false) {
};
else if (p === '/api/ai/patrol/autonomy')
json = { autonomy_level: 'monitor', full_mode_unlocked: false };
- else if (p === '/api/ai/patrol/findings') json = [finding];
+ else if (p === '/api/ai/patrol/findings')
+ json = [
+ finding,
+ {
+ ...finding,
+ id: 'fixture-independent',
+ title: 'Independent backup check',
+ mirrors_alert_id: '',
+ mirrors_alert_type: '',
+ },
+ ];
+ else if (p === '/api/ai/patrol/digest')
+ json = {
+ generated_at: now,
+ window: { start: now, end: now, days: 7, history_complete: true },
+ mode: 'monitor',
+ runs: {
+ total: 0,
+ scheduled: 0,
+ event_triggered: 0,
+ manual: 0,
+ failed: 0,
+ checks: 0,
+ resources_covered: 0,
+ },
+ findings: {
+ new: 0,
+ open_by_severity: { critical: 0, warning: 0, watch: 0, info: 0 },
+ resolved: 0,
+ auto_resolved: 0,
+ dismissed: 0,
+ suppressed: 0,
+ },
+ investigations: { total: 0, by_outcome: {} },
+ actions: {
+ proposed: 0,
+ approved: 0,
+ rejected: 0,
+ executed: 0,
+ verified: 0,
+ failed: 0,
+ pending: 0,
+ },
+ alerts: { reviewed: 0 },
+ spend: {
+ estimated_usd: 0,
+ pricing_known: true,
+ input_tokens: 0,
+ output_tokens: 0,
+ calls: 0,
+ },
+ };
else if (p === '/api/ai/patrol/runs') json = [];
else if (p === '/api/ai/unified/findings') json = { findings: [] };
else if (p === '/api/ai/approvals') json = { approvals: [] };
@@ -269,7 +327,11 @@ async function journey(root, engine, width, parent = false) {
});
const capture = async (name) => {
const file = path.join(output, `${parent ? 'parent' : engine}-${width}-${name}.png`);
- await page.screenshot({ path: file, fullPage: true });
+ await page.screenshot({
+ path: file,
+ fullPage: !visualOnly,
+ animations: visualOnly ? 'disabled' : 'allow',
+ });
report.captures.push({ path: file.replace('/workspace/', ''), sha256: hash(file) });
const dimensions = await page.evaluate(() => ({
inner: innerWidth,
@@ -281,62 +343,145 @@ async function journey(root, engine, width, parent = false) {
waitUntil: 'domcontentloaded',
timeout: 60000,
});
- await page.getByRole('button', { name: 'Open Database VM · Backup age' }).click();
- await page
- .getByRole('list', { name: 'Lasting decisions' })
- .getByRole('button', { name: 'Create rule', exact: true })
- .click();
- const form = page.getByRole('form', { name: 'Confirm Create rule' });
- assert(await form.getByRole('button', { name: 'Confirm: Create rule' }).isDisabled());
- await form.getByLabel(/Why this rule/).fill('Backups are deliberately held off-site');
- await form.getByRole('button', { name: 'Confirm: Create rule' }).click();
- await page.getByRole('status').filter({ hasText: 'Rule created.' }).waitFor();
- assert(created);
- result.checks.push(
- 'Production Inbox Create rule sends one narrow scoped POST with a written reason.',
- );
- if (parent) {
- assert.equal(await page.getByRole('link', { name: 'Manage suppression rules' }).count(), 0);
+ let dialog;
+ if (visualOnly) {
await page.getByRole('tab', { name: 'Activity' }).click();
- assert.equal(await page.locator('#patrol-suppression-rules').count(), 0);
- assert.equal(result.requests.filter((r) => r.method === 'DELETE').length, 0);
- await capture('no-reversal');
+ await page.locator('#patrol-suppression-rules > summary').click();
+ await page.getByRole('button', { name: 'Remove rule for Keep VM, capacity' }).waitFor();
+ // App theme initialisation can override an early init script. Verify the
+ // actual rendered theme after it has mounted, not just colour preference.
+ if (width === 320) await page.evaluate(() => document.documentElement.classList.add('dark'));
+ result.renderedTheme = await page.evaluate(() => ({
+ dark: document.documentElement.classList.contains('dark'),
+ panelBackground: getComputedStyle(document.querySelector('#patrol-suppression-rules'))
+ .backgroundColor,
+ }));
+ assert.equal(result.renderedTheme.dark, width === 320);
+ result.dialogs = [];
+ const visualCases = [
+ ['Remove rule for Keep VM, capacity', 'rule_keep_capacity_3', 'specific-viewport'],
+ ['Remove rule for All resources, All categories', 'rule_any_any_2', 'wildcard-viewport'],
+ ];
+ for (const [label, expected, name] of visualOnly === 'long'
+ ? visualCases.slice(0, 1)
+ : visualCases) {
+ await page.getByRole('button', { name: label }).click();
+ dialog = page.getByRole('dialog', { name: 'Remove suppression rule?' });
+ await dialog.getByText(expected, { exact: true }).waitFor();
+ // Complete the finite entrance animation before measuring and capture
+ // only the user's viewport; full-page capture reflows fixed overlays.
+ await dialog.evaluate((e) =>
+ e.getAnimations({ subtree: true }).forEach((a) => {
+ try {
+ a.finish();
+ } catch {}
+ }),
+ );
+ await page.screenshot({
+ path: path.join(output, `intermediate-${engine}.png`),
+ animations: 'disabled',
+ });
+ const box = await dialog.boundingBox();
+ assert(box, 'Dialog has a rendered box');
+ assert(
+ box.x >= -1 && box.y >= -1 && box.x + box.width <= width + 1 && box.y + box.height <= 901,
+ JSON.stringify(box),
+ );
+ assert(
+ await dialog
+ .getByRole('button', { name: 'Cancel' })
+ .evaluate((e) => e === document.activeElement),
+ );
+ await capture(name);
+ const actions = await dialog
+ .getByRole('button', { name: 'Remove this rule' })
+ .boundingBox();
+ assert(
+ actions &&
+ actions.y >= box.y &&
+ actions.y + actions.height <= box.y + box.height + 1 &&
+ actions.y + actions.height <= 901,
+ 'Confirmation action must not be clipped: ' + JSON.stringify({ box, actions }),
+ );
+ result.dialogs.push({ name, ruleId: expected, box, viewport: { width, height: 900 } });
+ await page.keyboard.press('Escape');
+ await dialog.waitFor({ state: 'detached' });
+ }
+ assert.equal(result.requests.filter((r) => r.method !== 'GET').length, 0);
+ assert.deepEqual(result.errors, []);
+ assert.deepEqual(result.offOrigin, []);
result.checks.push(
- 'Exact assigned parent creates a permanent rule but has no manual-rule reversal control.',
+ 'Exact-ID and wildcard confirmation panels and their cancel/remove controls are inside the actual viewport; no POST or DELETE was replayed.',
);
return;
}
- await page.getByRole('link', { name: 'Manage suppression rules' }).click();
- await page.getByRole('button', { name: 'Remove rule for Database VM, backup' }).waitFor();
- assert.equal(await page.locator('#patrol-suppression-rules').getAttribute('open'), '');
- await capture('manual-list');
- const select = () => page.getByRole('button', { name: 'Remove rule for Database VM, backup' });
- await select().click();
- let dialog = page.getByRole('dialog', { name: 'Remove suppression rule?' });
- await dialog.getByText(created.id, { exact: true }).waitFor();
- assert(
- await dialog
- .getByRole('button', { name: 'Cancel' })
- .evaluate((e) => e === document.activeElement),
- );
- await capture('exact-confirmation');
- await page.keyboard.press('Escape');
- await dialog.waitFor({ state: 'detached' });
- assert.equal(result.requests.filter((r) => r.method === 'DELETE').length, 0);
- await select().click();
- await page.getByRole('dialog').getByRole('button', { name: 'Remove this rule' }).click();
- await page.getByRole('status').filter({ hasText: 'Rule removed.' }).waitFor();
- assert.equal(JSON.stringify(rules), initialUntouched);
- assert.equal(result.requests.filter((r) => r.method === 'DELETE').length, 1);
- assert.equal(await select().count(), 0);
- await capture('removed-readback');
- result.checks.push(
- 'Cancellation is non-mutating; exact manual deletion requires pre-read and post-read and preserves unrelated rules and finding-backed history.',
- );
-
+ if (!resume) {
+ await page.getByRole('button', { name: 'Open Database VM · Backup age' }).click();
+ await page
+ .getByRole('list', { name: 'Lasting decisions' })
+ .getByRole('button', { name: 'Create rule', exact: true })
+ .click();
+ const form = page.getByRole('form', { name: 'Confirm Create rule' });
+ assert(await form.getByRole('button', { name: 'Confirm: Create rule' }).isDisabled());
+ await form.getByLabel(/Why this rule/).fill('Backups are deliberately held off-site');
+ await form.getByRole('button', { name: 'Confirm: Create rule' }).click();
+ await page.getByRole('status').filter({ hasText: 'Rule created.' }).waitFor();
+ assert(created);
+ result.checks.push(
+ 'Production Inbox Create rule sends one narrow scoped POST with a written reason.',
+ );
+ if (parent) {
+ assert.equal(await page.getByRole('link', { name: 'Manage suppression rules' }).count(), 0);
+ await page.getByRole('tab', { name: 'Activity' }).click();
+ assert.equal(await page.locator('#patrol-suppression-rules').count(), 0);
+ assert.equal(result.requests.filter((r) => r.method === 'DELETE').length, 0);
+ await capture('no-reversal');
+ result.checks.push(
+ 'Exact assigned parent creates a permanent rule but has no manual-rule reversal control.',
+ );
+ return;
+ }
+ await page.getByRole('link', { name: 'Manage suppression rules' }).click();
+ await page.getByRole('button', { name: 'Remove rule for Database VM, backup' }).waitFor();
+ assert.equal(await page.locator('#patrol-suppression-rules').getAttribute('open'), '');
+ await capture('manual-list');
+ const select = () =>
+ page.getByRole('button', { name: 'Remove rule for Database VM, backup' });
+ await select().click();
+ dialog = page.getByRole('dialog', { name: 'Remove suppression rule?' });
+ await dialog.getByText(created.id, { exact: true }).waitFor();
+ assert(
+ await dialog
+ .getByRole('button', { name: 'Cancel' })
+ .evaluate((e) => e === document.activeElement),
+ );
+ await capture('exact-confirmation');
+ await page.keyboard.press('Escape');
+ await dialog.waitFor({ state: 'detached' });
+ assert.equal(result.requests.filter((r) => r.method === 'DELETE').length, 0);
+ await select().click();
+ await page.getByRole('dialog').getByRole('button', { name: 'Remove this rule' }).click();
+ await page.getByRole('status').filter({ hasText: 'Rule removed.' }).waitFor();
+ assert.equal(JSON.stringify(rules), initialUntouched);
+ assert.equal(result.requests.filter((r) => r.method === 'DELETE').length, 1);
+ assert.equal(await select().count(), 0);
+ await capture('removed-readback');
+ result.checks.push(
+ 'Cancellation is non-mutating; exact manual deletion requires pre-read and post-read and preserves unrelated rules and finding-backed history.',
+ );
+ } else {
+ await page.getByRole('tab', { name: 'Activity' }).click();
+ await page.locator('#patrol-suppression-rules > summary').click();
+ await page.getByRole('button', { name: 'Remove rule for Keep VM, capacity' }).waitFor();
+ result.checks.push(
+ 'Continue completed desktop creation/removal proof at the remaining controls; no replay of its POST or exact-ID removal.',
+ );
+ }
// The second existing creation control points at the same reversal flow.
await page.getByRole('button', { name: 'Finding options and history' }).click();
- await page.getByRole('button', { name: 'Finding options for Off-site backup age' }).click();
+ await page
+ .getByRole('button', { name: 'Finding options for Independent backup check' })
+ .click();
await page.getByRole('button', { name: 'Create rule from this' }).click();
await page.getByRole('textbox', { name: 'Reason for suppression rule' }).waitFor();
assert.equal(
@@ -359,7 +504,7 @@ async function journey(root, engine, width, parent = false) {
loseResponse = true;
await dialog.getByRole('button', { name: 'Remove this rule' }).click();
await page.getByRole('alert').filter({ hasText: 'Removal could not be confirmed.' }).waitFor();
- assert.equal(result.requests.filter((r) => r.method === 'DELETE').length, 2);
+ assert.equal(result.requests.filter((r) => r.method === 'DELETE').length, resume ? 1 : 2);
await capture('uncertain-not-success');
await page.getByRole('button', { name: 'Reload rules' }).click();
await page.getByRole('button', { name: 'Remove rule for Keep VM, capacity' }).waitFor();
@@ -369,7 +514,7 @@ async function journey(root, engine, width, parent = false) {
.count(),
0,
);
- assert.equal(result.requests.filter((r) => r.method === 'DELETE').length, 2);
+ assert.equal(result.requests.filter((r) => r.method === 'DELETE').length, resume ? 1 : 2);
result.checks.push(
'A lost DELETE response never retries or claims removal; explicit reload reconciles absence and keeps other decisions.',
);
@@ -378,7 +523,7 @@ async function journey(root, engine, width, parent = false) {
denied = true;
await page.getByRole('dialog').getByRole('button', { name: 'Remove this rule' }).click();
await page.getByRole('alert').filter({ hasText: 'Removal could not be confirmed.' }).waitFor();
- assert.equal(result.requests.filter((r) => r.method === 'DELETE').length, 2);
+ assert.equal(result.requests.filter((r) => r.method === 'DELETE').length, resume ? 1 : 2);
denied = false;
await page.getByRole('button', { name: 'Reload rules' }).click();
await page.getByRole('button', { name: 'Remove rule for Keep VM, capacity' }).click();
@@ -386,7 +531,7 @@ async function journey(root, engine, width, parent = false) {
await page.getByRole('alert').filter({ hasText: 'Organisation or access changed.' }).waitFor();
assert.equal(await page.getByRole('dialog').count(), 0);
assert.equal(await page.getByRole('button', { name: /^Remove rule for/ }).count(), 0);
- assert.equal(result.requests.filter((r) => r.method === 'DELETE').length, 2);
+ assert.equal(result.requests.filter((r) => r.method === 'DELETE').length, resume ? 1 : 2);
await capture('scope-invalidated');
result.checks.push(
'Revoked access blocks before DELETE, then organisation switch discards pending confirmation and old rule data. No cross-tenant action or automatic retry.',
@@ -395,6 +540,15 @@ async function journey(root, engine, width, parent = false) {
assert.deepEqual(result.offOrigin, []);
} catch (error) {
result.failure = error.message;
+ if (page) {
+ result.pageState = await page
+ .evaluate(() => ({ url: location.href, text: document.body.innerText.slice(0, 12000) }))
+ .catch(() => null);
+ const file = path.join(output, `${engine}-${width}-failure.png`);
+ await page.screenshot({ path: file, fullPage: true }).catch(() => {});
+ if (fs.existsSync(file))
+ report.captures.push({ path: file.replace('/workspace/', ''), sha256: hash(file) });
+ }
throw error;
} finally {
if (browser) await browser.close();
@@ -402,38 +556,35 @@ async function journey(root, engine, width, parent = false) {
result.cleanup = { browser_closed: Boolean(browser), server_closed: true };
}
}
-(async () => {
- try {
- await journey(
- '/workspace/tmp/patrol-rule-proof/parent/frontend-modern',
- 'chromium',
- 1365,
- true,
+module.exports = { journey, report, output, hash };
+if (require.main === module)
+ (async () => {
+ try {
+ // Completed parent and desktop creation/removal proof are retained; do not replay them.
+ await journey('/workspace/frontend-modern', 'chromium', 1365, false, true);
+ await journey('/workspace/frontend-modern', 'webkit', 320);
+ report.result = 'passed';
+ } catch (error) {
+ report.result = 'failed';
+ report.failure = error.message;
+ throw error;
+ } finally {
+ report.cleanup = {
+ all_cases_closed: report.cases.every(
+ (c) => c.cleanup.browser_closed && c.cleanup.server_closed,
+ ),
+ };
+ fs.writeFileSync(path.join(output, 'result.json'), JSON.stringify(report, null, 2));
+ }
+ console.log(
+ JSON.stringify({
+ result: report.result,
+ cases: report.cases.length,
+ captures: report.captures.length,
+ cleanup: report.cleanup,
+ }),
);
- await journey('/workspace/frontend-modern', 'chromium', 1365);
- await journey('/workspace/frontend-modern', 'webkit', 320);
- report.result = 'passed';
- } catch (error) {
- report.result = 'failed';
- report.failure = error.message;
- throw error;
- } finally {
- report.cleanup = {
- all_cases_closed: report.cases.every(
- (c) => c.cleanup.browser_closed && c.cleanup.server_closed,
- ),
- };
- fs.writeFileSync(path.join(output, 'result.json'), JSON.stringify(report, null, 2));
- }
- console.log(
- JSON.stringify({
- result: report.result,
- cases: report.cases.length,
- captures: report.captures.length,
- cleanup: report.cleanup,
- }),
- );
-})().catch((error) => {
- console.error(error.stack);
- process.exitCode = 1;
-});
+ })().catch((error) => {
+ console.error(error.stack);
+ process.exitCode = 1;
+ });
diff --git a/frontend-modern/src/features/patrol/PatrolSuppressionRules.tsx b/frontend-modern/src/features/patrol/PatrolSuppressionRules.tsx
index 2795c3a914..0df310c28e 100644
--- a/frontend-modern/src/features/patrol/PatrolSuppressionRules.tsx
+++ b/frontend-modern/src/features/patrol/PatrolSuppressionRules.tsx
@@ -281,45 +281,54 @@ export function PatrolSuppressionRules(props: { openForLink?: boolean } = {}) {
>
<Show when={selected()}>
{(rule) => (
- <div class="space-y-4 p-5">
- <h2 class="text-base font-semibold text-base-content">Remove suppression rule?</h2>
- <p class="text-sm leading-5 text-muted">
- Only this exact manual rule will be removed. Future matching findings can appear;
- existing dismissals and history stay unchanged.
- </p>
- <dl class="space-y-2 text-sm text-base-content">
- <div>
- <dt class="font-medium">Resource</dt>
- <dd class="break-words">{ruleScope(rule()).resource}</dd>
- </div>
- <Show when={rule().resource_id}>
+ <div class="flex min-h-0 flex-col">
+ <div class="shrink-0 space-y-3 px-5 pt-5">
+ <h2 class="text-base font-semibold text-base-content">Remove suppression rule?</h2>
+ <p class="text-sm leading-5 text-muted">
+ Only this exact manual rule will be removed. Future matching findings can appear;
+ existing dismissals and history stay unchanged.
+ </p>
+ </div>
+ <div
+ role="region"
+ aria-label="Rule scope and reason"
+ tabindex="0"
+ class="min-h-0 space-y-4 overflow-y-auto px-5 py-4 focus-visible:outline-2 focus-visible:outline-blue-500"
+ >
+ <dl class="space-y-2 text-sm text-base-content">
<div>
- <dt class="font-medium">Resource ID</dt>
- <dd class="break-all">{rule().resource_id}</dd>
+ <dt class="font-medium">Resource</dt>
+ <dd class="break-words">{ruleScope(rule()).resource}</dd>
</div>
+ <Show when={rule().resource_id}>
+ <div>
+ <dt class="font-medium">Resource ID</dt>
+ <dd class="break-all">{rule().resource_id}</dd>
+ </div>
+ </Show>
+ <div>
+ <dt class="font-medium">Category</dt>
+ <dd>{ruleScope(rule()).category}</dd>
+ </div>
+ <div>
+ <dt class="font-medium">Rule ID</dt>
+ <dd class="break-all">{rule().id}</dd>
+ </div>
+ <div>
+ <dt class="font-medium">Reason</dt>
+ <dd class="whitespace-pre-wrap break-words">
+ {rule().description || 'No reason recorded.'}
+ </dd>
+ </div>
+ </dl>
+ <Show when={!rule().resource_id || !rule().category}>
+ <p class="text-sm font-medium text-amber-800 dark:text-amber-200">
+ This broad rule covers {!rule().resource_id ? 'all resources' : 'this resource'}{' '}
+ in {!rule().category ? 'all categories' : rule().category}.
+ </p>
</Show>
- <div>
- <dt class="font-medium">Category</dt>
- <dd>{ruleScope(rule()).category}</dd>
- </div>
- <div>
- <dt class="font-medium">Reason</dt>
- <dd class="whitespace-pre-wrap break-words">
- {rule().description || 'No reason recorded.'}
- </dd>
- </div>
- <div>
- <dt class="font-medium">Rule ID</dt>
- <dd class="break-all">{rule().id}</dd>
- </div>
- </dl>
- <Show when={!rule().resource_id || !rule().category}>
- <p class="text-sm font-medium text-amber-800 dark:text-amber-200">
- This broad rule covers {!rule().resource_id ? 'all resources' : 'this resource'}{' '}
- in {!rule().category ? 'all categories' : rule().category}.
- </p>
- </Show>
- <div class="flex flex-wrap gap-2">
+ </div>
+ <div class="flex shrink-0 flex-wrap gap-2 border-t border-border px-5 py-4">
<Button
variant="secondary"
class="min-h-11"
diff --git a/frontend-modern/src/features/patrol/__tests__/PatrolSuppressionRules.test.tsx b/frontend-modern/src/features/patrol/__tests__/PatrolSuppressionRules.test.tsx
index f3095ca736..c943402ec6 100644
--- a/frontend-modern/src/features/patrol/__tests__/PatrolSuppressionRules.test.tsx
+++ b/frontend-modern/src/features/patrol/__tests__/PatrolSuppressionRules.test.tsx
@@ -107,6 +107,25 @@ describe('Patrol manual-rule reversal', () => {
await waitFor(() => expect(trigger).toHaveFocus());
});
+ it('keeps long reasons in a keyboard-scrollable region separate from the confirmation controls', async () => {
+ const longReason = 'Keep the documented scope.\n'.repeat(30);
+ read.mockResolvedValueOnce([{ ...manual, description: longReason }]);
+ await openRules();
+ const dialog = await chooseManual();
+ const region = within(dialog).getByRole('region', { name: 'Rule scope and reason' });
+ expect(region).toHaveAttribute('tabindex', '0');
+ expect(within(region).getByText(manual.id)).toBeInTheDocument();
+ expect(within(region).getByText(/Keep the documented scope/)).toBeInTheDocument();
+ expect(region).not.toContainElement(within(dialog).getByRole('button', { name: 'Cancel' }));
+ expect(region).not.toContainElement(
+ within(dialog).getByRole('button', { name: 'Remove this rule' }),
+ );
+ await waitFor(() =>
+ expect(within(dialog).getByRole('button', { name: 'Cancel' })).toHaveFocus(),
+ );
+ expect(remove).not.toHaveBeenCalled();
+ });
+
it('revalidates, deletes one exact manual ID and confirms absence while keeping unrelated decisions', async () => {
await openRules();
read.mockResolvedValueOnce(initial).mockResolvedValueOnce([broad, dismissed, legacy]);