Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Start slow non-API test packages before the small-package tail

pulse-triage[bot]ebb7752bb522
diff --git a/.github/scripts/go-package-test-seconds.txt b/.github/scripts/go-package-test-seconds.txt
index d28c71b291..a73b50a050 100644
--- a/.github/scripts/go-package-test-seconds.txt
+++ b/.github/scripts/go-package-test-seconds.txt
@@ -1,35 +1,38 @@
# Non-API Go package race-test seconds on GitHub ubuntu-24.04.
-# Median of successful rest shards in Build and Test runs 37451091575
-# (b5444cf8) and 37451828694 (bd0ef398), collected 2026-10-06.
+# Median of complete successful rest shards in Build and Test runs 38004713400
+# (main 4b56e89c) and 38003223007 (actual PR checkout 0a79049f), 2026-10-09.
+# The latter run failed its separate advisory Benchmarks check; both rest
+# shards passed with complete, uncached reports in each run.
# Package elapsed times overlap because go test runs packages concurrently;
-# these are balancing weights, not predicted wall-clock durations.
-# Weights move whole packages between the two existing required checks.
+# these are scheduling weights, not predicted wall-clock durations.
+# Weights move whole packages between the two existing required checks and
+# start the heavier binaries first within each check. They cannot change
+# internal/api's separate contiguous, order-preserving test slices.
# The checked-out go list supplies coverage, including new/unmeasured packages.
# Stale entries cannot add, omit or duplicate a package. DEFAULT_WEIGHT is
# the mean of measured test packages below 20 seconds in those same runs.
-# Refresh from complete passing rest-shard logs when imbalance returns.
-DEFAULT_WEIGHT 2.681
-github.com/rcourtman/pulse-go-rewrite/cmd/hashpw 22.616
-github.com/rcourtman/pulse-go-rewrite/internal/agentupdate 35.681
-github.com/rcourtman/pulse-go-rewrite/internal/ai 30.231
-github.com/rcourtman/pulse-go-rewrite/internal/ai/chat 20.800
-github.com/rcourtman/pulse-go-rewrite/internal/ai/tools 63.876
-github.com/rcourtman/pulse-go-rewrite/internal/alerts 27.456
-github.com/rcourtman/pulse-go-rewrite/internal/api/configapi 34.133
-github.com/rcourtman/pulse-go-rewrite/internal/config 228.780
-github.com/rcourtman/pulse-go-rewrite/internal/dockeragent 22.758
-github.com/rcourtman/pulse-go-rewrite/internal/mock 129.980
-github.com/rcourtman/pulse-go-rewrite/internal/monitoring 201.733
-github.com/rcourtman/pulse-go-rewrite/internal/notifications 121.213
-github.com/rcourtman/pulse-go-rewrite/internal/recovery/store 23.478
-github.com/rcourtman/pulse-go-rewrite/internal/relay 70.288
-github.com/rcourtman/pulse-go-rewrite/internal/telemetry 38.002
-github.com/rcourtman/pulse-go-rewrite/internal/truenas 48.556
-github.com/rcourtman/pulse-go-rewrite/internal/unifiedresources 124.084
-github.com/rcourtman/pulse-go-rewrite/internal/updates 26.972
-github.com/rcourtman/pulse-go-rewrite/internal/websocket 27.300
-github.com/rcourtman/pulse-go-rewrite/pkg/auth 26.903
-github.com/rcourtman/pulse-go-rewrite/pkg/metrics 324.930
-github.com/rcourtman/pulse-go-rewrite/pkg/server 26.114
-github.com/rcourtman/pulse-go-rewrite/scripts/installtests 206.606
-github.com/rcourtman/pulse-go-rewrite/tests/migration 48.435
+# Refresh from complete passing rest-shard logs when imbalance/tails return.
+DEFAULT_WEIGHT 2.807
+github.com/rcourtman/pulse-go-rewrite/cmd/hashpw 22.610
+github.com/rcourtman/pulse-go-rewrite/internal/agentupdate 35.516
+github.com/rcourtman/pulse-go-rewrite/internal/ai 25.178
+github.com/rcourtman/pulse-go-rewrite/internal/ai/tools 63.671
+github.com/rcourtman/pulse-go-rewrite/internal/alerts 79.691
+github.com/rcourtman/pulse-go-rewrite/internal/api/configapi 28.785
+github.com/rcourtman/pulse-go-rewrite/internal/config 259.558
+github.com/rcourtman/pulse-go-rewrite/internal/dockeragent 34.074
+github.com/rcourtman/pulse-go-rewrite/internal/hostagent 20.136
+github.com/rcourtman/pulse-go-rewrite/internal/mock 130.030
+github.com/rcourtman/pulse-go-rewrite/internal/monitoring 314.522
+github.com/rcourtman/pulse-go-rewrite/internal/notifications 135.088
+github.com/rcourtman/pulse-go-rewrite/internal/recovery/store 31.468
+github.com/rcourtman/pulse-go-rewrite/internal/relay 70.598
+github.com/rcourtman/pulse-go-rewrite/internal/telemetry 27.853
+github.com/rcourtman/pulse-go-rewrite/internal/truenas 47.732
+github.com/rcourtman/pulse-go-rewrite/internal/unifiedresources 112.878
+github.com/rcourtman/pulse-go-rewrite/internal/websocket 26.518
+github.com/rcourtman/pulse-go-rewrite/pkg/auth 27.024
+github.com/rcourtman/pulse-go-rewrite/pkg/metrics 254.154
+github.com/rcourtman/pulse-go-rewrite/pkg/server 27.454
+github.com/rcourtman/pulse-go-rewrite/scripts/installtests 360.228
+github.com/rcourtman/pulse-go-rewrite/tests/migration 81.948
diff --git a/.github/scripts/select-go-package-shard.py b/.github/scripts/select-go-package-shard.py
index ab03848745..1274b8aec2 100644
--- a/.github/scripts/select-go-package-shard.py
+++ b/.github/scripts/select-go-package-shard.py
@@ -5,7 +5,8 @@ Usage: go list ... | select-go-package-shard.py WEIGHTS COUNT INDEX
The checked-out source supplies the package universe, never the weights file.
Assign longest measured packages first to the lightest shard, breaking ties by
-package name and shard index. Print selected packages in their original order.
+package name and shard index. Start selected packages longest first, so slow
+binaries do not wait behind the small-package tail in Go's parallel scheduler.
Unlike internal/api's test slices, separate package binaries have no shared
test order to preserve. Missing/renamed weights affect balance, not coverage.
"""
@@ -82,7 +83,7 @@ def main() -> int:
except (OSError, ValueError, InvalidOperation) as error:
print(f"package shard selection failed: {error}", file=sys.stderr)
return 2
- for name in packages:
+ for name in sorted(packages, key=lambda name: (-weights.get(name, default), name)):
if assignment[name] == args.index:
print(name)
return 0
diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml
index a5f34c70ee..1e529672f0 100644
--- a/.github/workflows/build-and-test.yml
+++ b/.github/workflows/build-and-test.yml
@@ -369,7 +369,9 @@ jobs:
env:
PULSE_DATA_DIR: /tmp/pulse-test-data
# Source, not the timing file, defines coverage. Longest measured
- # packages go to the lightest shard; new packages use a default weight.
+ # packages go to the lightest shard and start first within that shard;
+ # new packages use a default weight. Do not leave slow binaries behind
+ # the alphabetically earlier small packages in Go's parallel scheduler.
# Package binaries are independent, so only internal/api needs the
# contiguous, order-preserving test slices used in its separate job.
run: |
diff --git a/scripts/tests/test_go_package_shards.py b/scripts/tests/test_go_package_shards.py
index 7b05a13aef..52068156c8 100644
--- a/scripts/tests/test_go_package_shards.py
+++ b/scripts/tests/test_go_package_shards.py
@@ -50,7 +50,7 @@ class PackageShardsTest(unittest.TestCase):
self.assertEqual(set(assigned.values()), set(range(count)))
self.assertEqual(assigned, selector.assign(list(reversed(packages)), weights, Decimal(1), count))
- def test_cli_keeps_source_order_and_new_unmeasured_packages(self):
+ def test_cli_starts_heavy_packages_first_without_losing_unmeasured_packages(self):
packages = ["example/new", "example/z", "example/a", "example/b", "example/renamed"]
weights = "# stale names are not coverage\nDEFAULT_WEIGHT 2.5\nexample/deleted 100\nexample/z 20\n"
selected = []
@@ -59,10 +59,27 @@ class PackageShardsTest(unittest.TestCase):
self.assertEqual(result.returncode, 0, result.stderr)
names = result.stdout.splitlines()
self.assertTrue(names)
- self.assertEqual(names, [p for p in packages if p in names])
+ self.assertEqual(names, sorted(names, key=lambda p: (-20 if p == "example/z" else -2.5, p)))
selected.extend(names)
self.assertCountEqual(selected, packages)
+ def test_cli_order_is_deterministic_when_source_listing_order_changes(self):
+ packages = ["example/z", "example/new", "example/a", "example/b", "example/c"]
+ weights = "DEFAULT_WEIGHT 2\nexample/z 20\nexample/c 10\n"
+ for index in range(2):
+ result = self.cli("\n".join(packages) + "\n", weights, index=index)
+ reversed_result = self.cli("\n".join(reversed(packages)) + "\n", weights, index=index)
+ self.assertEqual(result.returncode, 0, result.stderr)
+ self.assertEqual(reversed_result.returncode, 0, reversed_result.stderr)
+ self.assertEqual(result.stdout, reversed_result.stdout)
+
+ def test_slow_binary_is_not_scheduled_after_a_small_package_tail(self):
+ packages = [f"example/a{i:02}" for i in range(12)] + ["example/z-slow"]
+ weights = "DEFAULT_WEIGHT 1\nexample/z-slow 100\n"
+ result = self.cli("\n".join(packages) + "\n", weights, count=1)
+ self.assertEqual(result.returncode, 0, result.stderr)
+ self.assertEqual(result.stdout.splitlines(), ["example/z-slow"] + packages[:-1])
+
def test_equal_weights_and_decimal_ties_are_stable(self):
packages = ["example/d", "example/c", "example/b", "example/a"]
assigned = selector.assign(packages, {}, Decimal("0.1"), 2)