Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.
Go aialertsdashboarddockerdocker-monitoringgohomelabinfrastructure-monitoringkubernetesmonitoringmspproxmoxproxmox-backup-serverproxmox-mail-gatewayproxmox-veself-hostedtruenastypescriptvspherewebhooks
Reset obsolete guest metadata scheduling on invalidation
pulse-triage[bot]ec4ee724de90
diff --git a/docs/release-control/v6/internal/subsystems/monitoring.md b/docs/release-control/v6/internal/subsystems/monitoring.mdindex 6aef8103c9..a4d0beefad 100644--- a/docs/release-control/v6/internal/subsystems/monitoring.md+++ b/docs/release-control/v6/internal/subsystems/monitoring.md@@ -558,7 +558,10 @@ completed. A cold cache cannot override another owner's reservation or an earlyfailure's backoff. A denied reservation returns only previously retainedidentity (or none), without creating fresh evidence, a transport deferral or anew retry deadline. Other keys remain independent; completion releases only-in-flight ownership and preserves normal refresh/backoff scheduling.+in-flight ownership and preserves normal refresh/backoff scheduling. Deliberate+cache invalidation on agent unavailability also discards its obsolete scheduling+deadline, so a later available poll can begin a fresh metadata lifecycle; it+never discards an outstanding fetch owner or the shared Proxmox command fence.`guest_metadata_reservation_test.go` exercises real HTTP enrichment with coldand retained caches, active and expired scheduling holds, early unverified-lockdiff --git a/internal/monitoring/guest_metadata.go b/internal/monitoring/guest_metadata.goindex 250526feee..32f36c29d6 100644--- a/internal/monitoring/guest_metadata.go+++ b/internal/monitoring/guest_metadata.go@@ -482,6 +482,12 @@ func (m *Monitor) clearGuestMetadataCache(instanceName, nodeName string, vmid indelete(m.guestMetadataCache, key)}m.guestMetadataMu.Unlock()+ // Deliberate invalidation when the agent is unavailable starts a new+ // metadata lifecycle. Do not carry its obsolete refresh/backoff deadline+ // into a later available poll, or discard an outstanding fetch's ownership.+ m.guestMetadataLimiterMu.Lock()+ delete(m.guestMetadataLimiter, key)+ m.guestMetadataLimiterMu.Unlock()}func cloneStringSlice(src []string) []string {diff --git a/internal/monitoring/guest_metadata_reservation_test.go b/internal/monitoring/guest_metadata_reservation_test.goindex 832f6a549e..f1e55211b8 100644--- a/internal/monitoring/guest_metadata_reservation_test.go+++ b/internal/monitoring/guest_metadata_reservation_test.go@@ -203,3 +203,32 @@ func TestGuestMetadataColdCacheHonoursEarlyBackoff(t *testing.T) {})}}++func TestGuestMetadataInvalidationKeepsActiveOwnership(t *testing.T) {+ key := guestMetadataCacheKey("reservation", "node", 105)+ other := guestMetadataCacheKey("independent", "node", 105)+ future := time.Now().Add(time.Hour)+ m := &Monitor{guestMetadataCache: map[string]guestMetadataCacheEntry{key: {osName: "old"}, other: {osName: "independent"}}, guestMetadataLimiter: map[string]time.Time{other: future}}+ if !m.tryReserveGuestMetadataFetch(key, time.Now()) {+ t.Fatal("owner could not reserve metadata")+ }+ m.clearGuestMetadataCache("reservation", "node", 105)+ if _, exists := m.guestMetadataCache[key]; exists {+ t.Error("invalidated metadata was retained")+ }+ if _, exists := m.guestMetadataLimiter[key]; exists {+ t.Error("obsolete scheduling deadline survived invalidation")+ }+ if m.tryReserveGuestMetadataFetch(key, time.Now()) {+ t.Fatal("invalidation admitted another in-flight metadata writer")+ }+ if m.guestMetadataCache[other].osName != "independent" || !m.guestMetadataLimiter[other].Equal(future) {+ t.Error("invalidation crossed installation boundaries")+ }+ m.releaseGuestMetadataFetch(key)+ assertMetadataReservationReleased(t, m)+ if !m.tryReserveGuestMetadataFetch(key, time.Now()) {+ t.Error("invalidated metadata did not allow a fresh lifecycle after completion")+ }+ m.releaseGuestMetadataFetch(key)+}