Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Classify SSO configuration preservation as a shared adapter

pulse-triage[bot]ecf52d45b0ea
diff --git a/internal/api/code_standards_test.go b/internal/api/code_standards_test.go
index f7bc893a8e..4238aabdc3 100644
--- a/internal/api/code_standards_test.go
+++ b/internal/api/code_standards_test.go
@@ -146,6 +146,9 @@ var knownSharedInfrastructureFiles = map[string]bool{
// Shared SSO outbound helpers centralize restricted fetch/file access and are
// consumed by public handlers; they are not paid-domain business logic.
"sso_outbound.go": true,
+ // Shared configuration edit adapter: retains omitted stored fields without
+ // exposing them. No authentication, entitlement or paid endpoint logic.
+ "sso_config_preservation.go": true,
}
// TestPaidDomainBoundaryAudit enforces two rules:
diff --git a/internal/api/reporting_boundary_test.go b/internal/api/reporting_boundary_test.go
index 221958e71c..b631f9000c 100644
--- a/internal/api/reporting_boundary_test.go
+++ b/internal/api/reporting_boundary_test.go
@@ -26,6 +26,25 @@ func TestReportingSubjectBoundaryExemptionIsExact(t *testing.T) {
name, file, content, goMarker string
}{
{name: "shared subject pipeline"},
+ {
+ name: "SSO configuration adapter exemption is exact", file: "sso_config_preservation_extra.go", content: "package api\n",
+ goMarker: "untracked paid-domain file sso_config_preservation_extra.go",
+ },
+ {
+ name: "SSO configuration adapter private root import denied", file: "sso_config_preservation.go",
+ content: "package api\nimport _ \"github.com/rcourtman/pulse-go-rewrite/internal/license\"\n",
+ goMarker: "direct internal/license import",
+ },
+ {
+ name: "SSO configuration adapter private implementation import denied", file: "sso_config_preservation.go",
+ content: "package api\nimport _ \"github.com/rcourtman/pulse-go-rewrite/internal/license/entitlements\"\n",
+ goMarker: "direct internal/license import",
+ },
+ {
+ name: "SSO configuration adapter licensing bridge required", file: "sso_config_preservation.go",
+ content: "package api\nimport _ \"github.com/rcourtman/pulse-go-rewrite/pkg/licensing\"\n",
+ goMarker: "sso_config_preservation.go",
+ },
{
name: "activity observer exemption is exact", file: "reporting_activity_extra.go", content: "package api\n",
goMarker: "untracked paid-domain file reporting_activity_extra.go",
diff --git a/scripts/repo-boundary-paid-surface.allowlist b/scripts/repo-boundary-paid-surface.allowlist
index f94b1b1900..c1ecdbe2c8 100644
--- a/scripts/repo-boundary-paid-surface.allowlist
+++ b/scripts/repo-boundary-paid-surface.allowlist
@@ -1,6 +1,10 @@
internal/api/access_admin_handlers.go
internal/api/activity_audit_handlers.go
internal/api/identity_sso_handlers.go
+# Shared SSO configuration edit adapter: keeps omitted stored fields without
+# exposing them in responses. No authentication or entitlement implementation.
+# Exact path only; all private-import and licensing-bridge checks still apply.
+internal/api/sso_config_preservation.go
internal/api/licensing_bridge.go
internal/api/licensing_handlers.go
internal/api/magic_link.go
diff --git a/scripts/repo-boundary-regression.py b/scripts/repo-boundary-regression.py
index ddb2731a43..7534bde763 100644
--- a/scripts/repo-boundary-regression.py
+++ b/scripts/repo-boundary-regression.py
@@ -16,6 +16,25 @@ class ReportingSubjectBoundaryTests(unittest.TestCase):
def test_shared_exemption_is_exact_and_preserves_import_boundaries(self):
variants = [
("shared pipeline", None, None, None),
+ (
+ "SSO configuration adapter exact path", "sso_config_preservation_extra.go",
+ "package api\n", "new production paid-domain implementation files are not baselined",
+ ),
+ (
+ "SSO configuration adapter private root import", "sso_config_preservation.go",
+ 'package api\nimport _ "github.com/rcourtman/pulse-go-rewrite/internal/license"\n',
+ "API root imports of internal/license remain",
+ ),
+ (
+ "SSO configuration adapter private implementation import", "sso_config_preservation.go",
+ 'package api\nimport _ "github.com/rcourtman/pulse-go-rewrite/internal/license/entitlements"\n',
+ "non-test internal API files still import internal/license",
+ ),
+ (
+ "SSO configuration adapter licensing bridge required", "sso_config_preservation.go",
+ 'package api\nimport _ "github.com/rcourtman/pulse-go-rewrite/pkg/licensing"\n',
+ "API files outside bridge allowlist still import pkg/licensing",
+ ),
(
"activity observer exact path", "reporting_activity_extra.go",
"package api\n", "new production paid-domain implementation files are not baselined",