Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Match complete storage fixture records to native Unix timestamps

pulse-triage[bot]f6e67dbcfecd
diff --git a/docs/release-control/v6/internal/subsystems/monitoring.md b/docs/release-control/v6/internal/subsystems/monitoring.md
index 5657928078..99409eaced 100644
--- a/docs/release-control/v6/internal/subsystems/monitoring.md
+++ b/docs/release-control/v6/internal/subsystems/monitoring.md
@@ -32,7 +32,8 @@ unread node until an accepted storage or complete enumeration replaces it.
Explicit request cancellation withdraws the enumeration. Dropping an expired
child deadline for local publication does not drop the connection owner:
runtime shutdown/replacement, client replacement and retirement still prevent
-late publication. Independent connections, local-disk identity, permissions,
+late publication. Unexpired publication retains its request cancellation signal.
+Independent connections, local-disk identity, permissions,
alerts, guest operations and provider budgets are unchanged. Every node's
ordinary storage reads remain; an accepted shared view is not substituted for
another node's access evidence.
diff --git a/docs/release-control/v6/internal/subsystems/storage-recovery.md b/docs/release-control/v6/internal/subsystems/storage-recovery.md
index 00bead1567..03b2747eee 100644
--- a/docs/release-control/v6/internal/subsystems/storage-recovery.md
+++ b/docs/release-control/v6/internal/subsystems/storage-recovery.md
@@ -36,7 +36,8 @@ unread node until an accepted storage or complete enumeration replaces it.
Explicit request cancellation withdraws the enumeration. Dropping an expired
child deadline for local publication does not drop the connection owner:
runtime shutdown/replacement, client replacement and retirement still prevent
-late publication. Independent connections, local-disk identity, permissions,
+late publication. Unexpired publication retains its request cancellation signal.
+Independent connections, local-disk identity, permissions,
alerts, guest operations and provider budgets are unchanged. Every node's
ordinary storage reads remain; an accepted shared view is not substituted for
another node's access evidence.
diff --git a/internal/monitoring/monitor_backups.go b/internal/monitoring/monitor_backups.go
index bd82dd4e04..853f70a272 100644
--- a/internal/monitoring/monitor_backups.go
+++ b/internal/monitoring/monitor_backups.go
@@ -614,7 +614,11 @@ func (m *Monitor) pollStorageBackupsWithNodes(ctx context.Context, instanceName
// A later storage/assignment timeout cannot discard earlier accepted
// listings. Drop only the spent child budget: the owner value still fences
// runtime shutdown, connection replacement and retirement atomically.
- unlock, current := m.beginPVEBackupPublication(context.WithoutCancel(ctx), instanceName)
+ publicationCtx := ctx
+ if ctx.Err() == context.DeadlineExceeded {
+ publicationCtx = context.WithoutCancel(ctx)
+ }
+ unlock, current := m.beginPVEBackupPublication(publicationCtx, instanceName)
if !current {
return
}
diff --git a/internal/monitoring/pve_storage_budget_test.go b/internal/monitoring/pve_storage_budget_test.go
index ccbde88bf7..fc1d3771a9 100644
--- a/internal/monitoring/pve_storage_budget_test.go
+++ b/internal/monitoring/pve_storage_budget_test.go
@@ -197,10 +197,12 @@ func TestPVEStorageBudgetPublishesAcceptedListings(t *testing.T) {
}
} else {
expected := old
- expected.Time, expected.CTime = c.at, c.at.Unix()
+ // Match the provider-to-model Unix constructor as well as the instant;
+ // reflect compares time.Location representation, not just clocks.
+ expected.Time, expected.CTime = time.Unix(c.at.Unix(), 0), c.at.Unix()
expected.Notes = "accepted " + c.at.Format(time.RFC3339)
if !reflect.DeepEqual(raw, expected) {
- t.Error("accepted raw archive did not advance exactly its observed fields")
+ t.Errorf("accepted raw archive did not advance exactly its observed fields: got=%#v want=%#v", raw, expected)
}
}
}