Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Use deliberate noncritical temperature continuity controls

pulse-triage[bot]f7622aea48ab
diff --git a/docs/release-control/v6/internal/subsystems/alerts.md b/docs/release-control/v6/internal/subsystems/alerts.md
index 2083df26fc..c2229a562f 100644
--- a/docs/release-control/v6/internal/subsystems/alerts.md
+++ b/docs/release-control/v6/internal/subsystems/alerts.md
@@ -3703,7 +3703,9 @@ consecutive omissions; empty/expired inventory breaks that confirmation sequence
Configuration saves reset pending-only runs when global agent policy, host or
inherited node/guest overrides, or the applicable disk-type threshold disables
-evaluation, even if no report arrives before re-enablement. Only live pending
+evaluation, even if no report arrives before re-enablement. Existing known-type
+default normalisation is unchanged; the zero-type save control uses a custom
+type whose zero threshold the normaliser preserves. Only live pending
identity/link/type context is retained; unrelated saves preserve a known enabled
run and explicit overrides retain precedence over type defaults. Restored intent
without that context restarts conservatively on a save rather than inventing
diff --git a/internal/alerts/host_unraid_lifecycle_test.go b/internal/alerts/host_unraid_lifecycle_test.go
index 0ced00d816..780c72c4f1 100644
--- a/internal/alerts/host_unraid_lifecycle_test.go
+++ b/internal/alerts/host_unraid_lifecycle_test.go
@@ -901,7 +901,7 @@ func TestDiskTemperaturePendingConfigDisablement(t *testing.T) {
for _, scope := range []string{"global", "all-agents", "host", "node", "vm", "container", "type", "unrelated"} {
t.Run(fmt.Sprintf("%s/explicit=%v", scope, explicit), func(t *testing.T) {
m, elapsed := continuityManager(t, explicit)
- host := hostWithSMARTDiskTemp("pending-temp", "sata", 85)
+ host := hostWithSMARTDiskTemp("pending-temp", "custom", 85)
host.LinkedNodeID, host.LinkedVMID, host.LinkedContainerID = "site:node", "site:node:101", "site:node:102"
id := hostDiskTemperatureResourceID(host.ID, host.Sensors.SMART[0].Device)
m.CheckHost(host)
@@ -927,7 +927,7 @@ func TestDiskTemperaturePendingConfigDisablement(t *testing.T) {
m.CheckHost(host)
cfg.Overrides[host.LinkedContainerID] = ThresholdConfig{DiskTemperature: &HysteresisThreshold{Trigger: 0}}
case "type":
- cfg.DiskTempByType = map[string]HysteresisThreshold{"sata": {Trigger: 0}}
+ cfg.DiskTempByType = map[string]HysteresisThreshold{"custom": {Trigger: 0}}
case "unrelated":
cfg.Schedule.QuietHours.Timezone = "UTC"
}
@@ -941,7 +941,7 @@ func TestDiskTemperaturePendingConfigDisablement(t *testing.T) {
}
cfg.Enabled, cfg.DisableAllAgents = true, false
cfg.Overrides = map[string]ThresholdConfig{}
- cfg.DiskTempByType = nil
+ cfg.DiskTempByType = map[string]HysteresisThreshold{"custom": {Trigger: 80, Clear: 70}}
m.UpdateConfig(cfg)
elapsed.Store(int64(2 * time.Minute))
m.CheckHost(host)
@@ -1019,9 +1019,9 @@ func TestDiskTemperatureCurrentCollectionAndOverrideControls(t *testing.T) {
}
t.Run("host override wins over disabled type", func(t *testing.T) {
m, elapsed := continuityManager(t, false)
- host := hostWithSMARTDiskTemp("override-temp", "sata", 85)
+ host := hostWithSMARTDiskTemp("override-temp", "custom", 85)
cfg := m.GetConfig()
- cfg.DiskTempByType = map[string]HysteresisThreshold{"sata": {Trigger: 0}}
+ cfg.DiskTempByType = map[string]HysteresisThreshold{"custom": {Trigger: 0}}
cfg.Overrides[host.ID] = ThresholdConfig{DiskTemperature: &HysteresisThreshold{Trigger: 80, Clear: 70}}
m.UpdateConfig(cfg)
m.CheckHost(host)
diff --git a/internal/alerts/metric_observation_continuity_test.go b/internal/alerts/metric_observation_continuity_test.go
index c916050b51..6ba596e8da 100644
--- a/internal/alerts/metric_observation_continuity_test.go
+++ b/internal/alerts/metric_observation_continuity_test.go
@@ -26,7 +26,7 @@ func continuityManager(t *testing.T, explicit bool) (*Manager, *atomic.Int64) {
cfg.GuestDefaults.Memory = &HysteresisThreshold{Trigger: 80, Clear: 70}
cfg.GuestDefaults.Disk = &HysteresisThreshold{Trigger: 80, Clear: 70}
cfg.AgentDefaults.DiskTemperature = &HysteresisThreshold{Trigger: 80, Clear: 70}
- cfg.DiskTempByType = nil
+ cfg.DiskTempByType = map[string]HysteresisThreshold{"sata": {Trigger: 80, Clear: 70}, "custom": {Trigger: 80, Clear: 70}}
cfg.AgentDefaults.Memory = &HysteresisThreshold{Trigger: 80, Clear: 70}
m.UpdateConfig(cfg)
elapsed := &atomic.Int64{}