Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Clarify protection scope beside location-filtered backup evidence

pulse-triage[bot]f777e774cf8e
diff --git a/docs/release-control/v6/internal/subsystems/frontend-primitives.md b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
index 67515d7789..13d5c3bb2a 100644
--- a/docs/release-control/v6/internal/subsystems/frontend-primitives.md
+++ b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
@@ -10469,3 +10469,25 @@ end-distinguished connections, 719/720px projection, scoped evidence and owner
links. Browser proof must inspect complete rendered names/connections, layout
resize, keyboard/touch disclosure and retained polling at desktop and narrow
widths, with actual pixels.
+
+### Location-filtered backup evidence is not a location protection rating
+
+The Proxmox backup-health strip names its all-target/all-location count scope,
+independent of filters. In Coverage, a resolved backup-location filter qualifies
+ages and restore evidence next to the list and inside an expanded record. The
+server's protection assessment, provider evidence and task history remain
+workload-wide; a current backup elsewhere must not read as protection of a
+stale, running-only or snapshot-only selected location. Labels come only from
+resolved inventory identity, never raw saved-query text. An unresolved location
+keeps the existing explicit empty selection rather than broadening to another
+repository. Clearing the filter removes the qualification without replacing the
+keyed open record or making another read. No assessment, association, policy,
+API, route, guest operation or recovery authority changes.
+
+Normal-suite `ProxmoxBackupsTable.test.tsx` covers stale, running and snapshot-only
+selected evidence beside a server-owned Protected workload, all-target counts,
+independent task history, filter clearing and ordinary-poll disappearance/return.
+Desktop/narrow browser proof must exercise the parsed inventory consumer,
+filter interactions, scoped open records and literal long labels and inspect
+actual pixels. This corrects evidence scope, not original incident causality or
+native backup/guest recovery.
diff --git a/docs/release-control/v6/internal/subsystems/storage-recovery.md b/docs/release-control/v6/internal/subsystems/storage-recovery.md
index 6e11d32c47..3bca8dbc98 100644
--- a/docs/release-control/v6/internal/subsystems/storage-recovery.md
+++ b/docs/release-control/v6/internal/subsystems/storage-recovery.md
@@ -8080,3 +8080,25 @@ end-distinguished connections, 719/720px projection, scoped evidence and owner
links. Browser proof must inspect complete rendered names/connections, layout
resize, keyboard/touch disclosure and retained polling at desktop and narrow
widths, with actual pixels.
+
+### Location-filtered backup evidence is not a location protection rating
+
+The Proxmox backup-health strip names its all-target/all-location count scope,
+independent of filters. In Coverage, a resolved backup-location filter qualifies
+ages and restore evidence next to the list and inside an expanded record. The
+server's protection assessment, provider evidence and task history remain
+workload-wide; a current backup elsewhere must not read as protection of a
+stale, running-only or snapshot-only selected location. Labels come only from
+resolved inventory identity, never raw saved-query text. An unresolved location
+keeps the existing explicit empty selection rather than broadening to another
+repository. Clearing the filter removes the qualification without replacing the
+keyed open record or making another read. No assessment, association, policy,
+API, route, guest operation or recovery authority changes.
+
+Normal-suite `ProxmoxBackupsTable.test.tsx` covers stale, running and snapshot-only
+selected evidence beside a server-owned Protected workload, all-target counts,
+independent task history, filter clearing and ordinary-poll disappearance/return.
+Desktop/narrow browser proof must exercise the parsed inventory consumer,
+filter interactions, scoped open records and literal long labels and inspect
+actual pixels. This corrects evidence scope, not original incident causality or
+native backup/guest recovery.
diff --git a/docs/release-control/v6/internal/subsystems/unified-resources.md b/docs/release-control/v6/internal/subsystems/unified-resources.md
index 50083e2597..176d95bdb5 100644
--- a/docs/release-control/v6/internal/subsystems/unified-resources.md
+++ b/docs/release-control/v6/internal/subsystems/unified-resources.md
@@ -8939,3 +8939,25 @@ end-distinguished connections, 719/720px projection, scoped evidence and owner
links. Browser proof must inspect complete rendered names/connections, layout
resize, keyboard/touch disclosure and retained polling at desktop and narrow
widths, with actual pixels.
+
+### Location-filtered backup evidence is not a location protection rating
+
+The Proxmox backup-health strip names its all-target/all-location count scope,
+independent of filters. In Coverage, a resolved backup-location filter qualifies
+ages and restore evidence next to the list and inside an expanded record. The
+server's protection assessment, provider evidence and task history remain
+workload-wide; a current backup elsewhere must not read as protection of a
+stale, running-only or snapshot-only selected location. Labels come only from
+resolved inventory identity, never raw saved-query text. An unresolved location
+keeps the existing explicit empty selection rather than broadening to another
+repository. Clearing the filter removes the qualification without replacing the
+keyed open record or making another read. No assessment, association, policy,
+API, route, guest operation or recovery authority changes.
+
+Normal-suite `ProxmoxBackupsTable.test.tsx` covers stale, running and snapshot-only
+selected evidence beside a server-owned Protected workload, all-target counts,
+independent task history, filter clearing and ordinary-poll disappearance/return.
+Desktop/narrow browser proof must exercise the parsed inventory consumer,
+filter interactions, scoped open records and literal long labels and inspect
+actual pixels. This corrects evidence scope, not original incident causality or
+native backup/guest recovery.
diff --git a/frontend-modern/src/features/proxmox/ProxmoxBackupsTable.tsx b/frontend-modern/src/features/proxmox/ProxmoxBackupsTable.tsx
index df7899e3f4..0a816d6aee 100644
--- a/frontend-modern/src/features/proxmox/ProxmoxBackupsTable.tsx
+++ b/frontend-modern/src/features/proxmox/ProxmoxBackupsTable.tsx
@@ -2,6 +2,7 @@ import { For, Show, createMemo, createSignal, type Component, type JSX } from 's
import ChevronRightIcon from 'lucide-solid/icons/chevron-right';
import { useLocation, useNavigate, useSearchParams } from '@solidjs/router';
import { FilterBar, type FilterDef, type FilterSelectOption } from '@/components/shared/FilterBar';
+import { InlineNotice } from '@/components/shared/InlineNotice';
import { useBreakpoint } from '@/hooks/useBreakpoint';
import { useProtectionPostures } from '@/hooks/useProtectionPostures';
import { createNonSuspendingQuery } from '@/hooks/createNonSuspendingQuery';
@@ -341,6 +342,15 @@ export const ProxmoxBackupsTable: Component<{
const locationSelection = createMemo(() =>
resolveBackupLocationFilter(locationFilter(), recoveryModel().recoverableArtifacts),
);
+ // A location narrows restore evidence, not the server's workload assessment
+ // or task history. Name only a resolved inventory location, never URL text.
+ const evidenceLocationLabel = createMemo(() => {
+ const key = locationSelection().key;
+ return key
+ ? recoveryModel().recoverableArtifacts.find((artifact) => artifact.locationKey === key)
+ ?.locationLabel
+ : undefined;
+ });
// Node options for the scope filter: the distinct nodes across the workload
// set, "All nodes" first. PBS snapshots carry no node, so this scopes the
@@ -790,7 +800,14 @@ export const ProxmoxBackupsTable: Component<{
{/* The health strip renders identically in both route-backed views. */}
<ProxmoxBackupsCoverageStrip
title="Backup health"
- footnote={getBackupPostureRuleText(protectionPostures.policy()) ?? undefined}
+ footnote={
+ <>
+ <span class="font-medium">
+ Health counts cover all targets and backup locations, regardless of filters.
+ </span>{' '}
+ {getBackupPostureRuleText(protectionPostures.policy())}
+ </>
+ }
tail={
<span>
{liveTotalCount()} targets ·{' '}
@@ -1004,6 +1021,19 @@ export const ProxmoxBackupsTable: Component<{
</Show>
<Show when={view() === 'coverage'}>
+ <Show when={evidenceLocationLabel()}>
+ {(label) => (
+ <InlineNotice
+ tone="info"
+ role="note"
+ aria-label="Backup location scope"
+ class="text-xs whitespace-normal wrap-anywhere"
+ >
+ Backup ages and restore evidence below use {label()}. Protection assessments and
+ task history are workload-wide, not a rating of this location.
+ </InlineNotice>
+ )}
+ </Show>
<ProxmoxCoverageTable
rows={liveCoverageRows()}
hasAnyRows={liveTotalCount() > 0}
@@ -1016,6 +1046,7 @@ export const ProxmoxBackupsTable: Component<{
expandedKey={expandedCoverageKey()}
onToggleExpand={toggleCoverageExpansion}
showTaskColumn={coverageHasTask()}
+ evidenceLocationLabel={evidenceLocationLabel()}
historyReadIncomplete={
inventoryIncomplete() ||
!protectionPostures.resolvedOnce() ||
@@ -1057,6 +1088,7 @@ export const ProxmoxBackupsTable: Component<{
expandedKey={expandedCoverageKey()}
onToggleExpand={toggleCoverageExpansion}
showTaskColumn={coverageHasTask()}
+ evidenceLocationLabel={evidenceLocationLabel()}
historyReadIncomplete={
inventoryIncomplete() ||
!protectionPostures.resolvedOnce() ||
diff --git a/frontend-modern/src/features/proxmox/ProxmoxCoverageTable.tsx b/frontend-modern/src/features/proxmox/ProxmoxCoverageTable.tsx
index c895fc26c2..445e295b61 100644
--- a/frontend-modern/src/features/proxmox/ProxmoxCoverageTable.tsx
+++ b/frontend-modern/src/features/proxmox/ProxmoxCoverageTable.tsx
@@ -331,6 +331,8 @@ export function ProxmoxCoverageTable(props: {
showTaskColumn: boolean;
/** Inventory or posture read is pending/failed; retained quality cannot confirm absence. */
historyReadIncomplete?: boolean;
+ /** Resolved restore-evidence filter; assessments and tasks remain workload-wide. */
+ evidenceLocationLabel?: string;
layoutWidth?: Accessor<number | null | undefined>;
}) {
const [evidenceLimit, setEvidenceLimit] = createSignal(COVERAGE_RESTORE_EVIDENCE_PAGE_SIZE);
@@ -727,6 +729,19 @@ export function ProxmoxCoverageTable(props: {
sections={buildCoverageDetailSections(row)}
onClose={() => props.onToggleExpand(row.key)}
>
+ <Show when={props.evidenceLocationLabel}>
+ {(label) => (
+ <InlineNotice
+ tone="info"
+ role="note"
+ aria-label="Restore evidence scope"
+ class="text-xs whitespace-normal wrap-anywhere"
+ >
+ Restore evidence: {label()}. Protection assessments and task
+ history cover the whole workload, not just this location.
+ </InlineNotice>
+ )}
+ </Show>
<div class="overflow-hidden rounded-sm border border-border bg-surface">
<Show
when={evidence().length > 0}
diff --git a/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx b/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx
index cd6e18e38b..a4e96568e0 100644
--- a/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx
+++ b/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx
@@ -23,7 +23,7 @@ import {
import { TABLE_CARD_FRAME_CLASS } from '@/components/shared/TableCard';
import type { Resource } from '@/types/resource';
import type { ProtectionPosturesResponse } from '@/types/recovery';
-import { protectionPolicy } from '@/utils/__fixtures__/protectionPosture';
+import { protectionPolicy, protectionPosture } from '@/utils/__fixtures__/protectionPosture';
import {
getRecoveryFullDateLabel,
getRecoveryPrettyDateLabel,
@@ -2169,6 +2169,7 @@ describe('backup location identity in the consuming views', () => {
).toBeInTheDocument();
expect(document.querySelectorAll('[data-proxmox-backup-row="coverage"]')).toHaveLength(0);
expect(document.body).not.toHaveTextContent('SYNTHETIC_UNKNOWN_LOCATION');
+ expect(screen.queryByRole('note', { name: 'Backup location scope' })).not.toBeInTheDocument();
});
it('withdraws a legacy selection when refreshed inventory makes it ambiguous, without broadening an exact choice', async () => {
@@ -2216,6 +2217,154 @@ describe('backup location identity in the consuming views', () => {
});
});
+describe('location-scoped evidence keeps workload-wide protection explicit', () => {
+ beforeEach(() => vi.useFakeTimers({ now: BACKUP_IDENTITY_NOW, toFake: ['Date'] }));
+ afterEach(() => vi.useRealTimers());
+
+ const scopeNote = () => screen.queryByRole('note', { name: 'Backup location scope' });
+ const pointTable = (panel: HTMLElement) =>
+ within(
+ within(panel).getByText('Restore evidence', { exact: true }).closest('div')!.parentElement!,
+ ).getByRole('table');
+ const setup = (kind: 'stale' | 'running' | 'snapshot') => {
+ const guest = identityGuest('east-100', 'east', 'pve-1');
+ const pve = {
+ data: {
+ backupTasks: [identityTask({ status: 'running', id: 'whole-workload-task' })],
+ storageBackups: [identityArchive({ storage: 'current-local' })],
+ guestSnapshots: kind === 'snapshot' ? [identitySnapshot()] : [],
+ },
+ };
+ const pbs = {
+ data: {
+ backups:
+ kind === 'snapshot'
+ ? []
+ : [
+ identityPBS({
+ datastore: 'offsite',
+ backupTime: '2026-09-04T10:00:00Z',
+ inProgress: kind === 'running',
+ }),
+ ],
+ },
+ };
+ apiFetchMock.mockImplementation((url: string) =>
+ Promise.resolve(jsonResponse(url.endsWith('/pbs') ? pbs : pve)),
+ );
+ const posture = {
+ ...protectionPosture(guest.id),
+ lastSuccessfulPointAt: '2026-10-04T11:00:00Z',
+ };
+ apiFetchJSONMock.mockResolvedValue({
+ data: [posture, { ...protectionPosture('west-101'), state: 'unprotected' }],
+ policy: protectionPolicy,
+ });
+ const key =
+ kind === 'snapshot' ? '["snapshot","east","pve-1"]' : '["pbs","pbs-server","offsite"]';
+ window.history.replaceState(
+ {},
+ '',
+ `/proxmox/backups/coverage?location=${encodeURIComponent(key)}`,
+ );
+ renderInRouter(() => (
+ <ProxmoxBackupsTable
+ emptyIcon={<span />}
+ workloads={[
+ guest,
+ {
+ ...identityGuest('west-101', 'west', 'pve-2'),
+ proxmox: { vmid: 101, instance: 'west', node: 'pve-2' },
+ },
+ ]}
+ />
+ ));
+ return {
+ pbs,
+ key,
+ label: kind === 'snapshot' ? 'Snapshot · east / pve-1' : 'PBS · pbs-server / offsite',
+ };
+ };
+
+ it.each(['stale', 'running', 'snapshot'] as const)(
+ 'qualifies %s selected evidence without recomputing protection, tasks or all-target counts',
+ async (kind) => {
+ const { label } = setup(kind);
+ const note = await screen.findByRole('note', { name: 'Backup location scope' });
+ expect(note).toHaveTextContent(label);
+ expect(note).toHaveTextContent('Backup ages and restore evidence below use');
+ expect(note).toHaveTextContent(
+ 'Protection assessments and task history are workload-wide, not a rating of this location.',
+ );
+ expect(screen.getByRole('button', { name: '1 protected' })).toBeInTheDocument();
+ expect(screen.getByRole('button', { name: '1 unprotected' })).toBeInTheDocument();
+ expect(
+ screen.getByText(
+ 'Health counts cover all targets and backup locations, regardless of filters.',
+ ),
+ ).toBeInTheDocument();
+ const row = document.querySelector<HTMLElement>('[data-proxmox-backup-row="coverage"]')!;
+ expect(document.querySelectorAll('[data-proxmox-backup-row="coverage"]')).toHaveLength(1);
+ expect(row).toHaveTextContent('Protected');
+ if (kind === 'stale')
+ expect(row.querySelector('[title*="2026-09-04T10:00:00Z"]')).not.toBeNull();
+ else expect(row).toHaveTextContent('Unknown');
+ const toggle = within(row).getByRole('button', { name: /Expand details/ });
+ fireEvent.click(toggle);
+ const panel = screen.getByTestId('proxmox-coverage-detail');
+ expect(within(panel).getByRole('note', { name: 'Restore evidence scope' })).toHaveTextContent(
+ label,
+ );
+ expect(panel).toHaveTextContent('cover the whole workload, not just this location.');
+ expect(panel).toHaveTextContent('A current verified backup is available.');
+ expect(panel).toHaveTextContent('whole-workload-task');
+ expect(pointTable(panel)).not.toHaveTextContent('current-local');
+ expect(pointTable(panel).querySelectorAll('tbody > tr')).toHaveLength(1);
+ expect(apiFetchMock).toHaveBeenCalledTimes(2);
+ expect(apiFetchJSONMock).toHaveBeenCalledTimes(1);
+
+ fireEvent.click(screen.getByRole('button', { name: 'Remove Backup location filter' }));
+ await waitFor(() => expect(scopeNote()).not.toBeInTheDocument());
+ expect(screen.getByTestId('proxmox-coverage-detail')).toBe(panel);
+ expect(
+ within(panel).queryByRole('note', { name: 'Restore evidence scope' }),
+ ).not.toBeInTheDocument();
+ expect(pointTable(panel)).toHaveTextContent('current-local');
+ expect(pointTable(panel).querySelectorAll('tbody > tr')).toHaveLength(2);
+ expect(screen.getByRole('button', { name: '1 protected' })).toBeInTheDocument();
+ expect(apiFetchMock).toHaveBeenCalledTimes(2);
+ expect(apiFetchJSONMock).toHaveBeenCalledTimes(1);
+ },
+ );
+
+ it('withdraws unresolved scope text on ordinary polling and restores only the inventory label', async () => {
+ vi.useFakeTimers({
+ now: BACKUP_IDENTITY_NOW,
+ toFake: ['Date', 'setInterval', 'clearInterval'],
+ });
+ const { pbs, key, label } = setup('stale');
+ await screen.findByRole('note', { name: 'Backup location scope' });
+ const original = structuredClone(pbs.data.backups);
+ pbs.data.backups = [];
+ await vi.advanceTimersByTimeAsync(30_000);
+ await screen.findByText(/saved backup location cannot be identified uniquely/);
+ expect(scopeNote()).not.toBeInTheDocument();
+ expect(document.querySelectorAll('[data-proxmox-backup-row="coverage"]')).toHaveLength(0);
+ expect(document.body).not.toHaveTextContent('current-local');
+ expect(new URLSearchParams(window.location.search).get('location')).toBe(key);
+ pbs.data.backups = original;
+ await vi.advanceTimersByTimeAsync(30_000);
+ expect(await screen.findByRole('note', { name: 'Backup location scope' })).toHaveTextContent(
+ label,
+ );
+ expect(
+ screen.queryByText(/saved backup location cannot be identified uniquely/),
+ ).not.toBeInTheDocument();
+ expect(apiFetchMock).toHaveBeenCalledTimes(6);
+ expect(apiFetchJSONMock).toHaveBeenCalledTimes(3);
+ });
+});
+
describe('backup activity follows the consuming inventory scope', () => {
afterEach(() => vi.restoreAllMocks());