Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Keep long version declarations from aborting issue triage

pulse-triage[bot]f8318cc04fab
diff --git a/.github/scripts/issue-version-triage.cjs b/.github/scripts/issue-version-triage.cjs
index e7c40b2496..1683c3132a 100644
--- a/.github/scripts/issue-version-triage.cjs
+++ b/.github/scripts/issue-version-triage.cjs
@@ -612,14 +612,23 @@ async function syncLabels({ github, context, core }) {
}
if (reportedVersion) {
- await ensureLabel(
- github,
- context,
- `${VERSION_LABEL_PREFIX}${reportedVersion}`,
- "0e8a16",
- `Bug reported against Pulse ${reportedVersion}`
- );
- nextLabels.add(`${VERSION_LABEL_PREFIX}${reportedVersion}`);
+ const versionLabel = `${VERSION_LABEL_PREFIX}${reportedVersion}`;
+ // GitHub label names stop at 50 characters. A longer declared version
+ // still supplies evidence, but cannot be represented as an exact label.
+ // Do not truncate it into a different version, or let that API validation
+ // failure prevent independent topic review and stale-metadata removal.
+ if (versionLabel.length <= 50) {
+ await ensureLabel(
+ github,
+ context,
+ versionLabel,
+ "0e8a16",
+ `Bug reported against Pulse ${reportedVersion}`
+ );
+ nextLabels.add(versionLabel);
+ } else {
+ core.info("Declared version exceeds the exact-version label limit; retaining its evidence without a version label.");
+ }
nextLabels.delete(NEEDS_VERSION_LABEL);
} else {
await ensureLabel(
diff --git a/.github/scripts/issue-version-triage.test.cjs b/.github/scripts/issue-version-triage.test.cjs
index f06a39e044..ad28c840c2 100644
--- a/.github/scripts/issue-version-triage.test.cjs
+++ b/.github/scripts/issue-version-triage.test.cjs
@@ -3178,3 +3178,42 @@ test("further activity during recovery history stops without another reconciliat
assert.deepEqual(calls.createComment, []);
}
});
+
+for (const labelLength of [50, 51, 512]) {
+ test(`a ${labelLength}-character version label cannot lose independent topic review`, async () => {
+ const version = `6.6.0-${"x".repeat(labelLength - "affects-6.6.0-".length)}`;
+ const versionLabel = `affects-${version}`;
+ assert.equal(versionLabel.length, labelLength);
+ const preserved = ["bug", "needs-human", "release-blocker", "needs-retest-on-latest", "operator-reviewed"];
+ const issue = { number: 2930, title: "Current report", comments: 0,
+ body: `### Pulse version\n${version}\n\n### Additional actionable topics\nThe saved connection also loses its label.`,
+ labels: [...preserved, "affects-6.5.0", "needs-version-info"].map(name => ({ name })) };
+ const { github, calls } = createGithub();
+ const createLabel = github.rest.issues.createLabel;
+ github.rest.issues.createLabel = async (payload) => {
+ if (payload.name.length > 50) {
+ throw Object.assign(new Error("Label name exceeds 50 characters"), {
+ status: 422,
+ response: { data: { errors: [{ resource: "Label", field: "name", code: "invalid" }] } },
+ });
+ }
+ return createLabel(payload);
+ };
+
+ await syncLabels({ github, context: createContext({ issue }), core: createCore() });
+
+ // A representation limit neither changes the declared version nor makes
+ // it missing. No truncated label or reporter request can substitute for it.
+ assert.equal(triage.internals.extractPulseVersion(issue.title, issue.body), version);
+ const expected = labelLength <= 50 ? [versionLabel, "needs-decomposition"] : ["needs-decomposition"];
+ assert.deepEqual(calls.addLabels.map(call => call.labels), [expected.sort()]);
+ assert.deepEqual(calls.createLabel.map(call => call.name).sort(), expected.sort());
+ assert.deepEqual(calls.getLabel.sort(), expected.sort(), "never send an oversized version label to GitHub");
+ assert.deepEqual(calls.removeLabel.map(call => call.name), ["affects-6.5.0", "needs-version-info"]);
+ assert.ok(!calls.removeLabel.some(call => preserved.includes(call.name)));
+ assert.deepEqual(calls.createComment, []);
+ assert.deepEqual(calls.getLatestRelease, []);
+ assert.deepEqual(calls.paginate, []);
+ assert.equal(calls.getIssue.length, 2, "keep the final live-read guard");
+ });
+}