Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Complete VM-only typing for guest read presentation

pulse-triage[bot]f9f53befbb4c
diff --git a/frontend-modern/browser-tests/guest-agent-coverage.cjs b/frontend-modern/browser-tests/guest-agent-coverage.cjs
index 15c9afb745..6487b06b33 100644
--- a/frontend-modern/browser-tests/guest-agent-coverage.cjs
+++ b/frontend-modern/browser-tests/guest-agent-coverage.cjs
@@ -4,7 +4,7 @@ const path = require('node:path');
const crypto = require('node:crypto');
const { chromium, webkit } = require('playwright');
const root = '/workspace/frontend-modern';
-const output = '/workspace/tmp/guest-agent-coverage-final-proof';
+const output = '/workspace/tmp/guest-agent-coverage-corrected-proof';
const runtime = [
'frontend-modern/src/components/Workloads/GuestDrawer.tsx',
'frontend-modern/src/components/Workloads/GuestDrawerOverview.tsx',
@@ -77,7 +77,7 @@ const initial = {
if (document.documentElement) apply();
else document.addEventListener('DOMContentLoaded', apply, { once: true });
}, dark);
- await page.routeWebSocket('**/ws', (ws) => ws.close());
+ await page.routeWebSocket(/.*/, (ws) => ws.close());
await page.route('**/*', async (route) => {
const req = route.request(),
url = new URL(req.url());
diff --git a/frontend-modern/browser-verification/3e80d53679a22f9e.json b/frontend-modern/browser-verification/3e80d53679a22f9e.json
new file mode 100644
index 0000000000..7e87d4bfed
--- /dev/null
+++ b/frontend-modern/browser-verification/3e80d53679a22f9e.json
@@ -0,0 +1,41 @@
+{
+ "version": 1,
+ "result": "passed",
+ "base_sha": "8f9a9a6a1e54962c9d81991ed51a8ff7e6c6b325",
+ "content_sha256": {
+ "frontend-modern/src/components/Workloads/guestDrawerModel.ts": "f42687d9b55b1456678db6eb134052d3de32b4e463ccae8c3a4eaaf73309ca08"
+ },
+ "changed_paths": ["frontend-modern/src/components/Workloads/guestDrawerModel.ts"],
+ "routes": ["/browser-tests/guest-agent-coverage.html", "/docs/VM_DISK_MONITORING"],
+ "states": [
+ "Current QGA deferral/unreachability/not-running/disabled/available/unknown independently of Pulse version metadata",
+ "Lock overrides cached availability",
+ "No version; parent-node assignment; fresh same-guest recovery"
+ ],
+ "interactions": [
+ "Keyboard disclosure on desktop and touch row on phones",
+ "Overview/History/Manage retain visible precaution and drawer identity",
+ "Keyboard/touch navigation into actual shipped backup-safety Docs; no diagnostic/mutation request"
+ ],
+ "viewports": [
+ {
+ "width": 1365,
+ "height": 900
+ },
+ {
+ "width": 390,
+ "height": 844
+ },
+ {
+ "width": 320,
+ "height": 844
+ }
+ ],
+ "verified_at": "2026-10-04T14:38:17.382Z",
+ "command": "pulse-worker-browser frontend-modern/browser-tests/guest-agent-coverage.cjs",
+ "playwright_version": "1.56.1",
+ "limitations": [
+ "Synthetic production-component proof, not native QGA availability, thaw, covered writes, installed acceptance or release qualification.",
+ "No memory provenance inferred from filesystem state; current Resource API exposes no memory source."
+ ]
+}
diff --git a/frontend-modern/src/components/Workloads/__tests__/GuestDrawerOverview.agent-state.test.tsx b/frontend-modern/src/components/Workloads/__tests__/GuestDrawerOverview.agent-state.test.tsx
index 9aa92b9d06..3f71c0e44c 100644
--- a/frontend-modern/src/components/Workloads/__tests__/GuestDrawerOverview.agent-state.test.tsx
+++ b/frontend-modern/src/components/Workloads/__tests__/GuestDrawerOverview.agent-state.test.tsx
@@ -3,6 +3,7 @@ import { createSignal, type ComponentProps } from 'solid-js';
import { afterEach, describe, expect, it, vi } from 'vitest';
import { GuestDrawerOverview } from '../GuestDrawerOverview';
import type { WorkloadGuest } from '@/types/workloads';
+import type { VM } from '@/types/api';
import {
GUEST_DRAWER_BACKUP_PRECAUTION,
getGuestDrawerGuestReadPresentation,
@@ -255,6 +256,6 @@ describe('backup activity is not a confirmed VM lock', () => {
expect(getGuestDrawerGuestReadPresentation(value)?.label).toBe('Backup in progress');
expect(getGuestDrawerGuestReadPrecaution(value)).toContain('A backup is reported in progress');
expect(getGuestDrawerGuestReadPrecaution(value)).not.toContain('VM operation lock');
- expect(value.guestAgentStatus).toBe('available');
+ expect((value as VM).guestAgentStatus).toBe('available');
});
});
diff --git a/frontend-modern/src/components/Workloads/guestDrawerModel.ts b/frontend-modern/src/components/Workloads/guestDrawerModel.ts
index 04514a3075..a48cf69ec0 100644
--- a/frontend-modern/src/components/Workloads/guestDrawerModel.ts
+++ b/frontend-modern/src/components/Workloads/guestDrawerModel.ts
@@ -473,6 +473,7 @@ export const getGuestDrawerGuestReadPresentation = (
// A read-specific precaution is independent of the reported availability flag.
// For example Proxmox can report QGA enabled while its last request timed out.
export const getGuestDrawerGuestReadPrecaution = (guest: Guest): string | null => {
+ if (!isGuestDrawerVM(guest)) return null;
const presentation = getGuestDrawerGuestReadPresentation(guest);
if (!presentation?.precaution) return null;
const reason = (guest.diskStatusReason || '').replace(/^prev-/, '');