Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.
Go aialertsdashboarddockerdocker-monitoringgohomelabinfrastructure-monitoringkubernetesmonitoringmspproxmoxproxmox-backup-serverproxmox-mail-gatewayproxmox-veself-hostedtruenastypescriptvspherewebhooks
Keep conflicting feedback categories out of automatic triage
pulse-triage[bot]fa95f81023df
diff --git a/.github/scripts/issue-version-triage.cjs b/.github/scripts/issue-version-triage.cjsindex 4e199384bd..eda09fc352 100644--- a/.github/scripts/issue-version-triage.cjs+++ b/.github/scripts/issue-version-triage.cjs@@ -208,12 +208,6 @@ function extractSectionValues(body, heading, followingHeadings = [], report = pareturn values;}-function extractSectionValue(body, heading, followingHeadings = [], report = parseReportMarkdown(body)) {- const values = extractSectionValues(body, heading, followingHeadings, report);- // An empty declared field differs from a legacy report with no field.- return values.length ? values[0] : null;-}-function additionalActionableTopicDeclarations(body, report = parseReportMarkdown(body)) {// Edited reports can move this field beside any other form field. Context// from those fields must not invent a topic or reopen a completed review.@@ -406,8 +400,7 @@ function extractPulseVersion(title, body, report = parseReportMarkdown(body)) {return extractTitlePulseVersion(title);}-function classifyV6FeedbackType(body, report = parseReportMarkdown(body)) {- const feedbackType = extractSectionValue(body, "Feedback type", [], report);+function classifyFeedbackSelection(feedbackType, report) {if (!feedbackType) return null;// This is a single-choice field, not free-form evidence. A link's target@@ -435,6 +428,17 @@ function classifyV6FeedbackType(body, report = parseReportMarkdown(body)) {}}+function classifyV6FeedbackType(body, report = parseReportMarkdown(body)) {+ const classes = extractSectionValues(body, "Feedback type", [], report)+ .map(value => classifyFeedbackSelection(value, report));+ // Repeated declarations must agree on the metadata category. Choosing the+ // first can invent a bug and its version requirements from contradictory or+ // withdrawn feedback. Unknown copies supply no automatic classification;+ // existing Community labels and independent topic review remain authoritative.+ const first = classes[0];+ return first && classes.every(value => value === first) ? first : null;+}+function parseCore(version) {const match = String(version || "").match(/^(\d+)\.(\d+)\.(\d+)/);if (!match) return null;diff --git a/.github/scripts/issue-version-triage.test.cjs b/.github/scripts/issue-version-triage.test.cjsindex 584f5de046..af51558281 100644--- a/.github/scripts/issue-version-triage.test.cjs+++ b/.github/scripts/issue-version-triage.test.cjs@@ -491,6 +491,98 @@ test("examples, withdrawn selections and prose do not invent a feedback class",}});+test("repeated feedback declarations require one recognised metadata category", () => {+ const { classifyV6FeedbackType } = triage.internals;+ for (const newline of ["\n", "\r\n"]) {+ for (const level of [2, 3, 6]) {+ const body = values => values.map(value =>+ `${"#".repeat(level)} Feedback type${newline}${value}${newline}`).join(newline);+ for (const [values, expected] of [+ [["Bug / regression", "Performance issue", "Upgrade / migration issue"], "bug"],+ [["Bug", "Regression"], "bug"],+ [["Documentation issue", "[**DOCUMENTATION ISSUE**](https://example.invalid/bugs)"], "documentation"],+ [["UX / workflow friction", "Other actionable feedback"], "enhancement"],+ [["Bug / regression", "Documentation issue"], null],+ [["Documentation issue", "UX / workflow friction"], null],+ [["Performance issue", "unknown"], null],+ [["Documentation issue", "_No response_"], null],+ [["UX / workflow friction", "~~Other actionable feedback~~"], null],+ [["Bug / regression", ""], null],+ [["unknown", ""], null],+ ]) {+ assert.equal(classifyV6FeedbackType(body(values)), expected, JSON.stringify(values));+ assert.equal(classifyV6FeedbackType(body([...values].reverse())), expected,+ "Field order cannot settle contradictory evidence");+ }+ }+ }+});++test("copied and secondary feedback fields cannot veto an agreeing primary category", () => {+ for (const copied of [+ "```markdown\n### Feedback type\nBug / regression\n```",+ "> ### Feedback type\n> Bug / regression",+ "<!--\n### Feedback type\nBug / regression\n-->",+ "### Additional actionable topics\nAnother job.\n#### Feedback type\nBug / regression",+ ]) {+ const body = `### Feedback type\nDocumentation issue\n\n${copied}\n\n` ++ "### Feedback type\n**Documentation issue**\n";+ assert.equal(triage.internals.classifyV6FeedbackType(body), "documentation", copied);+ }+});++for (const action of ["opened", "edited", "reopened"]) {+ test(`${action} consumes repeated feedback without invented categories or version demands`, async () => {+ const preserved = ["needs-human", "needs-retest-on-latest", "release-blocker",+ "stable-regression", "operator-reviewed"];+ for (const values of [+ ["Bug / regression", "Documentation issue"],+ ["Documentation issue", "UX / workflow friction"],+ ["Performance issue", "unknown"],+ ["Bug / regression", ""],+ ]) {+ for (const selections of [values, [...values].reverse()]) {+ for (const version of ["6.6.0", "unknown"]) {+ const { github, calls } = createGithub();+ const body = selections.map(value => `### Feedback type\n${value}\n`).join("\n") ++ `\n### Pulse version\n${version}\n\n### Additional actionable topics\nA separate saved-history problem.\n`;+ const issue = { number: 42, title: "Synthetic repeated feedback", comments: 0,+ labels: preserved.map(name => ({ name })), body };+ await syncLabels({ github, core: createCore(), context: createContext({ action, issue,+ previousBody: "### Additional actionable topics\nNone\n" }) });+ const expected = [...preserved, ...(action === "reopened" ? [] : ["needs-decomposition"])].sort();+ assert.deepEqual(github.currentIssue.labels.map(label => label.name).sort(), expected);+ assert.deepEqual(calls.addLabels.map(call => call.labels),+ action === "reopened" ? [] : [["needs-decomposition"]]);+ assert.deepEqual(calls.getLabel, action === "reopened" ? [] : ["needs-decomposition"]);+ assert.deepEqual(calls.removeLabel, []);+ assert.deepEqual(calls.createComment, []);+ assert.deepEqual(calls.getLatestRelease, []);+ assert.deepEqual(calls.paginate, []);+ }+ }+ }+ });+}++test("ambiguous feedback preserves an existing Community bug and its independent version metadata", async () => {+ for (const version of ["6.6.0", "unknown"]) {+ const { github, calls } = createGithub();+ const preserved = ["Bug", "needs-human", "needs-retest-on-latest", "operator-reviewed"];+ const issue = { number: 42, title: "Synthetic reviewed report", comments: 0,+ labels: [...preserved, "affects-6.5.0"].map(name => ({ name })),+ body: "### Feedback type\nDocumentation issue\n\n### Feedback type\nBug / regression\n\n" ++ `### Pulse version\n${version}\n` };+ await syncLabels({ github, core: createCore(), context: createContext({ issue }) });+ const expected = version === "unknown" ? "needs-version-info" : "affects-6.6.0";+ assert.deepEqual(github.currentIssue.labels.map(label => label.name).sort(), [...preserved, expected].sort());+ assert.deepEqual(calls.addLabels.map(call => call.labels), [[expected]]);+ assert.deepEqual(calls.removeLabel.map(call => call.name), ["affects-6.5.0"]);+ assert.deepEqual(calls.createComment, []);+ assert.deepEqual(calls.getLatestRelease, []);+ }+});+test("syncLabels consumes the selected feedback class without invented version demands or contact", async () => {for (const action of ["opened", "edited", "reopened"]) {for (const [selection, classification] of [