Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Find backup connections through the existing search

pulse-triage[bot]fdf82e5a23e4
diff --git a/docs/release-control/v6/internal/subsystems/frontend-primitives.md b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
index 382b2385cd..8b32180204 100644
--- a/docs/release-control/v6/internal/subsystems/frontend-primitives.md
+++ b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
@@ -30,6 +30,8 @@ inside its column; the existing restore-point detail names the full Connection
separately from Location, and Coverage wraps the full connection even when its
Location column is hidden on phones. Missing source identity stays explicit as
Unknown connection / Not reported, never inferred from the workload.
+Both existing text searches match the displayed connection (including Unknown
+connection), without changing the exact location filter or broadening its key.
`backupSourceConnection.test.tsx` exercises the actual API/model/table path
for PBS, PVE archives and guest snapshots, same-named sources, missing origins,
diff --git a/docs/release-control/v6/internal/subsystems/storage-recovery.md b/docs/release-control/v6/internal/subsystems/storage-recovery.md
index 2be4eb3cc1..5035da940b 100644
--- a/docs/release-control/v6/internal/subsystems/storage-recovery.md
+++ b/docs/release-control/v6/internal/subsystems/storage-recovery.md
@@ -25,7 +25,9 @@
The existing frontend location scope retains the backup reader's connection
as a display fact separately from its positional source/connection/repository
-key. Existing inventory and Coverage consumers show that connection, including
+key. Existing inventory and Coverage searches match the display connection,
+including an explicitly unknown origin, without changing exact filter keys.
+Existing inventory and Coverage consumers show that connection, including
the full value in restore-point details and wrapped Coverage evidence. No guest
node, namespace or workload connection supplies a missing backup origin.
Same-named repositories remain independently identified; existing exact and
diff --git a/docs/release-control/v6/internal/subsystems/unified-resources.md b/docs/release-control/v6/internal/subsystems/unified-resources.md
index 2a2654d648..378adb42b2 100644
--- a/docs/release-control/v6/internal/subsystems/unified-resources.md
+++ b/docs/release-control/v6/internal/subsystems/unified-resources.md
@@ -31,7 +31,9 @@ connection remains readable in the existing point detail and wrapped Coverage
evidence; a missing origin stays unknown rather than borrowing owner placement.
The frontend location scope carries this display fact without changing exact
source keys, resource/point IDs, namespace, routing, association or canonical
-protection assessment. `ProxmoxBackupsTable.test.tsx` and the normal-suite
+protection assessment. The existing text searches include that visible backup
+connection and its explicit unknown state, not a guessed owner connection.
+`ProxmoxBackupsTable.test.tsx` and the normal-suite
`backupSourceConnection.test.tsx` exercise inventory-to-consumer attribution,
unknowns and polling; desktop/narrow browser proof checks source readability.
This is not original multi-surface identity recovery or restore acceptance.
diff --git a/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx b/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx
index 88f862398f..047d66b351 100644
--- a/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx
+++ b/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx
@@ -2074,6 +2074,10 @@ describe('backup location identity in the consuming views', () => {
expect(points()[0].querySelector('[data-backup-source-connection]')).toHaveTextContent(
'Connection: pbs-main',
);
+ fireEvent.input(screen.getByPlaceholderText(/Search backups by workload/), {
+ target: { value: 'pbs-main' },
+ });
+ await waitFor(() => expect(points()).toHaveLength(1));
fireEvent.click(within(points()[0]).getByRole('button', { name: /expand details/i }));
const pointDetail = screen.getByTestId('proxmox-recoverable-detail');
expect(within(pointDetail).getByText('Connection').closest('tr')).toHaveTextContent('pbs-main');
diff --git a/frontend-modern/src/features/proxmox/__tests__/backupSourceConnection.test.tsx b/frontend-modern/src/features/proxmox/__tests__/backupSourceConnection.test.tsx
index 6414870421..bb74824614 100644
--- a/frontend-modern/src/features/proxmox/__tests__/backupSourceConnection.test.tsx
+++ b/frontend-modern/src/features/proxmox/__tests__/backupSourceConnection.test.tsx
@@ -77,6 +77,31 @@ afterEach(() => {
});
describe('restore-point source connections in real inventory consumers', () => {
+ it('finds the displayed connection in both existing search views without another read', async () => {
+ mount(() => points());
+ await inventoryRows();
+ const search = screen.getByPlaceholderText(/Search backups by workload/);
+ fireEvent.input(search, { target: { value: 'PBS-WEST' } });
+ await waitFor(() => {
+ const rows = document.querySelectorAll<HTMLElement>(
+ '[data-proxmox-backup-row="recoverable"]',
+ );
+ expect(rows).toHaveLength(1);
+ expect(connectionOf(rows[0])).toBe('Connection: pbs-west');
+ });
+ fireEvent.click(screen.getByRole('link', { name: /coverage/i }));
+ fireEvent.click(await screen.findByRole('button', { name: /expand details for same-name/i }));
+ expect(screen.getByTestId('proxmox-coverage-detail')).toHaveTextContent('pbs-west');
+ expect(new URLSearchParams(window.location.search).get('q')).toBe('PBS-WEST');
+ expect(new URLSearchParams(window.location.search).has('location')).toBe(false);
+ fireEvent.input(search, { target: { value: '' } });
+ fireEvent.click(screen.getByRole('link', { name: /by date/i }));
+ await waitFor(() =>
+ expect(document.querySelectorAll('[data-proxmox-backup-row="recoverable"]')).toHaveLength(2),
+ );
+ expect(api.fetch).toHaveBeenCalledTimes(2);
+ });
+
it.each(['pbs', 'archive', 'snapshot'] as const)(
'distinguishes same-named %s repositories and workloads in rows and full details',
async (kind) => {
diff --git a/frontend-modern/src/features/proxmox/__tests__/proxmoxBackupRecoveryModel.test.ts b/frontend-modern/src/features/proxmox/__tests__/proxmoxBackupRecoveryModel.test.ts
index dc5b7f6670..f58723cb40 100644
--- a/frontend-modern/src/features/proxmox/__tests__/proxmoxBackupRecoveryModel.test.ts
+++ b/frontend-modern/src/features/proxmox/__tests__/proxmoxBackupRecoveryModel.test.ts
@@ -98,6 +98,31 @@ const protectionPosture = (resourceId: string, state: ProtectionState): Protecti
});
describe('proxmoxBackupRecoveryModel', () => {
+ it.each(['pbs-west', undefined])(
+ 'searches the displayed backup connection independently of workload placement: %s',
+ (instance) => {
+ const model = buildProxmoxBackupRecoveryModel({
+ workloads: [workload({})],
+ pbsBackups: [pbsBackup({ id: 'point', instance })],
+ archives: [],
+ snapshots: [],
+ tasks: [],
+ nowMs: Date.parse('2026-05-26T00:00:00Z'),
+ });
+ const [point] = model.recoverableArtifacts;
+ const [row] = model.coverageRows;
+ expect(point.locationConnection).toBe(instance);
+ expect(point.workload.instance).toBe('homelab');
+ expect(point.nativeId).toBe('point');
+ expect(JSON.parse(point.locationKey!)).toEqual(['pbs', instance ?? '', 'main']);
+ const query = instance?.toUpperCase() ?? 'Unknown connection';
+ expect(recoverableArtifactMatchesSearch(point, query)).toBe(true);
+ expect(coverageRowMatchesSearch(row, query)).toBe(true);
+ expect(recoverableArtifactMatchesSearch(point, 'absent-backup-connection')).toBe(false);
+ expect(coverageRowMatchesSearch(row, 'absent-backup-connection')).toBe(false);
+ },
+ );
+
it('classifies backup ages for restore-point presentation', () => {
const nowMs = Date.parse('2026-05-26T08:00:00Z');
diff --git a/frontend-modern/src/features/proxmox/proxmoxBackupRecoveryModel.ts b/frontend-modern/src/features/proxmox/proxmoxBackupRecoveryModel.ts
index cf69509864..2c61ea2454 100644
--- a/frontend-modern/src/features/proxmox/proxmoxBackupRecoveryModel.ts
+++ b/frontend-modern/src/features/proxmox/proxmoxBackupRecoveryModel.ts
@@ -811,6 +811,7 @@ export function coverageRowMatchesSearch(row: WorkloadCoverageRow, term: string)
...row.artifacts.flatMap((artifact) => [
artifact.sourceLabel,
artifact.sourceTitle,
+ artifact.locationConnection || 'unknown connection',
artifact.location,
artifact.detail,
]),
@@ -835,6 +836,7 @@ export function recoverableArtifactMatchesSearch(
artifact.workload.instance,
artifact.sourceLabel,
artifact.sourceTitle,
+ artifact.locationConnection || 'unknown connection',
artifact.location,
artifact.detail,
artifact.detailTitle,