Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Keep retained backup readings anchored after layout changes

pulse-triage[bot]fe23cc99a0d9
diff --git a/docs/release-control/v6/internal/subsystems/frontend-primitives.md b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
index 2642662287..5fa49ebb02 100644
--- a/docs/release-control/v6/internal/subsystems/frontend-primitives.md
+++ b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
@@ -10502,7 +10502,7 @@ input. A removed focused day returns to the selected activity-range control,
without changing the saved day filter or moving focus from another control.
The open tooltip reads the current bucket for its day, not a retained count or
-volume snapshot. Removed days withdraw the reading, including on return until a
+volume snapshot, and follows the actual control after inventory layout changes. Removed days withdraw the reading, including on return until a
new interaction. Unknown-volume markers and counts update together. Reconciled
chart values must not mutate the caller's inventory-derived DTOs.
diff --git a/docs/release-control/v6/internal/subsystems/storage-recovery.md b/docs/release-control/v6/internal/subsystems/storage-recovery.md
index e3fe61b938..8a8df9e2d7 100644
--- a/docs/release-control/v6/internal/subsystems/storage-recovery.md
+++ b/docs/release-control/v6/internal/subsystems/storage-recovery.md
@@ -8113,7 +8113,7 @@ input. A removed focused day returns to the selected activity-range control,
without changing the saved day filter or moving focus from another control.
The open tooltip reads the current bucket for its day, not a retained count or
-volume snapshot. Removed days withdraw the reading, including on return until a
+volume snapshot, and follows the actual control after inventory layout changes. Removed days withdraw the reading, including on return until a
new interaction. Unknown-volume markers and counts update together. Reconciled
chart values must not mutate the caller's inventory-derived DTOs.
diff --git a/frontend-modern/src/features/proxmox/BackupActivityChart.tsx b/frontend-modern/src/features/proxmox/BackupActivityChart.tsx
index a7cf8fa1ba..16eda3576c 100644
--- a/frontend-modern/src/features/proxmox/BackupActivityChart.tsx
+++ b/frontend-modern/src/features/proxmox/BackupActivityChart.tsx
@@ -1,4 +1,12 @@
-import { createComputed, createMemo, createSignal, For, Show, untrack } from 'solid-js';
+import {
+ createComputed,
+ createEffect,
+ createMemo,
+ createSignal,
+ For,
+ Show,
+ untrack,
+} from 'solid-js';
import { createStore, reconcile } from 'solid-js/store';
import type { Accessor, Component } from 'solid-js';
@@ -43,6 +51,7 @@ import {
interface TooltipState {
key: string;
+ element: HTMLButtonElement;
x: number;
y: number;
}
@@ -135,16 +144,30 @@ export const BackupActivityChart: Component<BackupActivityChartProps> = (props)
const chartGapStyle = () => `${getRecoveryTimelineChartGapPx(props.range())}px`;
- const showTooltip = (target: HTMLElement, key: string) => {
+ const showTooltip = (target: HTMLButtonElement, key: string) => {
const rect = target.getBoundingClientRect();
setTooltip({
key,
+ element: target,
x: rect.left + rect.width / 2,
y: rect.top,
});
};
const hideTooltip = () => setTooltip(null);
+ // Retaining the control also retains its reading. After the DOM updates,
+ // follow the real anchor: inventory notices, metric labels and calendar
+ // rollover can move it even though its logical day and focus stay the same.
+ createEffect(() => {
+ props.timeline();
+ props.range();
+ metricMode();
+ const target = untrack(tooltip);
+ if (!target) return;
+ const rect = target.element.getBoundingClientRect();
+ setTooltip({ ...target, x: rect.left + rect.width / 2, y: rect.top });
+ });
+
return (
<div class="rounded-lg border border-border-subtle px-2 py-2">
<div class="mb-2 flex flex-col gap-1.5 lg:flex-row lg:items-center lg:justify-between">
diff --git a/frontend-modern/src/features/proxmox/__tests__/BackupActivityChart.test.tsx b/frontend-modern/src/features/proxmox/__tests__/BackupActivityChart.test.tsx
index f4ae117e08..7bcf308d4b 100644
--- a/frontend-modern/src/features/proxmox/__tests__/BackupActivityChart.test.tsx
+++ b/frontend-modern/src/features/proxmox/__tests__/BackupActivityChart.test.tsx
@@ -1,4 +1,4 @@
-import { cleanup, fireEvent, render, screen, within } from '@solidjs/testing-library';
+import { cleanup, fireEvent, render, screen, waitFor, within } from '@solidjs/testing-library';
import { createSignal } from 'solid-js';
import { afterEach, describe, expect, it, vi } from 'vitest';
@@ -51,7 +51,10 @@ function mount() {
return { data, setData, selected, setMode, onToggleDay };
}
-afterEach(cleanup);
+afterEach(() => {
+ cleanup();
+ vi.restoreAllMocks();
+});
describe('backup activity interaction continuity', () => {
it('keeps the exact focused day across fresh inventory objects and updates its reading', () => {
@@ -99,6 +102,23 @@ describe('backup activity interaction continuity', () => {
expect(tooltip()).toBeNull();
});
+ it('reanchors the retained reading after inventory layout changes', async () => {
+ const { setData } = mount();
+ const target = day('2026-10-28');
+ let top = 200;
+ vi.spyOn(target, 'getBoundingClientRect').mockImplementation(
+ () => new DOMRect(100, top, 20, 80),
+ );
+ target.focus();
+ const portal = () => document.querySelector('foreignObject');
+ await waitFor(() => expect(portal()).toHaveAttribute('y', '192'));
+ top = 250;
+ setData(timeline([point('2026-10-27', 1), point('2026-10-28', 3)]));
+ await waitFor(() => expect(portal()).toHaveAttribute('y', '242'));
+ expect(target).toHaveFocus();
+ expect(tooltip()).toHaveTextContent('3 restore points');
+ });
+
it('keeps a surviving calendar day, not its array index, when the window rolls over', () => {
const { setData } = mount();
const target = day('2026-10-28');